From f881835da210fa98d822010c3c9afae4d65d5572 Mon Sep 17 00:00:00 2001 From: Juergen Spitzmueller Date: Mon, 1 Oct 2012 12:37:16 +0200 Subject: [PATCH] Ask for saving changes when branch state in child was altered --- src/insets/InsetBranch.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/insets/InsetBranch.cpp b/src/insets/InsetBranch.cpp index e966de29ea..db047c2f3d 100644 --- a/src/insets/InsetBranch.cpp +++ b/src/insets/InsetBranch.cpp @@ -33,6 +33,7 @@ #include "support/gettext.h" #include "support/lstrings.h" +#include "frontends/alert.h" #include "frontends/Application.h" #include @@ -159,10 +160,19 @@ void InsetBranch::doDispatch(Cursor & cur, FuncRequest & cmd) // call recordUndo..., because the master may be hidden, and // the code presently assumes that hidden documents can never // be dirty. See GuiView::closeBufferAll(), for example. + // An option would be to check if the master is hidden. + // If it is, unhide. if (!master) buffer().undo().recordUndoFullDocument(cur); + else + // at least issue a warning for now (ugly, but better than dataloss). + frontend::Alert::warning(_("Branch state changes in master document"), + lyx::support::bformat(_("The state of the branch '%1$s' " + "was changed in the master file. " + "Please make sure to save the master."), params_.branch), true); our_branch->setSelected(activate); - cur.forceBufferUpdate(); + // cur.forceBufferUpdate() is not enough + buf->updateBuffer(); } break; } -- 2.39.2