From f3656600f954e06138eb0cab7129c54288a9e0d9 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Wed, 29 Nov 2017 14:55:56 +0100 Subject: [PATCH] Use UndoGroupHelper to track undo group lifetime --- src/frontends/qt4/GuiCompleter.cpp | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/src/frontends/qt4/GuiCompleter.cpp b/src/frontends/qt4/GuiCompleter.cpp index 9858b8d01a..c90520dc92 100644 --- a/src/frontends/qt4/GuiCompleter.cpp +++ b/src/frontends/qt4/GuiCompleter.cpp @@ -676,7 +676,7 @@ void GuiCompleter::tab() } // Make undo possible - cur.beginUndoGroup(); + UndoGroupHelper ugh; cur.recordUndo(); // If completion is active, at least complete by one character @@ -690,14 +690,11 @@ void GuiCompleter::tab() hidePopup(); hideInline(cur); updateVisibility(false, false); - cur.endUndoGroup(); return; } docstring nextchar = completion.substr(prefix.size(), 1); - if (!cur.inset().insertCompletion(cur, nextchar, false)) { - cur.endUndoGroup(); + if (!cur.inset().insertCompletion(cur, nextchar, false)) return; - } updatePrefix(cur); // try to complete as far as it is unique @@ -717,7 +714,6 @@ void GuiCompleter::tab() // redraw if needed if (cur.result().screenUpdate()) gui_->bufferView().processUpdateFlags(cur.result().screenUpdate()); - cur.endUndoGroup(); } -- 2.39.2