From ecaff823df33bb788f92d1c06a65a6ff3455b239 Mon Sep 17 00:00:00 2001
From: =?utf8?q?Lars=20Gullik=20Bj=C3=B8nnes?= <larsbj@gullik.org>
Date: Fri, 30 Jun 2006 14:11:50 +0000
Subject: [PATCH] delete some emits that I missed, add comments about emitting
 signals

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@14273 a592a061-630c-0410-9148-cb99ea01b6c8
---
 src/frontends/qt3/BulletsModule.C     |  5 +++++
 src/frontends/qt3/QBrowseBox.C        |  1 +
 src/frontends/qt3/QCommandBuffer.C    |  1 +
 src/frontends/qt3/QCommandEdit.C      |  4 ++++
 src/frontends/qt3/emptytable.C        |  2 ++
 src/frontends/qt3/floatplacement.C    |  1 +
 src/frontends/qt3/iconpalette.C       |  3 ++-
 src/frontends/qt3/lengthcombo.C       |  1 +
 src/frontends/qt3/qsetborder.C        |  5 +++++
 src/frontends/qt4/BulletsModule.C     | 15 ++++++++++-----
 src/frontends/qt4/InsertTableWidget.C |  6 ++++--
 src/frontends/qt4/QBranches.C         |  3 ++-
 src/frontends/qt4/QCommandBuffer.C    |  3 ++-
 src/frontends/qt4/QCommandEdit.C      | 12 ++++++++----
 src/frontends/qt4/QLToolbar.C         |  3 ++-
 src/frontends/qt4/QMathDialog.h       |  3 ++-
 src/frontends/qt4/QPrefsDialog.C      |  1 +
 src/frontends/qt4/emptytable.C        |  6 ++++--
 src/frontends/qt4/floatplacement.C    |  3 ++-
 src/frontends/qt4/iconpalette.C       |  3 ++-
 src/frontends/qt4/lengthcombo.C       |  3 ++-
 src/frontends/qt4/qsetborder.C        | 15 ++++++++++-----
 22 files changed, 73 insertions(+), 26 deletions(-)

diff --git a/src/frontends/qt3/BulletsModule.C b/src/frontends/qt3/BulletsModule.C
index fcc356500e..e8d55bf93c 100644
--- a/src/frontends/qt3/BulletsModule.C
+++ b/src/frontends/qt3/BulletsModule.C
@@ -142,6 +142,7 @@ BulletsModule::~BulletsModule()
 
 void BulletsModule::updateSizes()
 {
+        // emit signal
 	changed();
 
 	// -1 apparently means default...
@@ -185,6 +186,7 @@ void BulletsModule::selected1()
 	tmpbulletset = false;
 	bullets_[0] = tmpbullet;
 	setBullet(bullet1PB, bulletsize1CO, bullets_[0]);
+        // emit signal
 	changed();
 }
 
@@ -196,6 +198,7 @@ void BulletsModule::selected2()
 	tmpbulletset = false;
 	bullets_[1] = tmpbullet;
 	setBullet(bullet2PB, bulletsize2CO, bullets_[1]);
+        // emit signal
 	changed();
 }
 
@@ -207,6 +210,7 @@ void BulletsModule::selected3()
 	tmpbulletset = false;
 	bullets_[2] = tmpbullet;
 	setBullet(bullet3PB, bulletsize3CO, bullets_[2]);
+        // emit signal
 	changed();
 }
 
@@ -218,6 +222,7 @@ void BulletsModule::selected4()
 	tmpbulletset = false;
 	bullets_[3] = tmpbullet;
 	setBullet(bullet4PB, bulletsize4CO, bullets_[3]);
+        // emit signal
 	changed();
 }
 
diff --git a/src/frontends/qt3/QBrowseBox.C b/src/frontends/qt3/QBrowseBox.C
index 4bca767263..12fb87c3ab 100644
--- a/src/frontends/qt3/QBrowseBox.C
+++ b/src/frontends/qt3/QBrowseBox.C
@@ -161,6 +161,7 @@ void QBrowseBox::keyPressEvent(QKeyEvent * e)
 		moveRight();
 		break;
 	case Key_Return:
+                // emit signal
 		selected(activecell_.x(), activecell_.y());
 		if ( isVisible() && parentWidget() &&
 		     parentWidget()->inherits("QPopupMenu") )
diff --git a/src/frontends/qt3/QCommandBuffer.C b/src/frontends/qt3/QCommandBuffer.C
index 70fb5f4f1a..5abc67af17 100644
--- a/src/frontends/qt3/QCommandBuffer.C
+++ b/src/frontends/qt3/QCommandBuffer.C
@@ -50,6 +50,7 @@ protected:
 		    || e->x() > width() || e->y() > height()) {
 			hide();
 		} else {
+                        // emit signal
 			selected(currentText());
 		}
 	}
diff --git a/src/frontends/qt3/QCommandEdit.C b/src/frontends/qt3/QCommandEdit.C
index 540d70140f..564e64ff1c 100644
--- a/src/frontends/qt3/QCommandEdit.C
+++ b/src/frontends/qt3/QCommandEdit.C
@@ -26,14 +26,17 @@ void QCommandEdit::keyPressEvent(QKeyEvent * e)
 {
 	switch (e->key()) {
 	case Key_Escape:
+                // emit signal
 		escapePressed();
 		break;
 
 	case Key_Up:
+                // emit signal
 		upPressed();
 		break;
 
 	case Key_Down:
+                // emit signal
 		downPressed();
 		break;
 
@@ -54,6 +57,7 @@ bool QCommandEdit::event(QEvent * e)
 	if (ev->key() != Key_Tab)
 		return QLineEdit::event(e);
 
+        // emit signal
 	tabPressed();
 	return true;
 }
diff --git a/src/frontends/qt3/emptytable.C b/src/frontends/qt3/emptytable.C
index a82235ceba..e07910aeec 100644
--- a/src/frontends/qt3/emptytable.C
+++ b/src/frontends/qt3/emptytable.C
@@ -75,6 +75,7 @@ void EmptyTable::setNumberColumns(int nr_cols)
 	updateGeometry();
 	setAutoUpdate(true);
 	update();
+        // emit signal
 	colsChanged(nr_cols);
 }
 
@@ -90,6 +91,7 @@ void EmptyTable::setNumberRows(int nr_rows)
 	updateGeometry();
 	setAutoUpdate(true);
 	update();
+        // emit signal
 	rowsChanged(nr_rows);
 }
 
diff --git a/src/frontends/qt3/floatplacement.C b/src/frontends/qt3/floatplacement.C
index 37ee9fbe17..77eb940b0c 100644
--- a/src/frontends/qt3/floatplacement.C
+++ b/src/frontends/qt3/floatplacement.C
@@ -101,6 +101,7 @@ void FloatPlacement::useSideways()
 
 void FloatPlacement::changedSlot()
 {
+        // emit signal
 	changed();
 }
 
diff --git a/src/frontends/qt3/iconpalette.C b/src/frontends/qt3/iconpalette.C
index 1a814b067e..82d5669015 100644
--- a/src/frontends/qt3/iconpalette.C
+++ b/src/frontends/qt3/iconpalette.C
@@ -57,7 +57,8 @@ void IconPalette::clicked()
 	vector<Button>::const_iterator const end(buttons_.end());
 	for (; it != end; ++it) {
 		if (sender() == it->first) {
-			 button_clicked(it->second);
+                        // emit signal
+                        button_clicked(it->second);
 			return;
 		}
 	}
diff --git a/src/frontends/qt3/lengthcombo.C b/src/frontends/qt3/lengthcombo.C
index cc29ddb070..35f87e23e4 100644
--- a/src/frontends/qt3/lengthcombo.C
+++ b/src/frontends/qt3/lengthcombo.C
@@ -35,6 +35,7 @@ LyXLength::UNIT LengthCombo::currentLengthItem() const
 
 void LengthCombo::has_activated(int)
 {
+        // emit signal
 	selectionChanged(currentLengthItem());
 }
 
diff --git a/src/frontends/qt3/qsetborder.C b/src/frontends/qt3/qsetborder.C
index 7ee1b73841..4975de81ac 100644
--- a/src/frontends/qt3/qsetborder.C
+++ b/src/frontends/qt3/qsetborder.C
@@ -71,11 +71,13 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
 		if (e->y() < height() - e->x()) {
 			if (left_.enabled) {
 				setLeft(!left_.set);
+                                // emit signal
 				leftSet(left_.set);
 			}
 		} else {
 			if (bottom_.enabled) {
 				setBottom(!bottom_.set);
+                                // emit signal
 				bottomSet(bottom_.set);
 			}
 		}
@@ -83,16 +85,19 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
 		if (e->y() < height() - e->x()) {
 			if (top_.enabled) {
 				setTop(!top_.set);
+                                // emit signal
 				topSet(top_.set);
 			}
 		} else {
 			if (right_.enabled) {
 				setRight(!right_.set);
+                                // emit signal
 				rightSet(right_.set);
 			}
 		}
 	}
 	update();
+        // emit signal
 	clicked();
 }
 
diff --git a/src/frontends/qt4/BulletsModule.C b/src/frontends/qt4/BulletsModule.C
index 54b85691ed..9aabcbdff3 100644
--- a/src/frontends/qt4/BulletsModule.C
+++ b/src/frontends/qt4/BulletsModule.C
@@ -149,7 +149,8 @@ BulletsModule::~BulletsModule()
 
 void BulletsModule::updateSizes()
 {
-	emit changed();
+        // emit signal
+	changed();
 
 	// -1 apparently means default...
 	bullets_[0].setSize(bulletsize1CO->currentItem() - 1);
@@ -192,7 +193,8 @@ void BulletsModule::selected1()
 	tmpbulletset = false;
 	bullets_[0] = tmpbullet;
 	setBullet(bullet1PB, bulletsize1CO, bullets_[0]);
-	emit changed();
+        // emit signal
+	changed();
 }
 
 
@@ -203,7 +205,8 @@ void BulletsModule::selected2()
 	tmpbulletset = false;
 	bullets_[1] = tmpbullet;
 	setBullet(bullet2PB, bulletsize2CO, bullets_[1]);
-	emit changed();
+        // emit signal
+	changed();
 }
 
 
@@ -214,7 +217,8 @@ void BulletsModule::selected3()
 	tmpbulletset = false;
 	bullets_[2] = tmpbullet;
 	setBullet(bullet3PB, bulletsize3CO, bullets_[2]);
-	emit changed();
+        // emit signal
+	changed();
 }
 
 
@@ -225,7 +229,8 @@ void BulletsModule::selected4()
 	tmpbulletset = false;
 	bullets_[3] = tmpbullet;
 	setBullet(bullet4PB, bulletsize4CO, bullets_[3]);
-	emit changed();
+        // emit signal
+	changed();
 }
 
 
diff --git a/src/frontends/qt4/InsertTableWidget.C b/src/frontends/qt4/InsertTableWidget.C
index 319e6fd227..7b43f45bbd 100644
--- a/src/frontends/qt4/InsertTableWidget.C
+++ b/src/frontends/qt4/InsertTableWidget.C
@@ -55,7 +55,8 @@ void InsertTableWidget::show(bool show)
 	init();
 	resetGeometry();
 	setVisible(true);
-	emit visible(true);
+        // emit signal
+	visible(true);
 }
 
 
@@ -109,7 +110,8 @@ void InsertTableWidget::mouseReleaseEvent(QMouseEvent * event)
 		QString const data = QString("%1 %2").arg(bottom_).arg(right_);
 		lyxView_.getLyXFunc().dispatch(FuncRequest(LFUN_TABULAR_INSERT, fromqstr(data)));
 	}
-	emit visible(false);
+        // emit signal
+	visible(false);
 	close();
 }
 
diff --git a/src/frontends/qt4/QBranches.C b/src/frontends/qt4/QBranches.C
index 39776cef95..e0f1c1275f 100644
--- a/src/frontends/qt4/QBranches.C
+++ b/src/frontends/qt4/QBranches.C
@@ -86,7 +86,8 @@ void QBranches::update()
 		if (bname == sel_branch)
 			branchesTW->setItemSelected(newItem, true);
 	}
-	emit changed();
+        // emit signal
+	changed();
 }
 
 void QBranches::apply(BufferParams & params) const
diff --git a/src/frontends/qt4/QCommandBuffer.C b/src/frontends/qt4/QCommandBuffer.C
index d2eab207c9..7081e0820e 100644
--- a/src/frontends/qt4/QCommandBuffer.C
+++ b/src/frontends/qt4/QCommandBuffer.C
@@ -58,7 +58,8 @@ protected:
 		    || e->x() > width() || e->y() > height()) {
 			hide();
 		} else {
-			emit itemPressed(currentItem());
+                        // emit signal
+			itemPressed(currentItem());
 		}
 	}
 
diff --git a/src/frontends/qt4/QCommandEdit.C b/src/frontends/qt4/QCommandEdit.C
index dd786e6072..d0882f49d7 100644
--- a/src/frontends/qt4/QCommandEdit.C
+++ b/src/frontends/qt4/QCommandEdit.C
@@ -29,15 +29,18 @@ void QCommandEdit::keyPressEvent(QKeyEvent * e)
 {
 	switch (e->key()) {
 	case Qt::Key_Escape:
-		emit escapePressed();
+                // emit signal
+		escapePressed();
 		break;
 
 	case Qt::Key_Up:
-		emit upPressed();
+                // emit signal
+		upPressed();
 		break;
 
 	case Qt::Key_Down:
-		emit downPressed();
+                // emit signal
+		downPressed();
 		break;
 
 	default:
@@ -57,7 +60,8 @@ bool QCommandEdit::event(QEvent * e)
 	if (ev->key() != Qt::Key_Tab)
 		return QLineEdit::event(e);
 
-	emit tabPressed();
+        // emit signal
+	tabPressed();
 	return true;
 }
 
diff --git a/src/frontends/qt4/QLToolbar.C b/src/frontends/qt4/QLToolbar.C
index 91c4e8a58c..10df4f9143 100644
--- a/src/frontends/qt4/QLToolbar.C
+++ b/src/frontends/qt4/QLToolbar.C
@@ -282,7 +282,8 @@ void QLToolbar::update()
 	for (size_t i=0; i<ActionVector.size(); ++i)
 		ActionVector[i]->update();
 
-	emit updated();
+        // emit signal
+	updated();
 }
 
 
diff --git a/src/frontends/qt4/QMathDialog.h b/src/frontends/qt4/QMathDialog.h
index 1a49f572ef..633506b8b7 100644
--- a/src/frontends/qt4/QMathDialog.h
+++ b/src/frontends/qt4/QMathDialog.h
@@ -34,7 +34,8 @@ signals:
 	void action(const std::string &);
 protected slots:
 	void action() {
-		emit action(action_);
+                // emit signal
+		action(action_);
 	}
 private:
 	std::string action_;
diff --git a/src/frontends/qt4/QPrefsDialog.C b/src/frontends/qt4/QPrefsDialog.C
index f421b348e8..4b04e673eb 100644
--- a/src/frontends/qt4/QPrefsDialog.C
+++ b/src/frontends/qt4/QPrefsDialog.C
@@ -560,6 +560,7 @@ void PrefColors::change_color()
 		QPixmap coloritem(32, 32);
 		coloritem.fill(c);
 		lyxObjectsLW->currentItem()->setIcon(QIcon(coloritem));
+                // emit signal
 		changed();
 	}
 }
diff --git a/src/frontends/qt4/emptytable.C b/src/frontends/qt4/emptytable.C
index 888d288c93..53925c2e76 100644
--- a/src/frontends/qt4/emptytable.C
+++ b/src/frontends/qt4/emptytable.C
@@ -81,7 +81,8 @@ void EmptyTable::setNumberColumns(int nr_cols)
 	setColumnCount(nr_cols);
 	resetCellSize();
 	updateGeometry();
-	emit colsChanged(nr_cols);
+        // emit signal
+	colsChanged(nr_cols);
 }
 
 
@@ -94,7 +95,8 @@ void EmptyTable::setNumberRows(int nr_rows)
 	setRowCount(nr_rows);
 	resetCellSize();
 	updateGeometry();
-	emit rowsChanged(nr_rows);
+        // emit signal
+	rowsChanged(nr_rows);
 }
 
 /*
diff --git a/src/frontends/qt4/floatplacement.C b/src/frontends/qt4/floatplacement.C
index 54fba48b8e..3151a7f008 100644
--- a/src/frontends/qt4/floatplacement.C
+++ b/src/frontends/qt4/floatplacement.C
@@ -104,7 +104,8 @@ void FloatPlacement::useSideways()
 
 void FloatPlacement::changedSlot()
 {
-	emit changed();
+        // emit signal
+	changed();
 }
 
 
diff --git a/src/frontends/qt4/iconpalette.C b/src/frontends/qt4/iconpalette.C
index 6766c5e85e..c3c508c2ce 100644
--- a/src/frontends/qt4/iconpalette.C
+++ b/src/frontends/qt4/iconpalette.C
@@ -62,7 +62,8 @@ void IconPalette::clicked()
 	vector<Button>::const_iterator const end(buttons_.end());
 	for (; it != end; ++it) {
 		if (sender() == it->first) {
-			emit button_clicked(it->second);
+                        // emit signal
+			button_clicked(it->second);
 			return;
 		}
 	}
diff --git a/src/frontends/qt4/lengthcombo.C b/src/frontends/qt4/lengthcombo.C
index 2d681fb9c8..197e90ae5d 100644
--- a/src/frontends/qt4/lengthcombo.C
+++ b/src/frontends/qt4/lengthcombo.C
@@ -44,7 +44,8 @@ LyXLength::UNIT LengthCombo::currentLengthItem() const
 
 void LengthCombo::has_activated(int)
 {
-	emit selectionChanged(currentLengthItem());
+        // emit signal
+	selectionChanged(currentLengthItem());
 }
 
 
diff --git a/src/frontends/qt4/qsetborder.C b/src/frontends/qt4/qsetborder.C
index 542ca8e43e..c6e1861fdf 100644
--- a/src/frontends/qt4/qsetborder.C
+++ b/src/frontends/qt4/qsetborder.C
@@ -74,29 +74,34 @@ void QSetBorder::mousePressEvent(QMouseEvent * e)
 		if (e->y() < height() - e->x()) {
 			if (left_.enabled) {
 				setLeft(!left_.set);
-				emit leftSet(left_.set);
+                                // emit signal
+				leftSet(left_.set);
 			}
 		} else {
 			if (bottom_.enabled) {
 				setBottom(!bottom_.set);
-				emit bottomSet(bottom_.set);
+                                // emit signal
+				bottomSet(bottom_.set);
 			}
 		}
 	} else {
 		if (e->y() < height() - e->x()) {
 			if (top_.enabled) {
 				setTop(!top_.set);
-				emit topSet(top_.set);
+                                // emit signal
+				topSet(top_.set);
 			}
 		} else {
 			if (right_.enabled) {
 				setRight(!right_.set);
-				emit rightSet(right_.set);
+                                // emit signal
+				rightSet(right_.set);
 			}
 		}
 	}
 	update();
-	emit clicked();
+        // emit signal
+	clicked();
 }
 
 
-- 
2.39.5