From dba57496b425b3d01e706233c4fd273bb91fdf10 Mon Sep 17 00:00:00 2001 From: Richard Kimberly Heck Date: Fri, 28 Feb 2020 01:25:30 -0500 Subject: [PATCH] Use ranges, fix warnings --- src/CiteEnginesList.cpp | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/CiteEnginesList.cpp b/src/CiteEnginesList.cpp index f58fa72cda..53ec83e64d 100644 --- a/src/CiteEnginesList.cpp +++ b/src/CiteEnginesList.cpp @@ -102,7 +102,7 @@ string LyXCiteEngine::getDefaultBiblio(CiteEngineType const & cet) const bool LyXCiteEngine::isDefaultBiblio(string const & bf) const { string const bfs = ":" + bf; - for (string const &s: default_biblios_) + for (string const & s: default_biblios_) if (suffixIs(s, bfs) || bf == s) return true; @@ -294,25 +294,21 @@ LyXCiteEnginesList::iterator CiteEnginesList::end() LyXCiteEngine const * CiteEnginesList::operator[](string const & str) const { - LyXCiteEnginesList::const_iterator it = englist_.begin(); - for (; it != englist_.end(); ++it) - if (it->getID() == str) { - LyXCiteEngine const & eng = *it; + for (auto const & eng : englist_) + if (eng.getID() == str) { return ŋ } - return 0; + return nullptr; } LyXCiteEngine * CiteEnginesList::operator[](string const & str) { - LyXCiteEnginesList::iterator it = englist_.begin(); - for (; it != englist_.end(); ++it) - if (it->getID() == str) { - LyXCiteEngine & eng = *it; + for (auto & eng : englist_) + if (eng.getID() == str) { return ŋ } - return 0; + return nullptr; } } // namespace lyx -- 2.39.5