From d786d98c364f842ab5330307b11443afae1f5010 Mon Sep 17 00:00:00 2001 From: Jean-Marc Date: Sat, 12 Sep 2015 19:53:29 +0200 Subject: [PATCH] Remove useless test Coverity issue 23300. --- src/frontends/qt4/Menus.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/src/frontends/qt4/Menus.cpp b/src/frontends/qt4/Menus.cpp index a53b6bb8be..d0b5d91bcb 100644 --- a/src/frontends/qt4/Menus.cpp +++ b/src/frontends/qt4/Menus.cpp @@ -1122,12 +1122,10 @@ void MenuDefinition::expandFormats(MenuItem::Kind const kind, Buffer const * buf label += '|' + shortcut; if (view_update) { - if (buf) - item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command, - toqstr(label), FuncRequest(action, (*fit)->name()))); - else - item.submenu().add(MenuItem(MenuItem::Command, toqstr(label), - FuncRequest(action, (*fit)->name()))); + // note that at this point, we know that buf is not null + LATTEST(buf); + item.submenu().addWithStatusCheck(MenuItem(MenuItem::Command, + toqstr(label), FuncRequest(action, (*fit)->name()))); } else { if (buf) addWithStatusCheck(MenuItem(MenuItem::Command, toqstr(label), -- 2.39.5