From ccd46cbe8ef5e285e00ab3819da0e22cecf84da1 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Tue, 19 Mar 2013 14:48:20 -0400 Subject: [PATCH] GuiTabular: disabling is now done on textChanged() Before, it was done on editingFinished(). The new behavior is more intuitive because it is easier for the user to see how editing the box is connected with enabling/disabling the other widgets. Before, the user would not get instant feedback and would have to click away before the connection is revealed. This new behavior is less efficient, however, because checkEnabled() is called after every keystroke. --- src/frontends/qt4/GuiTabular.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/frontends/qt4/GuiTabular.cpp b/src/frontends/qt4/GuiTabular.cpp index 3e2fafccf5..312b14fd87 100644 --- a/src/frontends/qt4/GuiTabular.cpp +++ b/src/frontends/qt4/GuiTabular.cpp @@ -127,7 +127,7 @@ GuiTabular::GuiTabular(QWidget * parent) this, SLOT(checkEnabled())); connect(captionStatusCB, SIGNAL(clicked()), this, SLOT(checkEnabled())); - connect(specialAlignmentED, SIGNAL(editingFinished()), + connect(specialAlignmentED, SIGNAL(textEdited(const QString &)), this, SLOT(checkEnabled())); connect(columnWidthED, SIGNAL(textEdited(const QString &)), this, SLOT(checkEnabled())); -- 2.39.2