From c7647eb394c11e8e6a54d063b6791f04ecbf5742 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Thu, 20 Jul 2017 23:56:45 +0200 Subject: [PATCH] Make InsetInfo active agin (aka the vengeance of the neverending saga) This is a fixup to fc7fb6a5642bf. The fix in there seems perfectly correct (up to now), but for some reason, I could not refrain from making InsetInfo not active. "What could possibly go wrong?", I heard myself think. Now I know: this causes an assertion error in InsetText::updateBuffer because DocIterator::forwardPos does not enter the inset anymore. --- src/insets/InsetInfo.h | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/insets/InsetInfo.h b/src/insets/InsetInfo.h index 221d6fb09e..f7144f233f 100644 --- a/src/insets/InsetInfo.h +++ b/src/insets/InsetInfo.h @@ -100,8 +100,11 @@ public: docstring layoutName() const; /// Inset * editXY(Cursor & cur, int x, int y); - /// - bool isActive() const { return false; } + /** FIXME: we would like to do that, but then InsetText::updateBuffer breaks + * on info insets. Do we need to run this method on InsetInfo contents? + * Having a InsetInfo that hides an InsetText is really annoying, actually. + */ + ///bool isActive() const { return false; } /// bool editable() const { return false; } /// -- 2.39.2