From b02d9f107552c2cc42d8ff253783911e2bc6078e Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Mon, 22 Oct 2018 15:29:08 +0200 Subject: [PATCH] Amend 4ecbff00: it is too early for skipping the updateMacros call (cherry picked from commit 9e7832915f9763510e5820167930a38e16a8321f) --- src/BufferView.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/BufferView.cpp b/src/BufferView.cpp index d2f324d168..173c7b0a7e 100644 --- a/src/BufferView.cpp +++ b/src/BufferView.cpp @@ -476,6 +476,14 @@ void BufferView::processUpdateFlags(Update::flags flags) if (flags == Update::None) return; + /* FIXME We would like to avoid doing this here, since it is very + * expensive and is called in updateBuffer already. However, even + * inserting a plain character can invalidate the overly fragile + * tables of child documents built by updateMacros. Some work is + * needed to avoid doing that when not necessary. + */ + buffer_.updateMacros(); + // SinglePar is ignored for now (this should probably change). We // set it ourselves below, at the price of always rebreaking the // paragraph at cursor. This can be expensive for large tables. -- 2.39.5