From 92b7449e85a3b95564da4a73feebdfe3b8700fee Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Tue, 17 Sep 2019 23:22:35 +0200 Subject: [PATCH] Pass some variables as reference Spotted by cppcheck. --- src/frontends/qt/GuiBibtex.cpp | 2 +- src/frontends/qt/GuiBibtex.h | 2 +- src/frontends/qt/GuiCitation.cpp | 4 ++-- src/frontends/qt/GuiCitation.h | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/frontends/qt/GuiBibtex.cpp b/src/frontends/qt/GuiBibtex.cpp index 8414daa1cd..897224cfee 100644 --- a/src/frontends/qt/GuiBibtex.cpp +++ b/src/frontends/qt/GuiBibtex.cpp @@ -520,7 +520,7 @@ vector GuiBibtex::getFileEncodings() } -void GuiBibtex::setFileEncodings(vector const m) +void GuiBibtex::setFileEncodings(vector const & m) { for (docstring const & s: m) { docstring key; diff --git a/src/frontends/qt/GuiBibtex.h b/src/frontends/qt/GuiBibtex.h index 997902e4ab..214ff854c8 100644 --- a/src/frontends/qt/GuiBibtex.h +++ b/src/frontends/qt/GuiBibtex.h @@ -88,7 +88,7 @@ private: /// std::vector getFileEncodings(); /// - void setFileEncodings(std::vector const m); + void setFileEncodings(std::vector const & m); /// bool initialiseParams(std::string const & data); diff --git a/src/frontends/qt/GuiCitation.cpp b/src/frontends/qt/GuiCitation.cpp index e5610589c8..88a22fe2e0 100644 --- a/src/frontends/qt/GuiCitation.cpp +++ b/src/frontends/qt/GuiCitation.cpp @@ -692,7 +692,7 @@ QStringList GuiCitation::selectedKeys() } -void GuiCitation::setPreTexts(vector const m) +void GuiCitation::setPreTexts(vector const & m) { // account for multiple use of the same keys QList handled; @@ -731,7 +731,7 @@ vector GuiCitation::getPreTexts() } -void GuiCitation::setPostTexts(vector const m) +void GuiCitation::setPostTexts(vector const & m) { // account for multiple use of the same keys QList handled; diff --git a/src/frontends/qt/GuiCitation.h b/src/frontends/qt/GuiCitation.h index 428ea50a97..d3a23b587c 100644 --- a/src/frontends/qt/GuiCitation.h +++ b/src/frontends/qt/GuiCitation.h @@ -121,11 +121,11 @@ private: /// Get selected keys QStringList selectedKeys(); /// Set pre texts of qualified lists - void setPreTexts(std::vector const m); + void setPreTexts(std::vector const & m); /// Get pre texts of qualified lists std::vector getPreTexts(); /// Set post texts of qualified lists - void setPostTexts(std::vector const m); + void setPostTexts(std::vector const & m); /// Get post texts of qualified lists std::vector getPostTexts(); -- 2.39.5