From 86cccf10771cb00c71fac2becf39dd7e9a301d45 Mon Sep 17 00:00:00 2001 From: Juergen Spitzmueller Date: Wed, 19 Sep 2012 10:14:56 +0200 Subject: [PATCH] Do not update refs on new label creation (#8147) This assures that refs to existing labels are not being touched if a new label with a duplicate name is created, and the name then changed by the duplicate checker. Branch candidate. --- src/insets/InsetLabel.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/insets/InsetLabel.cpp b/src/insets/InsetLabel.cpp index 443c78e1cb..e52540e89d 100644 --- a/src/insets/InsetLabel.cpp +++ b/src/insets/InsetLabel.cpp @@ -55,9 +55,11 @@ InsetLabel::InsetLabel(Buffer * buf, InsetCommandParams const & p) void InsetLabel::initView() { - // FIXME: This seems to be used only for inset creation so - // we probably just need to call updateLabel() here. - updateLabelAndRefs(getParam("name")); + // This seems to be used only for inset creation. + // Therefore we do not update refs here, since this would + // erroneously change refs from existing duplicate labels + // (#8141). + updateLabel(getParam("name")); } -- 2.39.5