From 854fbc52621f3ecdced7cada98d72da8e8e35428 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Thu, 13 Jan 2022 17:09:42 +0100
Subject: [PATCH] Revert "Add UI for selecting backing store drawing strategy"

The need for this variable is too rare to deserve being exposed in UI.

This reverts commit a3fd3a09f1aa0b6003fc3cf033e970bb7547a983.
---
 src/frontends/qt/GuiPrefs.cpp        |  5 -----
 src/frontends/qt/ui/PrefDisplayUi.ui | 12 +-----------
 2 files changed, 1 insertion(+), 16 deletions(-)

diff --git a/src/frontends/qt/GuiPrefs.cpp b/src/frontends/qt/GuiPrefs.cpp
index 40c063890b..2b6b9cd1cb 100644
--- a/src/frontends/qt/GuiPrefs.cpp
+++ b/src/frontends/qt/GuiPrefs.cpp
@@ -1328,7 +1328,6 @@ PrefDisplay::PrefDisplay(GuiPreferences * form)
 	connect(previewSizeSB, SIGNAL(valueChanged(double)), this, SIGNAL(changed()));
 	connect(paragraphMarkerCB, SIGNAL(toggled(bool)), this, SIGNAL(changed()));
 	connect(ctAdditionsUnderlinedCB, SIGNAL(toggled(bool)), this, SIGNAL(changed()));
-	connect(ctUseBackingstoreCB, SIGNAL(toggled(bool)), this, SIGNAL(changed()));
 }
 
 
@@ -1356,8 +1355,6 @@ void PrefDisplay::applyRC(LyXRC & rc) const
 	rc.preview_scale_factor = previewSizeSB->value();
 	rc.paragraph_markers = paragraphMarkerCB->isChecked();
 	rc.ct_additions_underlined = ctAdditionsUnderlinedCB->isChecked();
-	rc.draw_strategy = ctUseBackingstoreCB->isChecked()
-		? LyXRC::DS_BACKINGSTORE : LyXRC::DS_PARTIAL;
 
 	// FIXME!! The graphics cache no longer has a changeDisplay method.
 #if 0
@@ -1387,8 +1384,6 @@ void PrefDisplay::updateRC(LyXRC const & rc)
 	previewSizeSB->setValue(rc.preview_scale_factor);
 	paragraphMarkerCB->setChecked(rc.paragraph_markers);
 	ctAdditionsUnderlinedCB->setChecked(rc.ct_additions_underlined);
-	ctUseBackingstoreCB->setChecked(rc.draw_strategy == LyXRC::DS_BACKINGSTORE);
-	ctUseBackingstoreCB->setHidden(guiApp->needsBackingStore());
 	previewSizeSB->setEnabled(
 		rc.display_graphics
 		&& rc.preview != LyXRC::PREVIEW_OFF);
diff --git a/src/frontends/qt/ui/PrefDisplayUi.ui b/src/frontends/qt/ui/PrefDisplayUi.ui
index 9c09b459b9..d8a79eb7db 100644
--- a/src/frontends/qt/ui/PrefDisplayUi.ui
+++ b/src/frontends/qt/ui/PrefDisplayUi.ui
@@ -83,7 +83,7 @@
      </property>
     </spacer>
    </item>
-   <item row="5" column="0">
+   <item row="4" column="0">
     <spacer>
      <property name="orientation">
       <enum>Qt::Vertical</enum>
@@ -158,16 +158,6 @@
      </property>
     </widget>
    </item>
-   <item row="4" column="0" colspan="2">
-    <widget class="QCheckBox" name="ctUseBackingstoreCB">
-     <property name="toolTip">
-      <string>If this is checked, an intermediate surface will be used for painting. This may be needed in some cases to have proper display, but breaks subpixel aliasing.</string>
-     </property>
-     <property name="text">
-      <string>Use &amp;backing store to display text</string>
-     </property>
-    </widget>
-   </item>
   </layout>
  </widget>
  <tabstops>
-- 
2.39.5