From 82f387dabc2b18de6a9917192f4304e92bff8bc1 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Tue, 16 Jul 2024 15:43:11 +0200 Subject: [PATCH] Fix faulty undo recording The recordUndo() call is very wrong, since we may be inserting over a selection covering several paragraphs (undo itself works at paragraph granularity). recordUndoSelection() is the right operation in this case. It is equivalent to recordUndo() when there is no selection. --- src/Text.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Text.cpp b/src/Text.cpp index 2a5ff9f0b8..d56cd10268 100644 --- a/src/Text.cpp +++ b/src/Text.cpp @@ -3600,7 +3600,7 @@ bool doInsertInset(Cursor & cur, Text * text, if (InsetCollapsible * ci = inset->asInsetCollapsible()) ci->setButtonLabel(); - cur.recordUndo(); + cur.recordUndoSelection(); if (cmd.action() == LFUN_ARGUMENT_INSERT) { bool cotextinsert = false; InsetArgument * const ia = static_cast(inset); -- 2.39.5