From 7b44280da4fc015a4a930c311cc6073cebacf738 Mon Sep 17 00:00:00 2001 From: Kornel Benko Date: Sun, 15 Dec 2019 13:38:23 +0100 Subject: [PATCH] Cmake tests: Make foreach() command robust Cmake's foreach command includes forms foreach( IN LISTS ) foreach( IN ITEMS ) foreach( RANGE ...) We get the lines to be parsed by file(STRINGS "${filepath}" lines) If in the parsed lyx-file there is a line containing only the single word 'IN', or 'RANGE', then the command foreach(_l ${lines}) can create a syntax error (at least with cmake1.16) In fact, in file pl_Additional.lyx:12913 happens to have such a beast. --- development/autotests/ExportTests.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development/autotests/ExportTests.cmake b/development/autotests/ExportTests.cmake index 85d0ecce29..febac16642 100644 --- a/development/autotests/ExportTests.cmake +++ b/development/autotests/ExportTests.cmake @@ -53,7 +53,7 @@ macro(getoutputformats filepath varname format_set) # What should we test, if default_output_format is not defined? # For now we test everything ... set(out_formats "xhtml" ${DVI_FORMATS} ${PDF_FORMATS}) - foreach(_l ${lines}) + foreach(_l IN LISTS lines) if(_l MATCHES "^\\\\default_output_format +\([^ ]+\)") set(_format ${CMAKE_MATCH_1}) if(_format STREQUAL "default") -- 2.39.2