From 72af7f340ca8ee81c7e51633afbb3f9bd435356a Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Fri, 24 Mar 2017 15:06:13 +0100 Subject: [PATCH] Pass big parameters by address Spotted by coverity. --- src/frontends/qt4/GuiCitation.cpp | 2 +- src/frontends/qt4/GuiCitation.h | 2 +- src/tex2lyx/Context.cpp | 2 +- src/tex2lyx/Context.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/frontends/qt4/GuiCitation.cpp b/src/frontends/qt4/GuiCitation.cpp index c1694bb539..2b0f05e439 100644 --- a/src/frontends/qt4/GuiCitation.cpp +++ b/src/frontends/qt4/GuiCitation.cpp @@ -258,7 +258,7 @@ void GuiCitation::updateControls(BiblioInfo const & bi) } -void GuiCitation::updateFormatting(CitationStyle currentStyle) +void GuiCitation::updateFormatting(CitationStyle const & currentStyle) { BufferParams const bp = documentBuffer().params(); bool const force = currentStyle.forceUpperCase; diff --git a/src/frontends/qt4/GuiCitation.h b/src/frontends/qt4/GuiCitation.h index 6648141fc1..5a72e02dcf 100644 --- a/src/frontends/qt4/GuiCitation.h +++ b/src/frontends/qt4/GuiCitation.h @@ -105,7 +105,7 @@ private: /// set the styles combo void updateStyles(BiblioInfo const & bi); /// set the formatting widgets - void updateFormatting(CitationStyle currentStyle); + void updateFormatting(CitationStyle const & currentStyle); /// void updateControls(BiblioInfo const & bi); /// Set the appropriate hinting text on the filter bar diff --git a/src/tex2lyx/Context.cpp b/src/tex2lyx/Context.cpp index 2f49a071f5..5a04cde46e 100644 --- a/src/tex2lyx/Context.cpp +++ b/src/tex2lyx/Context.cpp @@ -78,7 +78,7 @@ bool Context::empty = true; Context::Context(bool need_layout_, TeX2LyXDocClass const & textclass_, Layout const * layout_, Layout const * parent_layout_, - TeXFont font_) + TeXFont const & font_) : need_layout(need_layout_), need_end_layout(false), need_end_deeper(false), has_item(false), deeper_paragraph(false), diff --git a/src/tex2lyx/Context.h b/src/tex2lyx/Context.h index ad95f02b0b..b88a921f33 100644 --- a/src/tex2lyx/Context.h +++ b/src/tex2lyx/Context.h @@ -82,7 +82,7 @@ public: TeX2LyXDocClass const & textclass_, Layout const * layout_ = 0, Layout const * parent_layout_= 0, - TeXFont font_ = TeXFont()); + TeXFont const & font_ = normalfont); ~Context(); /// Output a \\begin_layout if requested -- 2.39.2