From 613cd431c99f2784694a91999ff2486f83ac834e Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Thu, 21 May 2015 08:05:36 -0400 Subject: [PATCH] Revert "toc bind: 'dialog-show' -> 'dialog-toggle' (#8388)" This reverts commit bede4d320bfff26fcbea396b516b92eb9595940c. As JMarc notes [1], if we replaced show with toggle, we would lose some functionality: There is one use that is not possible with this change (as I argued before), which is a fully keyboard-based navigation. With LyX 2.1, I can do C-M-o and navigate with cursor in the outline. I can do the same with advanced S&R. IN this sense, toggling is a step back IMO. The plan now is to find another way to close the dialog (without using toggle), such as having ESC close it or another key bind. Ticket #8388 will stay closed because 'show' and 'toggle' are too close for the cost of having two separate bindings. [1] http://www.mail-archive.com/lyx-devel@lists.lyx.org/msg187693.html --- lib/bind/cua.bind | 2 +- lib/bind/emacs.bind | 2 +- lib/bind/mac.bind | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/bind/cua.bind b/lib/bind/cua.bind index ace93f45e1..ec340ecfb4 100644 --- a/lib/bind/cua.bind +++ b/lib/bind/cua.bind @@ -120,7 +120,7 @@ Format 2 \bind "S-F7" "thesaurus-entry" \bind "M-x" "command-execute" -\bind "C-M-o" "dialog-toggle toc" +\bind "C-M-o" "dialog-show toc" \bind "F11" "ui-toggle fullscreen" diff --git a/lib/bind/emacs.bind b/lib/bind/emacs.bind index 47cb2331c0..bfd42b448c 100644 --- a/lib/bind/emacs.bind +++ b/lib/bind/emacs.bind @@ -144,7 +144,7 @@ Format 2 #bind "F10" "------" \bind "M-x" "command-execute" -\bind "C-M-o" "dialog-toggle toc" +\bind "C-M-o" "dialog-show toc" \bind "M-equal" "buffer-zoom-in" \bind "M-plus" "buffer-zoom-in" diff --git a/lib/bind/mac.bind b/lib/bind/mac.bind index d71612a610..ab748bc302 100644 --- a/lib/bind/mac.bind +++ b/lib/bind/mac.bind @@ -280,7 +280,7 @@ Format 2 \bind "F7" "dialog-show spellchecker" \bind "S-F7" "thesaurus-entry" -\bind "C-M-o" "dialog-toggle toc" +\bind "C-M-o" "dialog-show toc" # # Additional Motion group -- 2.39.5