From 60810e0ae20030cd7d34765e58ec89f0c6fb60bb Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Wed, 5 Apr 2017 11:53:17 +0200 Subject: [PATCH] Use assertions to declare things we know for sure Doing it that way makes coverity happy. --- src/frontends/qt4/GuiView.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/frontends/qt4/GuiView.cpp b/src/frontends/qt4/GuiView.cpp index be9425ba34..7bfb7cc546 100644 --- a/src/frontends/qt4/GuiView.cpp +++ b/src/frontends/qt4/GuiView.cpp @@ -1935,7 +1935,7 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag) else if (name == "latexlog") enable = FileName(doc_buffer->logName()).isReadableFile(); else if (name == "spellchecker") - enable = theSpellChecker() + enable = theSpellChecker() && !doc_buffer->isReadonly() && !doc_buffer->text().empty(); else if (name == "vclog") @@ -3854,6 +3854,8 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr) if (!data.empty()) showDialog("character", data); } else if (name == "latexlog") { + // getStatus checks that + LATTEST(doc_buffer); Buffer::LogType type; string const logfile = doc_buffer->logName(&type); switch (type) { @@ -3867,6 +3869,8 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr) data += Lexer::quoteString(logfile); showDialog("log", data); } else if (name == "vclog") { + // getStatus checks that + LATTEST(doc_buffer); string const data = "vc " + Lexer::quoteString(doc_buffer->lyxvc().getLogFile()); showDialog("log", data); -- 2.39.2