From 4bdb1ca4c26e275ef1e4bc592a95210f78839bc5 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Thu, 30 Dec 2021 11:37:12 -0500 Subject: [PATCH] Add comment regarding fsanitize + Clang issue We could not figure out the root issue, or at least not to the point where we felt changing this code considering we could not trigger any bug from a user perspective. For now, we just add a comment in the code. For more information, see our ML discussion here: https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop --- src/support/socktools.cpp | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/support/socktools.cpp b/src/support/socktools.cpp index d4aab38f5f..d014f45e94 100644 --- a/src/support/socktools.cpp +++ b/src/support/socktools.cpp @@ -111,6 +111,13 @@ int listen(FileName const & name, int queue) // bind() gives the local address 'name' for 'fd', also creating // the socket special file in the filesystem. bind() returns -1 // in case of error + // + // Using Clang and fsanitize suggests there is an issue here but we do + // not understand the code enough to change it and we are not aware of + // how to trigger a crash or other issue while using LyX, so we leave + // it as is. For ML discussion, see here: + // https://www.mail-archive.com/search?l=mid&q=20211227113249.53bf5a63%40admin1-desktop + // if ((::bind (fd, reinterpret_cast(&addr), SUN_LEN(&addr))) == -1) { LYXERR0("lyx: Could not bind address '" << name.absFileName() << "' to socket descriptor: " << strerror(errno)); -- 2.39.5