From 3682fa502a2029a7609c527054242c879a34086a Mon Sep 17 00:00:00 2001 From: Georg Baum Date: Tue, 17 May 2005 11:11:45 +0000 Subject: [PATCH] fix bug 1879 (first part, not completely fixed yet) git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@9948 a592a061-630c-0410-9148-cb99ea01b6c8 --- src/insets/ChangeLog | 7 +++++++ src/insets/insetbase.C | 9 +++------ src/insets/insetbibitem.C | 2 ++ src/insets/insetbibtex.C | 2 ++ src/insets/insetlabel.C | 2 +- src/insets/insetlatexaccent.C | 2 +- src/insets/insetlatexaccent.h | 2 +- 7 files changed, 17 insertions(+), 9 deletions(-) diff --git a/src/insets/ChangeLog b/src/insets/ChangeLog index c6f53a4368..322c9173f3 100644 --- a/src/insets/ChangeLog +++ b/src/insets/ChangeLog @@ -1,3 +1,10 @@ +2005-05-17 Georg Baum + + * insetbase.C (getStatus): allow LFUN_INSET_MODIFY unconditionally + * insetbibitem.C, insetbibtex.C, insetlabel.C (doDispatch): call + cur.noUpdate() if nothing changed + * insetlatexaccent.[Ch]: spelling fixes + 2005-05-13 Martin Vermeer * insetcollapsable.C (doDispatch): fix diff --git a/src/insets/insetbase.C b/src/insets/insetbase.C index ff11495034..dcbc08fac9 100644 --- a/src/insets/insetbase.C +++ b/src/insets/insetbase.C @@ -151,14 +151,11 @@ bool InsetBase::getStatus(LCursor &, FuncRequest const & cmd, switch (cmd.action) { case LFUN_INSET_MODIFY: - // Only allow modification of our own data. + // Allow modification of our data. // This needs to be handled in the doDispatch method of our // instantiatable children. - if (lyxCode() == translate(cmd.getArg(0))) { - flag.enabled(true); - return true; - } - return false; + flag.enabled(true); + return true; case LFUN_INSET_INSERT: // Don't allow insertion of new insets. diff --git a/src/insets/insetbibitem.C b/src/insets/insetbibitem.C index ffea9da709..c26cb17a6e 100644 --- a/src/insets/insetbibitem.C +++ b/src/insets/insetbibitem.C @@ -63,6 +63,8 @@ void InsetBibitem::doDispatch(LCursor & cur, FuncRequest & cmd) InsetCommandMailer::string2params("bibitem", cmd.argument, p); if (!p.getCmdName().empty()) setParams(p); + else + cur.noUpdate(); break; } diff --git a/src/insets/insetbibtex.C b/src/insets/insetbibtex.C index 56d4ba5831..0fde04aa1f 100644 --- a/src/insets/insetbibtex.C +++ b/src/insets/insetbibtex.C @@ -78,6 +78,8 @@ void InsetBibtex::doDispatch(LCursor & cur, FuncRequest & cmd) InsetCommandMailer::string2params("bibtex", cmd.argument, p); if (!p.getCmdName().empty()) setParams(p); + else + cur.noUpdate(); break; } diff --git a/src/insets/insetlabel.C b/src/insets/insetlabel.C index edffe585ad..ccdef93a06 100644 --- a/src/insets/insetlabel.C +++ b/src/insets/insetlabel.C @@ -100,7 +100,7 @@ void InsetLabel::doDispatch(LCursor & cur, FuncRequest & cmd) InsetCommandParams p; InsetCommandMailer::string2params("label", cmd.argument, p); if (p.getCmdName().empty()) { - cur.undispatched(); + cur.noUpdate(); break; } if (p.getContents() != params().getContents()) diff --git a/src/insets/insetlatexaccent.C b/src/insets/insetlatexaccent.C index a2a2bca1e6..f79feb29bd 100644 --- a/src/insets/insetlatexaccent.C +++ b/src/insets/insetlatexaccent.C @@ -166,7 +166,7 @@ void InsetLatexAccent::checkContents() break; default: lyxerr[Debug::KEY] << "Default" << endl; - // unknow accent (or something else) + // unknown accent (or something else) return; } diff --git a/src/insets/insetlatexaccent.h b/src/insets/insetlatexaccent.h index c5a726054f..5fd5abee75 100644 --- a/src/insets/insetlatexaccent.h +++ b/src/insets/insetlatexaccent.h @@ -66,7 +66,7 @@ public: // should this inset be handled like a normal charater bool isChar() const { return true; } - // is this equivalent to a letter? + /// is this equivalent to a letter? virtual bool isLetter() const { return candisp; } /// all the accent types -- 2.39.2