From 2896fe1bd09da000401718d45fbdf34dd1a6e68f Mon Sep 17 00:00:00 2001 From: Georg Baum Date: Thu, 26 Jun 2014 21:05:40 +0200 Subject: [PATCH] Work around MSVC warning The statement if (pos < from + lyxrc.completion_minlength) triggers a signed vs. unsigned warning. I don't know why this happens, it could be a MSVC bug, or related to LLP64 (windows) vs. LP64 (unix) programming model, or the C++ standard might be ambigous in the section defining the "usual arithmetic conversions". However, using a temporary variable is safe and works on all compilers. --- src/Paragraph.cpp | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp index f3040b5da1..dcfadc8c28 100644 --- a/src/Paragraph.cpp +++ b/src/Paragraph.cpp @@ -3852,7 +3852,16 @@ void Paragraph::collectWords() continue; pos_type from = pos; locateWord(from, pos, WHOLE_WORD); - if (pos < from + lyxrc.completion_minlength) + // Work around MSVC warning: The statement + // if (pos < from + lyxrc.completion_minlength) + // triggers a signed vs. unsigned warning. + // I don't know why this happens, it could be a MSVC bug, or + // related to LLP64 (windows) vs. LP64 (unix) programming + // model, or the C++ standard might be ambigous in the section + // defining the "usual arithmetic conversions". However, using + // a temporary variable is safe and works on all compilers. + pos_type const endpos = from + lyxrc.completion_minlength; + if (pos < endpos) continue; FontList::const_iterator cit = d->fontlist_.fontIterator(from); if (cit == d->fontlist_.end()) -- 2.39.2