From 24bb7d7e5fce0d88e0a46b0e14fe43ef0bc33540 Mon Sep 17 00:00:00 2001 From: Stephan Witt Date: Mon, 17 Feb 2020 13:25:35 +0100 Subject: [PATCH] Code cleanup: avoid repeating temp_dir method calls while local variable has a result already. --- src/LyX.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/LyX.cpp b/src/LyX.cpp index 1c8af06158..20c5e83b01 100644 --- a/src/LyX.cpp +++ b/src/LyX.cpp @@ -438,17 +438,16 @@ void LyX::prepareExit() // do any other cleanup procedures now if (package().temp_dir() != package().system_temp_dir()) { string const abs_tmpdir = package().temp_dir().absFileName(); - if (!contains(package().temp_dir().absFileName(), "lyx_tmpdir")) { + if (!contains(abs_tmpdir, "lyx_tmpdir")) { docstring const msg = bformat(_("%1$s does not appear like a LyX created temporary directory."), from_utf8(abs_tmpdir)); Alert::warning(_("Cannot remove temporary directory"), msg); } else { - LYXERR(Debug::INFO, "Deleting tmp dir " - << package().temp_dir().absFileName()); + LYXERR(Debug::INFO, "Deleting tmp dir " << abs_tmpdir); if (!package().temp_dir().destroyDirectory()) { LYXERR0(bformat(_("Unable to remove the temporary directory %1$s"), - from_utf8(package().temp_dir().absFileName()))); + from_utf8(abs_tmpdir))); } } } -- 2.39.5