From 24b71d30d56752231fb8cb8f3dc65cc21f83d614 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Thu, 3 Dec 2020 15:31:35 +0100 Subject: [PATCH] Fix disabling of widgets for (simple) Search dialog This allows to remove the calls to ButtonController::addReadonly, which are placebo since 78ade7e6. --- src/frontends/qt/GuiSearch.cpp | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/src/frontends/qt/GuiSearch.cpp b/src/frontends/qt/GuiSearch.cpp index 1d209a24d0..e582126123 100644 --- a/src/frontends/qt/GuiSearch.cpp +++ b/src/frontends/qt/GuiSearch.cpp @@ -66,9 +66,6 @@ GuiSearch::GuiSearch(GuiView & lv) bc().setPolicy(ButtonPolicy::NoRepeatedApplyReadOnlyPolicy); bc().setCancel(buttonBox->button(QDialogButtonBox::Close)); - bc().addReadOnly(replaceCO); - bc().addReadOnly(replacePB); - bc().addReadOnly(replaceallPB); findCO->setCompleter(0); replaceCO->setCompleter(0); @@ -80,6 +77,7 @@ GuiSearch::GuiSearch(GuiView & lv) void GuiSearch::showEvent(QShowEvent * e) { + findChanged(); findPB->setFocus(); findCO->lineEdit()->selectAll(); GuiDialog::showEvent(e); @@ -88,15 +86,12 @@ void GuiSearch::showEvent(QShowEvent * e) void GuiSearch::findChanged() { - if (findCO->currentText().isEmpty()) { - findPB->setEnabled(false); - replacePB->setEnabled(false); - replaceallPB->setEnabled(false); - } else { - findPB->setEnabled(true); - replacePB->setEnabled(!isBufferReadonly()); - replaceallPB->setEnabled(!isBufferReadonly()); - } + bool const replace = !findCO->currentText().isEmpty() && !isBufferReadonly(); + findPB->setEnabled(replace); + replacePB->setEnabled(replace); + replaceallPB->setEnabled(replace); + replaceLA->setEnabled(replace); + replaceCO->setEnabled(replace); } -- 2.39.2