From 0bdb0668b09f12eaa8c542f5eb7c601b41cd18b4 Mon Sep 17 00:00:00 2001
From: Stephan Witt <switt@lyx.org>
Date: Fri, 21 Feb 2020 07:57:09 +0100
Subject: [PATCH] Avoid potential leak of memory pointed to by QTreeWidgetItem
 subcatItem

---
 src/frontends/qt/GuiLyXFiles.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/frontends/qt/GuiLyXFiles.cpp b/src/frontends/qt/GuiLyXFiles.cpp
index 096a390d64..25b6fa4f67 100644
--- a/src/frontends/qt/GuiLyXFiles.cpp
+++ b/src/frontends/qt/GuiLyXFiles.cpp
@@ -445,7 +445,7 @@ void GuiLyXFiles::updateContents()
 		if (subcat.isEmpty())
 			catItem->addChild(item);
 		else {
-			QTreeWidgetItem * subcatItem = new QTreeWidgetItem();
+			QTreeWidgetItem * subcatItem = nullptr;
 			if (cats.contains(catsave)) {
 				QList<QTreeWidgetItem *> pcats = filesLW->findItems(cat, Qt::MatchExactly);
 				for (int iit = 0; iit < pcats.size(); ++iit) {
@@ -456,7 +456,9 @@ void GuiLyXFiles::updateContents()
 						}
 					}
 				}
-			} else {
+			}
+			if (!subcatItem) {
+				subcatItem = new QTreeWidgetItem();
 				subcatItem->setText(0, subcat);
 				subcatItem->setIcon(0, file_icon);
 				cats << catsave;
-- 
2.39.5