From 0867aaf5c59ee91871dca51bd1c46942ea6c3379 Mon Sep 17 00:00:00 2001 From: Jean-Marc Lasgouttes Date: Sat, 20 Jul 2024 17:12:09 +0200 Subject: [PATCH] Fixup f4364c75: remove two more Update::SinglePar instances They do not do what the author(s) of these lines thought it would do, and can create crashes. (cherry picked from commit 485f5afc21ba553fd16465231de7570b0c631298) --- src/Text.cpp | 6 ++---- status.24x | 2 ++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/Text.cpp b/src/Text.cpp index 767117a33a..1e55600a80 100644 --- a/src/Text.cpp +++ b/src/Text.cpp @@ -5266,7 +5266,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd) // Set the cursor bvcur.resetAnchor(); if (!bv->mouseSetCursor(cur, cmd.modifier() == ShiftModifier)) - cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor); + cur.screenUpdateFlags(Update::FitCursor); // FIXME: move this to mouseSetCursor? if (bvcur.wordSelection() && bvcur.inTexted()) expandWordSel(bvcur); @@ -5365,9 +5365,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd) // selectWord but bvcur is current // mouse position. cur.bv().cursor().setSelection(); - // We might have removed an empty but drawn selection - // (probably a margin) - cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor); + cur.screenUpdateFlags(Update::FitCursor); } else cur.noScreenUpdate(); // FIXME: We could try to handle drag and drop of selection here. diff --git a/status.24x b/status.24x index b30028e775..2be245c92d 100644 --- a/status.24x +++ b/status.24x @@ -55,6 +55,8 @@ What's new - Fix crash when attempting to search in selection that contains only math. +- Fix potential crashes when scrolling documents. + - Fix bug where the dialog asking for saving unapplied changes on buffer change popped up twice, or sometimes not at all (bug 12954). -- 2.39.5