From 07ca50d90590c13446eb76927d136db63c70711b Mon Sep 17 00:00:00 2001
From: Kornel Benko <kornel@lyx.org>
Date: Sat, 27 Apr 2013 21:13:32 +0200
Subject: [PATCH] Strings as parameters to LASSERT should not be translatable.
 But empty strings are even worse.

---
 src/BufferView.cpp  | 6 +++---
 src/CutAndPaste.cpp | 2 +-
 src/DocIterator.cpp | 4 ++--
 src/Paragraph.cpp   | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 695f95baf3..c32d2954ed 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -876,7 +876,7 @@ bool BufferView::scrollToCursor(DocIterator const & dit, bool recenter)
 
 	if (tm.contains(bot_pit)) {
 		ParagraphMetrics const & pm = tm.parMetrics(bot_pit);
-		LBUFERR(!pm.rows().empty(), _(""));
+		LBUFERR(!pm.rows().empty(), "");
 		// FIXME: smooth scrolling doesn't work in mathed.
 		CursorSlice const & cs = dit.innerTextSlice();
 		int offset = coordOffset(dit).y_;
@@ -2401,7 +2401,7 @@ TextMetrics const & BufferView::textMetrics(Text const * t) const
 
 TextMetrics & BufferView::textMetrics(Text const * t)
 {
-	LBUFERR(t, _(""));
+	LBUFERR(t, "");
 	TextMetricsCache::iterator tmc_it  = d->text_metrics_.find(t);
 	if (tmc_it == d->text_metrics_.end()) {
 		tmc_it = d->text_metrics_.insert(
@@ -2792,7 +2792,7 @@ Point BufferView::coordOffset(DocIterator const & dit) const
 	TextMetrics const & tm = textMetrics(sl.text());
 	ParagraphMetrics const & pm = tm.parMetrics(sl.pit());
 
-	LBUFERR(!pm.rows().empty(), _(""));
+	LBUFERR(!pm.rows().empty(), "");
 	y -= pm.rows()[0].ascent();
 #if 1
 	// FIXME: document this mess
diff --git a/src/CutAndPaste.cpp b/src/CutAndPaste.cpp
index 80f4009f5a..893c9ef393 100644
--- a/src/CutAndPaste.cpp
+++ b/src/CutAndPaste.cpp
@@ -685,7 +685,7 @@ void switchBetweenClasses(DocumentClassConstPtr oldone,
 {
 	errorlist.clear();
 
-	LBUFERR(!in.paragraphs().empty(), _(""));
+	LBUFERR(!in.paragraphs().empty(), "");
 	if (oldone == newone)
 		return;
 	
diff --git a/src/DocIterator.cpp b/src/DocIterator.cpp
index a55fc70b5a..8239000d93 100644
--- a/src/DocIterator.cpp
+++ b/src/DocIterator.cpp
@@ -210,7 +210,7 @@ FontSpan DocIterator::locateWord(word_location const loc) const
 	
 CursorSlice const & DocIterator::innerTextSlice() const
 {
-	LBUFERR(!empty(), _(""));
+	LBUFERR(!empty(), "");
 	// go up until first non-0 text is hit
 	// (innermost text is 0 in mathed)
 	for (int i = depth() - 1; i >= 0; --i)
@@ -219,7 +219,7 @@ CursorSlice const & DocIterator::innerTextSlice() const
 
 	// This case is in principe not possible. We _must_
 	// be inside a Text.
-	LBUFERR(false, _(""));
+	LBUFERR(false, "");
 	// Squash warning
 	static const CursorSlice c;
 	return c;
diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp
index 75bf9f838a..a4eb93f9d5 100644
--- a/src/Paragraph.cpp
+++ b/src/Paragraph.cpp
@@ -1044,7 +1044,7 @@ void Paragraph::Private::latexInset(BufferParams const & bparams,
 				    unsigned int & column)
 {
 	Inset * inset = owner_->getInset(i);
-	LBUFERR(inset, _(""));
+	LBUFERR(inset, "");
 
 	if (style.pass_thru) {
 		odocstringstream ods;
-- 
2.39.2