From 07be240ebe29d3dbb52ef0f3e7a1ee278c9cacf9 Mon Sep 17 00:00:00 2001 From: Scott Kostyshak Date: Thu, 21 Jul 2016 19:14:16 -0400 Subject: [PATCH] Add comment that a code chunk is unnecessary A chunk of code in an event handler seems to be unnecessary to me because the event that the situation handles never makes it this far in the event handling hierarchy. I'm not sure why this is, and thus I'm not sure if this is true in all cases (e.g. Qt version) and if it will be true in the future so I leave this code for now. --- src/frontends/qt4/GuiWorkArea.cpp | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/frontends/qt4/GuiWorkArea.cpp b/src/frontends/qt4/GuiWorkArea.cpp index 109ea7eed3..e397a80c38 100644 --- a/src/frontends/qt4/GuiWorkArea.cpp +++ b/src/frontends/qt4/GuiWorkArea.cpp @@ -1633,6 +1633,12 @@ void TabWorkArea::mouseDoubleClickEvent(QMouseEvent * event) if (event->button() != Qt::LeftButton) return; + // this code chunk is unnecessary because it seems the event only makes + // it this far if it is not on a tab. I'm not sure why this is (maybe + // it is handled and ended in DragTabBar?), and thus I'm not sure if + // this is true in all cases and if it will be true in the future so I + // leave this code for now. (skostysh, 2016-07-21) + // // return early if double click on existing tabs for (int i = 0; i < count(); ++i) if (tabBar()->tabRect(i).contains(event->pos())) -- 2.39.2