]>
git.lyx.org Git - features.git/log
Stephan Witt [Tue, 18 Feb 2020 08:03:20 +0000 (09:03 +0100)]
Add missing check for nullptr on check of language encoding of next paragraph.
Stephan Witt [Tue, 18 Feb 2020 07:59:20 +0000 (08:59 +0100)]
Add missing initialization for local variable.
The autoargs variable is random for empty macro argument lists otherwise.
Stephan Witt [Tue, 18 Feb 2020 07:55:45 +0000 (08:55 +0100)]
Remove useless assignments to a local variables never read later.
Stephan Witt [Tue, 18 Feb 2020 07:55:00 +0000 (08:55 +0100)]
Remove useless assignment to a local variables never read later.
Stephan Witt [Tue, 18 Feb 2020 07:43:22 +0000 (08:43 +0100)]
Avoid crashes in case of missing document buffer for buffer based conversions.
Richard Kimberly Heck [Mon, 17 Feb 2020 17:31:24 +0000 (12:31 -0500)]
Silence some clang warnings.
Richard Kimberly Heck [Fri, 14 Feb 2020 16:11:12 +0000 (11:11 -0500)]
Fix a strange warning in QtCreator:
/cvs/lyx/lyx-devel/src/frontends/qt/TocModel.cpp:356: warning: loop variable 'toc' has type 'const pair<std::string, shared_ptr<lyx::Toc> > &' (aka 'const pair<basic_string<char>, shared_ptr<vector<lyx::TocItem> > > &') but is initialized with type 'const std::pair<const std::__cxx11::basic_string<char>, std::shared_ptr<std::vector<lyx::TocItem, std::allocator<lyx::TocItem> > > >' resulting in a copy
/cvs/lyx/lyx-devel/src/frontends/qt/TocModel.cpp:356: use non-reference type 'pair<std::string, shared_ptr<lyx::Toc> >' (aka 'pair<basic_string<char>, shared_ptr<vector<lyx::TocItem> > >') to keep the copy or type 'const std::pair<const std::__cxx11::basic_string<char>, std::shared_ptr<std::vector<lyx::TocItem, std::allocator<lyx::TocItem> > > > &' to prevent copying
Easier just to use 'auto'.
Stephan Witt [Mon, 17 Feb 2020 13:35:03 +0000 (14:35 +0100)]
Remove unnecessary assertion after explicit buffer pointer check.
Stephan Witt [Mon, 17 Feb 2020 12:36:37 +0000 (13:36 +0100)]
Avoid potential crashes with missing document buffer in dispatch of buffer based LFUNs.
Use LASSERT with appropriate action instead of LATTEST assertions.
Debug build is unchanged and asserts, release build skips the action gracefully.
Stephan Witt [Mon, 17 Feb 2020 12:25:35 +0000 (13:25 +0100)]
Code cleanup: avoid repeating temp_dir method calls while local variable has a result already.
Juergen Spitzmueller [Mon, 17 Feb 2020 08:00:08 +0000 (09:00 +0100)]
Restore custom tmp directory
Fixes #1174
Scott Kostyshak [Sat, 15 Feb 2020 18:27:45 +0000 (13:27 -0500)]
lyxpreview_tools.py: fix a regular expression
Three backslashes are needed before a LaTeX command, not one. Before
this commit, the code gave the following error with Python >= 3.6:
re.error: bad escape \g at position 29
This error was introduced with Python 3.6, as documented [1] by the
following line of documentation:
Changed in version 3.6: Unknown escapes in pattern consisting of
'\' and an ASCII letter now are errors.
Although previous Python versions did not give an error, the regular
expression was not working as intended: for example, the "\\n" in
"\\newcommandx" would be interpreted as a new line.
[1] https://docs.python.org/3.6/library/re.html#re.sub
Pavel Sanda [Sat, 15 Feb 2020 19:55:14 +0000 (20:55 +0100)]
Unify handling in dispatchVC.
All these check could be actually dropped, because unless dispatchVC
is called directly, getstatus would already handle it.
Kornel Benko [Sat, 15 Feb 2020 11:21:32 +0000 (12:21 +0100)]
Kornel Benko [Sat, 15 Feb 2020 09:26:33 +0000 (10:26 +0100)]
Cmake tests: Correct test BATCH_outline-beamer
Kornel Benko [Sat, 15 Feb 2020 09:11:28 +0000 (10:11 +0100)]
Cmake build: Files already removed, but in 'git status' still present.
This is a try to really remove them.
Juergen Spitzmueller [Sat, 15 Feb 2020 08:26:43 +0000 (09:26 +0100)]
whitespace
Juergen Spitzmueller [Sat, 15 Feb 2020 08:26:08 +0000 (09:26 +0100)]
Fix Python detection on windows
Patch by Eugene Chornyi
Stephan Witt [Fri, 14 Feb 2020 11:11:10 +0000 (12:11 +0100)]
Avoid uninitialized position variables in case of current inset not doing the assignment
Stephan Witt [Fri, 14 Feb 2020 11:06:08 +0000 (12:06 +0100)]
Use the application id of lyx to address the running LyX instance
Stephan Witt [Thu, 13 Feb 2020 15:38:37 +0000 (16:38 +0100)]
Put the LyX window frontmost automatically on Mac on successful reverse search
Stephan Witt [Thu, 13 Feb 2020 14:24:12 +0000 (15:24 +0100)]
Avoid potential leak of memory pointed to by QStandardItem catItem
Juergen Spitzmueller [Thu, 13 Feb 2020 07:13:22 +0000 (08:13 +0100)]
Handle encoding error in layout file parsing more gracefully
Issue a warning about non-decodable files, but do not break
completely.
Addresses #11736
Richard Kimberly Heck [Thu, 13 Feb 2020 05:03:51 +0000 (00:03 -0500)]
Fix bug #11737.
We need to use the FileName methods when moving or removing a file,
so that refresh() gets called.
(cherry picked from commit
d93091389896cddcd83de83dfd4ee8a9b4e9c7f1 )
Juergen Spitzmueller [Wed, 12 Feb 2020 15:11:01 +0000 (16:11 +0100)]
Revert "Fix bug #11712."
This breaks on Linux
This reverts commit
fdf81a9bab2f4f50a3eaf22cc0e09ac454f470ed .
Richard Kimberly Heck [Wed, 12 Feb 2020 14:25:13 +0000 (09:25 -0500)]
Fix bug #11712.
Fixes some escaping issues on Windows especially
Patch from Eugene.
Stephan Witt [Wed, 12 Feb 2020 11:32:31 +0000 (12:32 +0100)]
Make cell index of tabular local for column loop.
Stephan Witt [Wed, 12 Feb 2020 11:28:18 +0000 (12:28 +0100)]
Remove another unnecessary assignment
Kornel Benko [Wed, 12 Feb 2020 11:02:36 +0000 (12:02 +0100)]
Cmake build: Amend
1c097e56 , correctly respect the patch-level
Handle also the case of creating from tar-file _and_ having 'git' installed
Enrico Forestieri [Mon, 10 Feb 2020 20:59:52 +0000 (21:59 +0100)]
Remove unnecessary assignments
Enrico Forestieri [Mon, 10 Feb 2020 20:54:07 +0000 (21:54 +0100)]
Make sure to not dereference a null pointer.
Juergen Spitzmueller [Fri, 7 Feb 2020 16:23:14 +0000 (17:23 +0100)]
Properly resize columns of child document table widget
Juergen Spitzmueller [Fri, 7 Feb 2020 15:03:56 +0000 (16:03 +0100)]
Indentation fixes
Stephan Witt [Fri, 7 Feb 2020 09:17:33 +0000 (10:17 +0100)]
Fix a crash with uninitialized buffer member of MathData
See the details here: https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg210294.html
Stephan Witt [Thu, 6 Feb 2020 21:19:15 +0000 (22:19 +0100)]
Allow externally provided list of components to skip for Qt framework builds on macOS
Stephan Witt [Thu, 6 Feb 2020 21:17:35 +0000 (22:17 +0100)]
More flexible definition of Qt libraries to include as frameworks for macOS
Stephan Witt [Thu, 6 Feb 2020 21:16:13 +0000 (22:16 +0100)]
Care for Qt library source directory rename for 5.12.x
Stephan Witt [Thu, 6 Feb 2020 21:15:08 +0000 (22:15 +0100)]
Enhanced version string extraction for 3rd party libraries.
Stephan Witt [Fri, 20 Sep 2019 17:49:56 +0000 (19:49 +0200)]
update canAutoOpenFile/autoOpenFile implementation to new MacOSX API, avoid deprecated calls
Enrico Forestieri [Thu, 6 Feb 2020 09:50:02 +0000 (10:50 +0100)]
Fix syntax error with Python 2
Python 2 wants b"..." and gives error win rb"...".
Richard Kimberly Heck [Mon, 3 Feb 2020 16:37:12 +0000 (11:37 -0500)]
Don't need to remove the file if it doesn't exist. (This would cause a five second delay in that case.)
Scott Kostyshak [Sat, 1 Feb 2020 17:32:30 +0000 (12:32 -0500)]
Remove a finishUndo() after a recordUndo()
finishUndo() is only helpful in the presence of undos of type INSERT
or DELETE.
See the following ML thread for details:
https://www.mail-archive.com/search?l=mid&q=
b721c098 -c7ee-d12f-1cdf-
067dda9aa5cf %40lyx.org
Juergen Spitzmueller [Wed, 29 Jan 2020 10:25:01 +0000 (11:25 +0100)]
Ignore geometry-related settings if the class provides geometry
Fixes #11724
Jean-Marc Lasgouttes [Mon, 27 Jan 2020 17:38:21 +0000 (18:38 +0100)]
Adopt a 'belt and braces' approach to bidi forcing
There are two techniques that I know of for forcing the direction of a
string, regardlessly of whether its contents is naturally LtR, RtL or
undecided.
1/ The unicode LTR/LTR override characters. This is supposed to be the
clean way, however, it does not seem to work with Qt 5.14 (see
#11691).
2/ The undocumented QTextLayout::setFlags method. This is used
internally and allows to pass the (undocumented) flags
Qt::TextForceRightToLeft and Qt::TextForceLeftToRight. This was
used until we had issues with Qt 5.11 (see #11284).
In order to get the best of both worlds, this patch allows to enable
those two methods separately, and actually enables both at the same
time by default!
(hopefully) Fixes bug #11691.
Juergen Spitzmueller [Mon, 27 Jan 2020 17:42:18 +0000 (18:42 +0100)]
move lyx-fedora script to attic/
Jean-Marc Lasgouttes [Mon, 27 Jan 2020 14:40:40 +0000 (15:40 +0100)]
Fix missing backspace in msgstr
Jean-Marc Lasgouttes [Mon, 27 Jan 2020 14:34:27 +0000 (15:34 +0100)]
Fix warning with --disable-nls
Juergen Spitzmueller [Mon, 27 Jan 2020 10:15:49 +0000 (11:15 +0100)]
Kornel Benko [Mon, 27 Jan 2020 09:44:14 +0000 (10:44 +0100)]
Cmake build: Remove cmake warnings about mismatched values of FindPackageHandleStandardArgs()
Richard Kimberly Heck [Mon, 27 Jan 2020 05:01:59 +0000 (00:01 -0500)]
Remove dvipost from Windows installation.
Jean-Marc Lasgouttes [Sun, 26 Jan 2020 18:46:19 +0000 (19:46 +0100)]
Fix distcheck target
1/ The most annoying part was the error in po/. It turns out that reading
and understanding the po/Makevars file was the key. A simple change of
variable ensures that "make dist" does not try to rebuild lyx.pot.
2/ The way tests in src/ are defined meant that the
dependency-tracking files were not all deleted. This should be OK now.
Kornel Benko [Fri, 17 Jan 2020 22:52:23 +0000 (23:52 +0100)]
Partially revert
43b81bec , export.cmake was not intended to change
Kornel Benko [Fri, 17 Jan 2020 14:27:17 +0000 (15:27 +0100)]
Cmake config: Respect the patch-level while creating package from tar/zip-source
Kornel Benko [Fri, 17 Jan 2020 13:59:49 +0000 (14:59 +0100)]
Cmake config: Amend
43b81bec
Typo, causing wrong package creation
Kornel Benko [Fri, 17 Jan 2020 13:25:57 +0000 (14:25 +0100)]
Cmake config: Rename some variables to match the ones used by automake
LYX_RELEASE_VERSION renamed to LYX_RELEASE_VERSION
and got the new value of
LYX_RELEASE_PATCH
from configure.ac too
Kornel Benko [Fri, 17 Jan 2020 11:37:19 +0000 (12:37 +0100)]
Update sk.po
Juergen Spitzmueller [Thu, 16 Jan 2020 09:20:16 +0000 (10:20 +0100)]
de.po
Juergen Spitzmueller [Thu, 16 Jan 2020 09:19:52 +0000 (10:19 +0100)]
Remove terminating linebreak
Jean-Marc Lasgouttes [Wed, 15 Jan 2020 14:54:47 +0000 (15:54 +0100)]
Make graĥics and external insets tighter
Now RenderGraphics adds offsets that depends on its parent inset.
These offsets are set to 0 for InsetGraphics and InsetExternal. A nice
consequence is that icons shown by Info inset stick out less on screen.
As an unrelated change, the "private:" specifier of these two insets
is moved to a more reasonable place.
Jean-Marc Lasgouttes [Wed, 15 Jan 2020 14:19:38 +0000 (15:19 +0100)]
Fixup
eeb4187a : copy-paste errors
Jean-Marc Lasgouttes [Wed, 15 Jan 2020 10:12:47 +0000 (11:12 +0100)]
Remove some spacing above InsetColapsible when possible
Jean-Marc Lasgouttes [Wed, 15 Jan 2020 10:08:38 +0000 (11:08 +0100)]
Make script inset much tighter in texted.
We use the fact that offsets can be set separately for each inset.
Jean-Marc Lasgouttes [Mon, 13 Jan 2020 21:09:06 +0000 (22:09 +0100)]
Replace the hardcoded TEXT_TO_INSET_OFFSET by tunable values
The basic value is Inset::textOffset(BufferView*), which can in theory
change with the BufferView zoom and dpi. It is hardcoded to 4 for now.
Moreover, we introduce the virtual inset methods
(top|bottom|left|right)Offset, which can be tweaked for each inset.
No change intended (for now).
Juergen Spitzmueller [Wed, 15 Jan 2020 07:40:51 +0000 (08:40 +0100)]
Improve comments
Juergen Spitzmueller [Wed, 15 Jan 2020 07:37:35 +0000 (08:37 +0100)]
Cross out ct-deleted tabular rows/columns in workarea
Pavel Sanda [Tue, 14 Jan 2020 21:12:35 +0000 (22:12 +0100)]
* lib/RELEASE-NOTES
Pavel Sanda [Tue, 14 Jan 2020 20:59:05 +0000 (21:59 +0100)]
endl needs ostream header here.
Juergen Spitzmueller [Tue, 14 Jan 2020 15:23:09 +0000 (16:23 +0100)]
Whitespace
Juergen Spitzmueller [Tue, 14 Jan 2020 15:15:49 +0000 (16:15 +0100)]
Account for bidi (swapped columns) when calculation clines
Fixes #11717
Juergen Spitzmueller [Tue, 14 Jan 2020 12:03:12 +0000 (13:03 +0100)]
Do not output deleted rows columns if show changes in output is false
Juergen Spitzmueller [Tue, 14 Jan 2020 12:02:40 +0000 (13:02 +0100)]
Fix typo in tooltip
Jean-Marc Lasgouttes [Tue, 14 Jan 2020 10:50:44 +0000 (11:50 +0100)]
Rename PainterMetrics::change_ to change
This is not a private variable.
Jean-Marc Lasgouttes [Tue, 14 Jan 2020 10:42:01 +0000 (11:42 +0100)]
Streamline RowPainter a bit
Juergen Spitzmueller [Tue, 14 Jan 2020 09:39:42 +0000 (10:39 +0100)]
Set changed status for changed column/row cells in updateIndexes()
Juergen Spitzmueller [Tue, 14 Jan 2020 08:55:16 +0000 (09:55 +0100)]
Some polishment.
Juergen Spitzmueller [Tue, 14 Jan 2020 08:28:36 +0000 (09:28 +0100)]
Record change author and time for tracked columns/rows
This now uses a real change object
Juergen Spitzmueller [Mon, 13 Jan 2020 18:02:48 +0000 (19:02 +0100)]
Color lines of added/deleted rows/columns
Jean-Marc Lasgouttes [Mon, 13 Jan 2020 16:42:31 +0000 (17:42 +0100)]
Do make changebar shorter for last row
I do not know what the intent was, but it is ugly.
Jean-Marc Lasgouttes [Mon, 13 Jan 2020 15:34:38 +0000 (16:34 +0100)]
Implement isChanged for tabular inset.
Jean-Marc Lasgouttes [Mon, 13 Jan 2020 14:23:32 +0000 (15:23 +0100)]
Only show pencil change mark when inset is collapsed
Juergen Spitzmueller [Mon, 13 Jan 2020 15:02:42 +0000 (16:02 +0100)]
Update RELEASE NOTES
Juergen Spitzmueller [Mon, 13 Jan 2020 14:20:48 +0000 (15:20 +0100)]
Add pref to keep ct markup on copy/paste
Fixes #10278, #10128
Jean-Marc Lasgouttes [Mon, 13 Jan 2020 14:08:50 +0000 (15:08 +0100)]
When iterator is in a table cell, set Changed indicator for the right inset.
Juergen Spitzmueller [Mon, 13 Jan 2020 12:03:52 +0000 (13:03 +0100)]
Prevent NULL pointer
Juergen Spitzmueller [Mon, 13 Jan 2020 08:48:56 +0000 (09:48 +0100)]
Fix backspace deletion of selected items with change tracking
Move cursor at beginning of selection after deletion. Else backspace
operation gets stuck in a loop (tries to remove the selection again
and again).
This also fixes backspace deletion of insets with confirmDeletion() == true.
Fixes #11630
Juergen Spitzmueller [Mon, 13 Jan 2020 08:21:32 +0000 (09:21 +0100)]
Whitespace
Juergen Spitzmueller [Mon, 13 Jan 2020 07:59:26 +0000 (08:59 +0100)]
Rest in peace, dvipost!
Jean-Marc Lasgouttes [Sun, 12 Jan 2020 21:18:36 +0000 (22:18 +0100)]
Fixup
bf7f4d71 : Let changeRefsIfUnique handle undo
This allows for a much lower memory consumption than a plain
recordUnfoFullBuffer.
Related to bug 6494.
Jean-Marc Lasgouttes [Sun, 12 Jan 2020 20:47:54 +0000 (21:47 +0100)]
This should not have been reverted
Jean-Marc Lasgouttes [Sun, 12 Jan 2020 19:09:41 +0000 (20:09 +0100)]
Reimplement computation of change tracking status
This is a reimplementation of
6d4e6aad that is both simpler and more
complete.
This uses the updateBuffer mechanism to implement a fully working
version of Inset::isChanged(). Now the function returns true for an
inset that contains an inset that contains a change, for example.
Moverover Buffer::areChangesPresent() is merely a proxy for
Buffer::inset().isChanged().
Jean-Marc Lasgouttes [Sun, 12 Jan 2020 17:33:01 +0000 (18:33 +0100)]
Revert "Automatically show the review toolbar if the document has tracked changes"
We will replace this with a better solution
For now, only keep
- Changes::isChanged()
- Buffer::areChangesPresent(), replaced by a dummy function
Next step will be to provide a working areChangesPresent() and to
compute Inset::isChanged in updateBuffer.
This reverts commit
6d4e6aad24edb7bcfbc49f03d2432fc9fa06954d .
Jean-Marc Lasgouttes [Sat, 11 Jan 2020 20:21:34 +0000 (21:21 +0100)]
Fixup
b321bb1a : set changebar when inset contains changes
Add Paragraph::isChanged() and InetText::isCgchanged() which indicate
the presence of a change in the relevant object.
Sets Row::needsChangebar() when adding an inset that contains changes.
Related to bug #8645.
Enrico Forestieri [Sun, 12 Jan 2020 17:35:15 +0000 (18:35 +0100)]
Fix bug #11716
Close \lyx*displayobjdeleted so that the correct macro is used for
the following deleted material.
Juergen Spitzmueller [Sat, 11 Jan 2020 17:11:26 +0000 (18:11 +0100)]
Do not track deletion of empty paragraph
Fixes #10412
Juergen Spitzmueller [Sat, 11 Jan 2020 15:51:00 +0000 (16:51 +0100)]
Output proper driver to changebar package when using dvi chain
Else the bars are not shown
Juergen Spitzmueller [Sat, 11 Jan 2020 15:17:04 +0000 (16:17 +0100)]
Implement change tracking of column/row addition/deletion
Fixes #8469
File format change
Jean-Marc Lasgouttes [Sat, 11 Jan 2020 12:39:20 +0000 (13:39 +0100)]
Avoid blinking change tracking cur for math inset.
Since there is a margin above and below the inset, there is no problem
for putting it higher.
Fixes bug #11684.
Juergen Spitzmueller [Fri, 10 Jan 2020 14:45:59 +0000 (15:45 +0100)]
de/UserGuide: minor update.
Juergen Spitzmueller [Fri, 10 Jan 2020 14:43:23 +0000 (15:43 +0100)]
de.po
Kornel Benko [Fri, 10 Jan 2020 10:15:15 +0000 (11:15 +0100)]
Update sk.po