]> git.lyx.org Git - lyx.git/log
lyx.git
9 years agoUpdate comment.
Richard Heck [Thu, 16 Oct 2014 20:50:03 +0000 (16:50 -0400)]
Update comment.

9 years agoFix bug #9296. The key may be multiple keys.
Richard Heck [Tue, 14 Oct 2014 19:41:42 +0000 (15:41 -0400)]
Fix bug #9296. The key may be multiple keys.

9 years agoErase correctly math multi-cell selection
Jean-Marc Lasgouttes [Thu, 16 Oct 2014 14:16:15 +0000 (16:16 +0200)]
Erase correctly math multi-cell selection

What a selection spans several cells in mathed, and a deletion occurs though LFUN_CHAR_DELETE_FORWARD for example, only the case of a proper grid was handled. When no such grid exists, all cells between the first and the last index are cleared now.

9 years agoFix ticket #9224: text overflows through adjacent insets
Jean-Marc Lasgouttes [Wed, 15 Oct 2014 15:34:56 +0000 (17:34 +0200)]
Fix ticket #9224: text overflows through adjacent insets

The logic of Row::shortenIfNeeded is completely changed to look at the row from the start and not the end. This leads to clearer code.

9 years agoPolishing
Juergen Spitzmueller [Thu, 16 Oct 2014 08:36:12 +0000 (10:36 +0200)]
Polishing

9 years agoSVG math icon polishing
Juergen Spitzmueller [Thu, 16 Oct 2014 08:04:37 +0000 (10:04 +0200)]
SVG math icon polishing

9 years agoNo space after inline math for text export (#9282)
Scott Kostyshak [Thu, 2 Oct 2014 05:51:24 +0000 (01:51 -0400)]
No space after inline math for text export (#9282)

This extra space was the result of the fix for #6094
(at 7e624928).

9 years agoRemove line in text export of inline math (#9282)
Scott Kostyshak [Thu, 2 Oct 2014 05:29:00 +0000 (01:29 -0400)]
Remove line in text export of inline math (#9282)

If there is only one row, a new line should not be appended. If
there is more than one row, the new line should not be appended for
the last row.

For example, if in LyX there was "as you can see in $x$ there..." a
copy/paste would lead to a newline after "x".

9 years agoComplete math SVG icons
Juergen Spitzmueller [Wed, 15 Oct 2014 21:32:00 +0000 (23:32 +0200)]
Complete math SVG icons

9 years agoIcon polishing
Juergen Spitzmueller [Wed, 15 Oct 2014 16:03:33 +0000 (18:03 +0200)]
Icon polishing

9 years agoA waggonload of SVG math icons.
Juergen Spitzmueller [Wed, 15 Oct 2014 14:17:51 +0000 (16:17 +0200)]
A waggonload of SVG math icons.

These are automatically generated via the generate_symbols_svg script. Some were modified manually afterwards.

These certainly need some manual care, and a number of icons are missing (cannot be created automatically). But it is a start.

9 years agoAdd a script to automatically generate SVG math images from a LyX template.
Juergen Spitzmueller [Wed, 15 Oct 2014 14:14:05 +0000 (16:14 +0200)]
Add a script to automatically generate SVG math images from a LyX template.

This is an adaptation of Georg's generate_symbols_images script, but it uses dvisvgm instead of dvipng.

9 years agolyx2lyx: fix convert_chunks for empty chunk layouts
Juergen Spitzmueller [Wed, 15 Oct 2014 12:07:14 +0000 (14:07 +0200)]
lyx2lyx: fix convert_chunks for empty chunk layouts

Fixes: #9298
9 years agoAdd missing license information for rsfs10.ttf.
Georg Baum [Tue, 14 Oct 2014 19:39:06 +0000 (21:39 +0200)]
Add missing license information for rsfs10.ttf.

9 years agoRewrite of change-related helpers
Alfredo Braunstein [Tue, 14 Oct 2014 07:58:40 +0000 (09:58 +0200)]
Rewrite of change-related helpers
lyxfind.cpp(findNextChange, findPreviousChange, findChange, selectChange): factor the change-selection part out of the change-finding part
Text.cpp (acceptOrRejectChanges): call only selectChange

9 years agoIPA: SVG -> SVGZ
Juergen Spitzmueller [Tue, 14 Oct 2014 12:42:06 +0000 (14:42 +0200)]
IPA: SVG -> SVGZ

9 years agoOxygen icon set is now SVG-complete
Juergen Spitzmueller [Tue, 14 Oct 2014 11:31:12 +0000 (13:31 +0200)]
Oxygen icon set is now SVG-complete

9 years agoinsets/InsetTabular.cpp (doDispatch): fix to #9291. The problem was simply that...
Alfredo Braunstein [Mon, 13 Oct 2014 08:59:50 +0000 (10:59 +0200)]
insets/InsetTabular.cpp (doDispatch):  fix to #9291. The problem was simply that the default status for the cursor in the call to *::doDispatch is "dispatched".
insets/InsetTabular.cpp (edit): do not reset the selection

9 years agoOxygen: SVG -> SVGZ
Juergen Spitzmueller [Tue, 14 Oct 2014 08:11:36 +0000 (10:11 +0200)]
Oxygen: SVG -> SVGZ

9 years agoWhitespace only
Jean-Marc [Mon, 13 Oct 2014 20:42:21 +0000 (22:42 +0200)]
Whitespace only

9 years agoStill more oxygen SVGs
Juergen Spitzmueller [Mon, 13 Oct 2014 16:26:49 +0000 (18:26 +0200)]
Still more oxygen SVGs

9 years agomore oxygen svg icons
Juergen Spitzmueller [Mon, 13 Oct 2014 12:55:00 +0000 (14:55 +0200)]
more oxygen svg icons

9 years agoRemove unneeded file
Juergen Spitzmueller [Mon, 13 Oct 2014 09:21:58 +0000 (11:21 +0200)]
Remove unneeded file

9 years agoSome more oyxgen-style svg icons
Juergen Spitzmueller [Mon, 13 Oct 2014 09:12:33 +0000 (11:12 +0200)]
Some more oyxgen-style svg icons

9 years agoit.po tweaks
Enrico Forestieri [Sun, 12 Oct 2014 17:25:48 +0000 (19:25 +0200)]
it.po tweaks

9 years agoUpdate it.po
Enrico Forestieri [Sun, 12 Oct 2014 17:03:36 +0000 (19:03 +0200)]
Update it.po

9 years agomathed/InsetMathHull.cpp (InsetMathHull::doDispatch): do not declare LFUN_FINISHED_...
Alfredo Braunstein [Sun, 12 Oct 2014 09:07:28 +0000 (11:07 +0200)]
mathed/InsetMathHull.cpp (InsetMathHull::doDispatch): do not declare LFUN_FINISHED_* lfuns as undispatched after handling them
Fixes #9289, and an unreported cousin of #3900

9 years agoText2.cpp (checkAndActivateInset, checkAndActivateInsetVisual): activate insets on...
Alfredo Braunstein [Sun, 12 Oct 2014 08:07:18 +0000 (10:07 +0200)]
Text2.cpp (checkAndActivateInset, checkAndActivateInsetVisual): activate insets on selection if the anchor is inside the inset.
insets/InsetText.cpp (InsetText::edit): do not reset the selection
Fixes #2346.

9 years agoWhitespace
Alfredo Braunstein [Sat, 11 Oct 2014 21:28:15 +0000 (23:28 +0200)]
Whitespace

9 years agoMac menu bar init has to be repeated for Qt5 after clearing the menu
Stephan Witt [Sat, 11 Oct 2014 10:38:41 +0000 (12:38 +0200)]
Mac menu bar init has to be repeated for Qt5 after clearing the menu

9 years agoAdd the git commit (if applicable) to LyX version
Kornel Benko [Sat, 11 Oct 2014 09:18:48 +0000 (11:18 +0200)]
Add the git commit (if applicable) to LyX version

Addition to cmake.
Patch mostly from Stephan Witt.

9 years agoSome more SVG icons
Juergen Spitzmueller [Fri, 10 Oct 2014 12:00:52 +0000 (14:00 +0200)]
Some more SVG icons

9 years agoLYX_GIT_COMMIT_HASH is in config.h now
Stephan Witt [Fri, 10 Oct 2014 10:27:31 +0000 (12:27 +0200)]
LYX_GIT_COMMIT_HASH is in config.h now

9 years agoAdd the git commit (if applicable) to LyX version
Jean-Marc Lasgouttes [Fri, 10 Oct 2014 10:12:17 +0000 (12:12 +0200)]
Add the git commit (if applicable) to LyX version

This only works for autotools right now, but adding that to cmake is trivial

9 years agoFix ticket #9276: Labeling cursor off by several characters
Jean-Marc Lasgouttes [Thu, 9 Oct 2014 20:09:33 +0000 (22:09 +0200)]
Fix ticket #9276: Labeling cursor off by several characters

The length of STRING row elements is not updated until finalizeLast() is called.

9 years agoFix key code
Juergen Spitzmueller [Wed, 8 Oct 2014 08:57:58 +0000 (10:57 +0200)]
Fix key code

9 years agoRemove Qt4 artifacts in comments
Stephan Witt [Wed, 1 Oct 2014 08:06:17 +0000 (10:06 +0200)]
Remove Qt4 artifacts in comments

9 years ago* sk.po
Kornel Benko [Sat, 27 Sep 2014 12:10:57 +0000 (14:10 +0200)]
* sk.po

9 years agoInstall.cmake: add missing subfolder "\templates\springer" and remove an unnecessary...
Uwe Stöhr [Wed, 24 Sep 2014 22:25:02 +0000 (00:25 +0200)]
Install.cmake: add missing subfolder "\templates\springer" and remove an unnecessary folder

we don't need to install the attic template files. These are for years now in attic and LyX 2.2. should make a cut somehow for very old attic material

9 years agoFix some convert_TeX_brace_to_Argument glitches
Juergen Spitzmueller [Tue, 16 Sep 2014 15:42:19 +0000 (17:42 +0200)]
Fix some convert_TeX_brace_to_Argument glitches

Fixes: #9273
9 years agoLaTeXFeatures.cpp: fix bug #9266
Uwe Stöhr [Wed, 10 Sep 2014 20:01:29 +0000 (22:01 +0200)]
LaTeXFeatures.cpp: fix bug #9266

mhchem loads amsmath and needs therefore be loaded after it but before packages that redefine commands of amsmath. We already take care of esint but not of wasysym

9 years agoCmake export tests: Use unique file names for exported files
Kornel Benko [Tue, 9 Sep 2014 17:02:20 +0000 (19:02 +0200)]
Cmake export tests: Use unique file names for exported files

This should prevent possible errors for tests running in parallel.
We now also check for created export file.
  complainer/feature requester: Scott Kostyshak

9 years agoUpdate file formats of test files
Kornel Benko [Thu, 4 Sep 2014 10:14:47 +0000 (12:14 +0200)]
Update file formats of test files

9 years agoCmake tex2lyx tests: Take care of initialized userdir
Kornel Benko [Wed, 3 Sep 2014 19:21:05 +0000 (21:21 +0200)]
Cmake tex2lyx tests: Take care of initialized userdir

If we are testing tex2lyx the first time, then the userdir
is empty. We call now configure.py to initalize in case it is needed.
The algorithm to detect if reconfigure is needed mimics the lyx behaviour.

9 years agoCmake tests: Set also correct sequence of tests again.
Kornel Benko [Wed, 3 Sep 2014 10:35:40 +0000 (12:35 +0200)]
Cmake tests: Set also correct sequence of tests again.

9 years agoCmake tests: Disable keytests if missing needed input files
Kornel Benko [Wed, 3 Sep 2014 10:25:28 +0000 (12:25 +0200)]
Cmake tests: Disable keytests if missing needed input files

The files first-time-in.txt and hello-world-in.txt are used
as first tests to initialize the test environment for the other
keytests.

9 years agoFix possibly uninitialized use of variables
Stephan Witt [Tue, 2 Sep 2014 22:07:26 +0000 (00:07 +0200)]
Fix possibly uninitialized use of variables

9 years agoAdded more missing files to autoconf's dist
Kornel Benko [Tue, 2 Sep 2014 13:02:55 +0000 (15:02 +0200)]
Added more missing files to autoconf's dist

9 years ago Fix bug with wrong baseline calculation in last paragraph (2nd attempt)
Juergen Spitzmueller [Mon, 1 Sep 2014 07:14:26 +0000 (09:14 +0200)]
 Fix bug with wrong baseline calculation in last paragraph (2nd attempt)

This time, we consider the cases where a \par is not wanted (single-par insets, tabular cells).

Fixes: #9231
9 years agode,.po
Juergen Spitzmueller [Sun, 31 Aug 2014 14:03:01 +0000 (16:03 +0200)]
de,.po

9 years agoAdd some missing files to autoconf's dist
Kornel Benko [Sun, 31 Aug 2014 13:23:28 +0000 (15:23 +0200)]
Add some missing files to autoconf's dist

9 years agoAdd cmake files to autoconf's dist
Kornel Benko [Sun, 31 Aug 2014 13:21:20 +0000 (15:21 +0200)]
Add cmake files to autoconf's dist

9 years agoTypos.
Juergen Spitzmueller [Sun, 31 Aug 2014 13:15:11 +0000 (15:15 +0200)]
Typos.

9 years agoAdd support for todonotes package
Juergen Spitzmueller [Sun, 31 Aug 2014 12:49:30 +0000 (14:49 +0200)]
Add support for todonotes package

Fixes: #7546
9 years agoAdd support for the fixme package.
Juergen Spitzmueller [Sun, 31 Aug 2014 12:38:28 +0000 (14:38 +0200)]
Add support for the fixme package.

Fixes: #8868
9 years agoAdd support for beamer lemma environment.
Juergen Spitzmueller [Sun, 31 Aug 2014 10:30:14 +0000 (12:30 +0200)]
Add support for beamer lemma environment.

File fomat change.

9 years agoFix lyx2lyx issue with complex beamer arguments.
Juergen Spitzmueller [Sat, 30 Aug 2014 11:24:29 +0000 (13:24 +0200)]
Fix lyx2lyx issue with complex beamer arguments.

Fixes: #9254
9 years agoFix export of xfig external insets (bug #9244).
Enrico Forestieri [Fri, 29 Aug 2014 08:13:25 +0000 (10:13 +0200)]
Fix export of xfig external insets (bug #9244).

The check for a latex format is very fragile. Both libmagic and our
guessing from contents cannot distinguish the pstex and pdftex formats
used by the xfig external inset. Moreover, it may also happen that
lyx files are mistaken as latex ones. Thus, when the guessed format
is latex, the only solution is to give precedence to the format
determined by the file extension.

9 years agoRevert "Fix bug with wrong baseline calculation in last paragraph"
Juergen Spitzmueller [Thu, 28 Aug 2014 06:37:39 +0000 (08:37 +0200)]
Revert "Fix bug with wrong baseline calculation in last paragraph"

This reverts commit b555f31a34112761f360ec69c996abcb3272e135.

9 years agopass git commit hash within CPPFLAGS to add it to version info
Stephan Witt [Thu, 28 Aug 2014 06:30:45 +0000 (08:30 +0200)]
pass git commit hash within CPPFLAGS to add it to version info

9 years agoprint callstack on assert
Peter Kümmel [Wed, 27 Aug 2014 17:40:40 +0000 (19:40 +0200)]
print callstack on assert

9 years agoMore careful NSAutoreleasePool management
Stephan Witt [Tue, 26 Aug 2014 06:22:12 +0000 (08:22 +0200)]
More careful NSAutoreleasePool management

9 years agoCorrect LyXUtilitiesDir default assignment location (thanks Patrick)
Stephan Witt [Tue, 26 Aug 2014 05:37:59 +0000 (07:37 +0200)]
Correct LyXUtilitiesDir default assignment location (thanks Patrick)

9 years ago#9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and...
Stephan Witt [Mon, 25 Aug 2014 18:08:59 +0000 (20:08 +0200)]
#9245 replace Q_WS_MACX with Q_OS_MAC - the Q_OS_MAC macro is usable with Qt4 and Qt5.

9 years agoReplace Q_WS_WIN with appropriate guards to account for Qt5.
Enrico Forestieri [Mon, 25 Aug 2014 17:27:45 +0000 (19:27 +0200)]
Replace Q_WS_WIN with appropriate guards to account for Qt5.

This commit replaces almost all occurrences of Q_WS_WIN to comply
with Qt5. The remaining occurrences should *not* be replaced,
because the guarded code won't compile on Qt5.

9 years agoFix the -geometry command line argument for Windows.
Enrico Forestieri [Mon, 25 Aug 2014 16:35:15 +0000 (18:35 +0200)]
Fix the -geometry command line argument for Windows.

The command line argument -geometry WIDTHxHEIGHT±XOFF±YOFF
specifies a preferred size and location for the main window.
Currently, this is semi-broken on Windows. Indeed, only
specifying WIDTH and HEIGHT places the main window such that
the left and top borders are invisible such that the window cannot
be moved. Moreover, the XOFF and YOFF parts (when present) are
used to specify the distance of the window from the left and top
or right and bottom edges of the screen, when using '+' or '-',
respectively. However, -geometry 800x600-20-20, instead of placing
the window such that its bottom and right edges are at a distance
of 20 pixels from the corresponding screen edges, places the
window such that its left and top borders are out of the screen.
This is corrected by this commit, which also addresses the fact
that Qt5 does not define Q_WS_WIN anymore.

9 years agoAdd a debugging message.
Richard Heck [Mon, 25 Aug 2014 15:14:27 +0000 (11:14 -0400)]
Add a debugging message.

9 years agokeytest.py: Allow for LyX window to appear without timeout
Kornel Benko [Mon, 25 Aug 2014 12:28:18 +0000 (14:28 +0200)]
keytest.py: Allow for LyX window to appear without timeout

Timeout for lyx-process to appear may be significantly smaler.
5 sec. looks sufficient, while lyx-window may take some time
due to configure.py.

9 years ago* sk.po
Kornel Benko [Mon, 25 Aug 2014 11:52:14 +0000 (13:52 +0200)]
* sk.po

9 years agokeytests: add a timeout for LyX process to start
Kornel Benko [Mon, 25 Aug 2014 11:49:12 +0000 (13:49 +0200)]
keytests: add a timeout for LyX process to start

If the LyX window does not appear after a certain (conservative)
time, the keytest now fails. One reason that caused the LyX window
to never show up was when DISPLAY was not set. This particular case
has been fixed in <commit1hash>. This commit is meant for the more general
scenario.
(Collaboration with Scott Kostyshak)

9 years agoFix stalling of keytests when invalid DISPLAY
Kornel Benko [Mon, 25 Aug 2014 11:45:32 +0000 (13:45 +0200)]
Fix stalling of keytests when invalid DISPLAY

Before, the keytests would run infinitely if the
tests were run, e.g. through SSH without X forwarding.
To reproduce that problem, run

  DISPLAY='' ctest -R hello

This commit causes the test to correctly fail in such situations.
(Collaboration with Scott Kostyshak)

9 years agoFORMAT: document latest file format change
Uwe Stöhr [Sun, 24 Aug 2014 23:28:12 +0000 (01:28 +0200)]
FORMAT: document latest file format change

9 years agosupport for the LaTeX commands \x***arrow
Uwe Stöhr [Sun, 24 Aug 2014 22:44:09 +0000 (00:44 +0200)]
support for the LaTeX commands \x***arrow

- this patch supports the \x***arrow commands provided by the mathtool package
- fileformat change

9 years agoQt5MacExtras is required on a Mac; report the version of Qt5
Stephan Witt [Sun, 24 Aug 2014 19:59:12 +0000 (21:59 +0200)]
Qt5MacExtras is required on a Mac; report the version of Qt5

9 years agoReintroduce some class definitions.
Stephan Witt [Sun, 24 Aug 2014 19:40:40 +0000 (21:40 +0200)]
Reintroduce some class definitions.

9 years agoRemove superfluous class definitions.
Stephan Witt [Sun, 24 Aug 2014 18:32:01 +0000 (20:32 +0200)]
Remove superfluous class definitions.

9 years agoRemove special GlobalMenuBar class. As Patrick De Visschere pointed out it is not...
Stephan Witt [Sun, 24 Aug 2014 18:29:52 +0000 (20:29 +0200)]
Remove special GlobalMenuBar class. As Patrick De Visschere pointed out it is not needed. The shortcut handling of Qt does it internally now what GlobalMenuBar was made for.

9 years agoFSPathMakeRef is deprecated: use LSOpenFromURLSpec instead of LSOpenFromRefSpec
Stephan Witt [Sun, 24 Aug 2014 10:49:34 +0000 (12:49 +0200)]
FSPathMakeRef is deprecated: use LSOpenFromURLSpec instead of LSOpenFromRefSpec

9 years agoCorrect the method signature of MenuTranslator::translate for Qt5
Stephan Witt [Sat, 23 Aug 2014 14:01:03 +0000 (16:01 +0200)]
Correct the method signature of MenuTranslator::translate for Qt5

9 years agoCmake build: Use find_package(Qt5X11Extras ...) independent of OS
Kornel Benko [Sat, 23 Aug 2014 09:36:24 +0000 (11:36 +0200)]
Cmake build: Use find_package(Qt5X11Extras ...) independent of OS

We need to know, if Qt5 is built over X11 in order to test with
xvkbd, which manipulates XEvents.
Qt5X11Extras is independent of underlying OS.

9 years agoInsert menu accelerator 'x' now goes to box menu
Scott Kostyshak [Wed, 6 Aug 2014 07:36:31 +0000 (03:36 -0400)]
Insert menu accelerator 'x' now goes to box menu

Before, 'x' would go to "TeX Code" but that already has a shortcut
in the common bind files.

Reported and discussed on lyx-devel at:
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg185082.html

9 years agoMake BiblioInfo::collectCitedEntries private (since it can be),
Richard Heck [Fri, 22 Aug 2014 15:17:36 +0000 (11:17 -0400)]
Make BiblioInfo::collectCitedEntries private (since it can be),
and fix a comment referring to it.

9 years agoUse QProxyStyle instead of QMacStyle. QMacStyle is not available anymore with At5...
Stephan Witt [Fri, 22 Aug 2014 09:17:34 +0000 (11:17 +0200)]
Use QProxyStyle instead of QMacStyle. QMacStyle is not available anymore with At5 and QProxyStyle is present since Qt4.6 as an alternative

9 years agoAdd check for the link for libmagic.dylib.
Stephan Witt [Fri, 22 Aug 2014 08:05:40 +0000 (10:05 +0200)]
Add check for the link for libmagic.dylib.

9 years agoRemove unused code.
Stephan Witt [Fri, 22 Aug 2014 08:04:53 +0000 (10:04 +0200)]
Remove unused code.

9 years agoImproved QtConfigureOptions (for Qt5.3).
Stephan Witt [Fri, 22 Aug 2014 07:58:32 +0000 (09:58 +0200)]
Improved QtConfigureOptions (for Qt5.3).

9 years agoRemove gettext framework support. Add libmagic framework support.
Stephan Witt [Fri, 22 Aug 2014 07:52:39 +0000 (09:52 +0200)]
Remove gettext framework support. Add libmagic framework support.

9 years agoAdd command line option to define the location of the self made utilities
Stephan Witt [Fri, 22 Aug 2014 06:39:14 +0000 (08:39 +0200)]
Add command line option to define the location of the self made utilities

9 years agoAdd QtMacExtras detection for Qt5 support
Stephan Witt [Thu, 21 Aug 2014 16:22:43 +0000 (18:22 +0200)]
Add QtMacExtras detection for Qt5 support

9 years agoAdd policy definitions to avoid warnings from cmake 3.0.0
Stephan Witt [Thu, 21 Aug 2014 16:03:37 +0000 (18:03 +0200)]
Add policy definitions to avoid warnings from cmake 3.0.0

9 years agofix coding style
Peter Kümmel [Sat, 16 Aug 2014 05:26:21 +0000 (07:26 +0200)]
fix coding style

(should have read ml first)

9 years agoignore Qt Creator's cmake file
Peter Kümmel [Sat, 16 Aug 2014 04:59:40 +0000 (06:59 +0200)]
ignore Qt Creator's cmake file

9 years agobuild test_Layout test
Peter Kümmel [Sat, 16 Aug 2014 04:55:32 +0000 (06:55 +0200)]
build test_Layout test

9 years ago* sk.po
Kornel Benko [Fri, 15 Aug 2014 15:11:12 +0000 (17:11 +0200)]
* sk.po

9 years agoPossible fix for the mystery crash, which is bug #9049.
Richard Heck [Thu, 7 Aug 2014 19:00:35 +0000 (15:00 -0400)]
Possible fix for the mystery crash, which is bug #9049.

Investigation of bug #9236 showed that crash to be due to a Paragraph's
holding a dangling pointer to an old and deleted Layout after the
DocumentClass was reset. Since the backtraces look almost identical, it
seems likely that we have the same problem here.

Since this crash seems almost always to involve tables, I looked at the
code in switchBetweenClasses() and found that the Paragraphs that belong
to "hidden" table cells are not seen by the initial recursion using a
ParIterator: It skips right over them. This was confirmed by test code
suggested by Enrico, with results reported in Trac.

The present patch attempts to deal with this problem in the second
recursion, over Insets. When we see an InsetTabular, we call a new
routine that recurses through the cells, looking for hidden ones. If it
finds a hidden one, it then resets the Layout for the cell's Paragraphs
(there should be only one, but we do not make any assumptions) to the
PlainLayout that belongs to the new DocumentClass. This is good enough,
since such cells never have content.

There is extensive discussion of the patch here:
  https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg185095.html
Additional testing by Enrico and me confirmed the existence of the
dangling pointer.

9 years agoUpdate comments.
Richard Heck [Tue, 12 Aug 2014 19:44:15 +0000 (15:44 -0400)]
Update comments.

9 years agoLittle bit of cleanup.
Richard Heck [Tue, 12 Aug 2014 17:13:47 +0000 (13:13 -0400)]
Little bit of cleanup.

9 years agoMake the constructor of the singleton class LayoutFileList private.
Richard Heck [Tue, 12 Aug 2014 16:49:17 +0000 (12:49 -0400)]
Make the constructor of the singleton class LayoutFileList private.

9 years agoUse a const ref here. Guess it was a thinko when I did it.
Richard Heck [Tue, 12 Aug 2014 16:32:01 +0000 (12:32 -0400)]
Use a const ref here. Guess it was a thinko when I did it.

9 years agoCmake build: Move use of QT5 libraries to the end of linker command line.
Kornel Benko [Mon, 11 Aug 2014 19:30:21 +0000 (21:30 +0200)]
Cmake build: Move use of QT5 libraries to the end of linker command line.

To prevent the linker error if they were before some object file referencing
some symbol there.