]> git.lyx.org Git - lyx.git/log
lyx.git
18 months agoUpdate sk.po
Kornel Benko [Sat, 3 Dec 2022 15:35:09 +0000 (16:35 +0100)]
Update sk.po

18 months agode.po
Juergen Spitzmueller [Sat, 3 Dec 2022 14:26:42 +0000 (15:26 +0100)]
de.po

18 months agoSome string fixes in compare UI
Juergen Spitzmueller [Sat, 3 Dec 2022 14:21:15 +0000 (15:21 +0100)]
Some string fixes in compare UI

18 months agoFix shortcut conflicts
Juergen Spitzmueller [Sat, 3 Dec 2022 12:29:25 +0000 (13:29 +0100)]
Fix shortcut conflicts

18 months agoUpdate uk.po from Yuri Chornoivan (&remerge)
Pavel Sanda [Sat, 3 Dec 2022 11:47:23 +0000 (12:47 +0100)]
Update uk.po from Yuri Chornoivan (&remerge)

18 months agoUpdate tex2lyx tests
Juergen Spitzmueller [Sat, 3 Dec 2022 07:42:33 +0000 (08:42 +0100)]
Update tex2lyx tests

This was forgotten at the latest file format change

18 months agoComment
Scott Kostyshak [Sat, 3 Dec 2022 00:34:36 +0000 (19:34 -0500)]
Comment

18 months agoLine width
Scott Kostyshak [Sat, 3 Dec 2022 00:29:04 +0000 (19:29 -0500)]
Line width

18 months agoComment
Scott Kostyshak [Sat, 3 Dec 2022 00:28:10 +0000 (19:28 -0500)]
Comment

Jürgen confirms that the behavior in #8493 is present with Qt6.

18 months agoCheck encodability of math user macro names (#11855)
Juergen Spitzmueller [Fri, 2 Dec 2022 10:23:32 +0000 (11:23 +0100)]
Check encodability of math user macro names (#11855)

18 months agoRevert e500dc19c15334
Juergen Spitzmueller [Fri, 2 Dec 2022 10:21:15 +0000 (11:21 +0100)]
Revert e500dc19c15334

More general fix is upcoming.

18 months agoIOP class no longer in CTAN; remove IOP section
John R Hudson [Wed, 30 Nov 2022 09:45:48 +0000 (09:45 +0000)]
IOP class no longer in CTAN; remove IOP section

18 months agoIJMPC/D no longer in CTAN; remove section on IJMPC/D
John R Hudson [Tue, 29 Nov 2022 21:06:25 +0000 (21:06 +0000)]
IJMPC/D no longer in CTAN; remove section on IJMPC/D

18 months agoDo not crash with uncodable character in math preview snippert (part of #11855)
Juergen Spitzmueller [Thu, 1 Dec 2022 15:01:38 +0000 (16:01 +0100)]
Do not crash with uncodable character in math preview snippert (part of #11855)

18 months agoAA not longer exists in CTAN; deleting section on AA.
John R Hudson [Tue, 29 Nov 2022 17:30:38 +0000 (17:30 +0000)]
AA not longer exists in CTAN; deleting section on AA.

18 months agoUpdate sk.po
Kornel Benko [Tue, 29 Nov 2022 08:12:54 +0000 (09:12 +0100)]
Update sk.po

18 months ago Update fr.po (graphiqe semantics)
jpc [Mon, 28 Nov 2022 16:20:53 +0000 (17:20 +0100)]
        Update fr.po (graphiqe semantics)

18 months agoMerge branch 'killqt4'
Jean-Marc Lasgouttes [Mon, 28 Nov 2022 14:19:41 +0000 (15:19 +0100)]
Merge branch 'killqt4'

Remove all trace of Qt4 support. The different elements have been
considered carefully before removal.

The only changes that need to be done concern Windows and macOS
compilation instruction and will need to be taken care of by the
respective maintainers before prerelease.

The file TODO.killqt4 lists what remains to be done.

18 months agoFinal (?) update to the TODO
Jean-Marc Lasgouttes [Mon, 28 Nov 2022 14:16:19 +0000 (15:16 +0100)]
Final (?) update to the TODO

Reorganize things to do in to point to the macOS and Windows
maintainers. These are things tht need to be done before release.

Update autotest/keytest.py, and ignore the other development/ stuff,
which is is obsolete.

18 months agoremove support for Qt4 in server_monitor
Jean-Marc Lasgouttes [Mon, 28 Nov 2022 13:49:13 +0000 (14:49 +0100)]
remove support for Qt4 in server_monitor

Update TODO.killqt4

18 months agoremerge ru.po
Pavel Sanda [Mon, 28 Nov 2022 12:00:27 +0000 (13:00 +0100)]
remerge ru.po

18 months ago Update doc (semantics of "graphique" in French)
jpc [Mon, 28 Nov 2022 10:37:41 +0000 (11:37 +0100)]
          Update doc (semantics of "graphique" in French)

18 months ago* RELEASE-NOTES
Pavel Sanda [Mon, 28 Nov 2022 10:29:22 +0000 (11:29 +0100)]
* RELEASE-NOTES

18 months ago* RELEASE-NOTES
Pavel Sanda [Mon, 28 Nov 2022 10:09:37 +0000 (11:09 +0100)]
* RELEASE-NOTES

18 months agoAdd "semantic linefeeds" after punctuation marks.
Yuriy Skalko [Sun, 27 Nov 2022 16:30:26 +0000 (18:30 +0200)]
Add "semantic linefeeds" after punctuation marks.

We already had such breaks for dot.

File format change.

18 months agoSupport macros from hepnames and hepparticles packages
Jean-Marc Lasgouttes [Fri, 26 Nov 2021 17:22:17 +0000 (18:22 +0100)]
Support macros from hepnames and hepparticles packages

This macros are important for particle physicists. Note that the
package hepparticles as distributed in recent texlive does not work
(see #11804) and need to be patched. This is however not something we
can do, and any physicist wanting to use this will have patched his
own version I guess.

I contacted Andy Buckley, the author of the package, who answered that
he is aware of the issue but does not have time right now to fix it.
The workaround is straightforward: on line 176 of hepparticles.sty,
replace "\updefault" by "n".

Two parts:
- add *lots* of definitions to lib/symbols
- add hepparticles and hepnames as simple features in LaTeXFeatures.

The definitions are courtesy of @renyhp, and extracted from the
aforemented packages:
https://www.ctan.org/pkg/hepparticles
https://www.ctan.org/pkg/hepnames

Fixes bug #11804.

18 months agoUpdate release notes.
Richard Kimberly Heck [Sun, 27 Nov 2022 18:29:52 +0000 (13:29 -0500)]
Update release notes.

18 months agoMinor update to release notes.
Richard Kimberly Heck [Sun, 27 Nov 2022 18:28:31 +0000 (13:28 -0500)]
Minor update to release notes.

18 months agoFix bug #11917. Patch from Daniel.
Richard Kimberly Heck [Sun, 27 Nov 2022 18:24:13 +0000 (13:24 -0500)]
Fix bug #11917. Patch from Daniel.

18 months agoFix bug #11781. Patch from Daniel.
Richard Kimberly Heck [Sun, 27 Nov 2022 18:16:00 +0000 (13:16 -0500)]
Fix bug #11781. Patch from Daniel.

18 months agoActivate another tab group (aka split view)
Daniel Ramoeller [Sun, 30 Jan 2022 04:42:45 +0000 (05:42 +0100)]
Activate another tab group (aka split view)

Bind the new functions tab-group-next/previous to F6/S-F6 in CUA bindings.

Fix for #12115.

18 months agoInclude he/cua.bind (#12052)
Juergen Spitzmueller [Fri, 25 Nov 2022 10:30:20 +0000 (11:30 +0100)]
Include he/cua.bind (#12052)

To allow for its use, we add support to include a bind file from the
top dir (i.e., non-localized) via \bind_file ../<file>

18 months ago Update fr.po
jpc [Sat, 26 Nov 2022 17:55:13 +0000 (18:55 +0100)]
       Update fr.po

18 months agoEffectively disable the "Stop command?" dialog
Scott Kostyshak [Fri, 25 Nov 2022 15:06:59 +0000 (10:06 -0500)]
Effectively disable the "Stop command?" dialog

We now allow the user to cancel the background process at any point
(via the red "x" in the status bar or Document > Cancel Export), so
we do not need to poll the user with the dialog.

The patch works by setting timeout to "-1" which is treated as a
special value to disable the poll.

Fix (by obviation) #12531 and #9953, which were about the dialog.

18 months agoChange os::timeout from minutes to milliseconds
Scott Kostyshak [Fri, 25 Nov 2022 14:51:30 +0000 (09:51 -0500)]
Change os::timeout from minutes to milliseconds

We can now specify the special value of "-1" milliseconds which is
interpreted as disabling the timeout.

No change of functionality intended.

18 months agoStephan has checked that caching is still needed on macOS
Jean-Marc Lasgouttes [Fri, 25 Nov 2022 11:44:56 +0000 (12:44 +0100)]
Stephan has checked that caching is still needed on macOS

Basically removing the cache makes getTextLayout 17x more expensive on
a simple test of scrolling through the Tutorial.

18 months agoUpdate sk.po
Kornel Benko [Fri, 25 Nov 2022 11:15:33 +0000 (12:15 +0100)]
Update sk.po

18 months agoCorrect documentation of localized bind files
Juergen Spitzmueller [Fri, 25 Nov 2022 10:26:29 +0000 (11:26 +0100)]
Correct documentation of localized bind files

These are in subfolders nowadays (no more lang_ prefix)

18 months agode.po
Juergen Spitzmueller [Fri, 25 Nov 2022 09:31:23 +0000 (10:31 +0100)]
de.po

18 months agoremove Qt4 path name reference
Stephan Witt [Fri, 25 Nov 2022 09:10:14 +0000 (10:10 +0100)]
remove Qt4 path name reference

18 months ago"Cancel Background Process" -> "Cancel Export"
Scott Kostyshak [Fri, 25 Nov 2022 02:15:50 +0000 (21:15 -0500)]
"Cancel Background Process" -> "Cancel Export"

"Cancel Export" sounds more user friendly.

Discussed briefly on ML here:

  https://www.mail-archive.com/search?l=mid&q=20221122200127.th3qwgpimqndksmd%40gary

18 months agoRELEASE-NOTES: document clicking on red x
Scott Kostyshak [Fri, 25 Nov 2022 02:13:39 +0000 (21:13 -0500)]
RELEASE-NOTES: document clicking on red x

New functionality introduced at 869247b6.

18 months agoRm dup "Float" in "Insert>Float>Figure Wrap Float"
Scott Kostyshak [Thu, 24 Nov 2022 16:14:31 +0000 (11:14 -0500)]
Rm dup "Float" in "Insert>Float>Figure Wrap Float"

Change menu options "Figure Wrap Float" to "Wrapped Figure"
and "Table Wrap Float" to "Wrapped Table".

18 months agoImprove replacement for qDegreesToRadians
Jean-Marc Lasgouttes [Thu, 24 Nov 2022 23:06:06 +0000 (00:06 +0100)]
Improve replacement for qDegreesToRadians

This is for Qt 5.0.X compatibility.

18 months agoUpdate sk.po
Kornel Benko [Thu, 24 Nov 2022 11:47:45 +0000 (12:47 +0100)]
Update sk.po

18 months agomakefile - forgotten file
Pavel Sanda [Thu, 24 Nov 2022 01:17:26 +0000 (02:17 +0100)]
makefile - forgotten file

18 months ago* postats.py
Pavel Sanda [Wed, 23 Nov 2022 22:29:11 +0000 (23:29 +0100)]
* postats.py

18 months agoCentralize cancelation of export
Scott Kostyshak [Tue, 22 Nov 2022 19:46:00 +0000 (14:46 -0500)]
Centralize cancelation of export

An export can be canceled by clicking on the status bar icon or by
executing export-cancel (e.g., via Document > Cancel Background
Process).

The centralized code kills the script and updates the status bar
icons.

No change in functionality intended.

Related commits: 70a71a82 and 01abab9a.

18 months agoAfter export-cancel, hide busy and cancel buttons
Scott Kostyshak [Tue, 22 Nov 2022 19:28:45 +0000 (14:28 -0500)]
After export-cancel, hide busy and cancel buttons

This is consistent with 70a71a82 (which is about the code path
through clicking on the 'x' status bar icon).

In the next commit I'll make a function to centralize this sequence
of killing a script and emitting the scriptKilled() signal.

18 months agoAfter confirm cancel, hide busy and cancel buttons
Scott Kostyshak [Tue, 22 Nov 2022 19:24:11 +0000 (14:24 -0500)]
After confirm cancel, hide busy and cancel buttons

18 months agoAmend(4) 580dea63: get rid of Qt4 code also in cmake build
Kornel Benko [Tue, 22 Nov 2022 17:48:46 +0000 (18:48 +0100)]
Amend(4) 580dea63: get rid of Qt4 code also in cmake build

18 months agoCleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 09:18:43 +0000 (10:18 +0100)]
Cleanup mathes/BUGS (#3493)

This one is now also part of #12603.

18 months agoCleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 09:16:29 +0000 (10:16 +0100)]
Cleanup mathes/BUGS (#3493)

This one is now #12603.

18 months agoCleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 09:12:06 +0000 (10:12 +0100)]
Cleanup mathes/BUGS (#3493)

Removing. If this is still an issue, it should be described in much
more detail.

18 months agoCleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 09:09:16 +0000 (10:09 +0100)]
Cleanup mathes/BUGS (#3493)

Removing. M-c e has a different meaning nowadays
(tabular-feature delete-vline-left)

Please file a new report with an updated description if this is still
an issue.

18 months agoCleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 09:03:25 +0000 (10:03 +0100)]
Cleanup mathes/BUGS (#3493)

This one is now #12602.

Someone please check whether this is valid, and feel free to close.

18 months agoStart to cleanup mathes/BUGS (#3493)
Juergen Spitzmueller [Tue, 22 Nov 2022 08:59:01 +0000 (09:59 +0100)]
Start to cleanup mathes/BUGS (#3493)

This one is implemented.

18 months agoReflow LyXPaths.cmake
Thibaut Cuvelier [Tue, 22 Nov 2022 03:06:02 +0000 (04:06 +0100)]
Reflow LyXPaths.cmake

Indentation did not match structure.

18 months agoAdd button to stop processing
Juergen Spitzmueller [Mon, 21 Nov 2022 17:56:28 +0000 (18:56 +0100)]
Add button to stop processing

(rather than having it stop by clicking on the spinner)

18 months ago Translation of new index features step 1
jpc [Mon, 21 Nov 2022 17:34:07 +0000 (18:34 +0100)]
          Translation of new index features step 1

18 months agoDo not allow nesting macro names in macro names
Enrico Forestieri [Mon, 21 Nov 2022 17:24:29 +0000 (18:24 +0100)]
Do not allow nesting macro names in macro names

LyX removes a single backslash when it is inserted in a
macro name by the keyboard. However if it is followed by
another character before moving the cursor, it is retained
causing an assertion (bug #12601).

18 months agoSubstack should not be allowed to change columns
Jean-Marc Lasgouttes [Mon, 21 Nov 2022 09:43:08 +0000 (10:43 +0100)]
Substack should not be allowed to change columns

Disable the arguments append-column and delete-column of tabular-features.

The code is taken from InsetMathCases, with some changes
* no need to record undo here
* in dispatch, return is prefered to break, since we do not want to invoke
  InsetMathGrid::doDispatch.
Propagate these changes to InsetMathCases.

Cleanup of the InsetMathCases error messages to fit with other parts
of the code.

The handling of tabular-features in mathed needs to be unified somehow.

Based on a commit from lynx <lorenzobertini97@gmail.com>

Part of bug #12590.

18 months agoremove forgotten traces of Qt4 in configure script
Jean-Marc Lasgouttes [Sun, 20 Nov 2022 20:53:03 +0000 (21:53 +0100)]
remove forgotten traces of Qt4 in configure script

18 months agoAmend(3) 580dea63: get rid of Qt4 code also in cmake build
Kornel Benko [Mon, 21 Nov 2022 08:44:36 +0000 (09:44 +0100)]
Amend(3) 580dea63: get rid of Qt4 code also in cmake build

18 months agoAmend(2) 580dea63: get rid of Qt4 code also in cmake build
Kornel Benko [Mon, 21 Nov 2022 08:31:48 +0000 (09:31 +0100)]
Amend(2) 580dea63: get rid of Qt4 code also in cmake build

18 months agoUpdate check_glyphs.lyx document
Jean-Marc Lasgouttes [Sun, 20 Nov 2022 20:19:44 +0000 (21:19 +0100)]
Update check_glyphs.lyx document

18 months agoFix handling of codepoints 9, 10, 12, 13
Jean-Marc Lasgouttes [Sun, 20 Nov 2022 19:48:35 +0000 (20:48 +0100)]
Fix handling of codepoints 9, 10, 12, 13

Qt >= 5 refuses to display them. We work around this in lib/symbols
already, but make sure we do not try to display math glyphs at these
code points anyway.

Fixes bug #8493.

18 months agoctests: typo in ignoredTests regex
Scott Kostyshak [Sun, 20 Nov 2022 19:39:47 +0000 (14:39 -0500)]
ctests: typo in ignoredTests regex

Amends c94bb34c.

18 months agoComments
Scott Kostyshak [Sun, 20 Nov 2022 19:37:11 +0000 (14:37 -0500)]
Comments

18 months agoDo not allow pasting backslashes in macro names
Enrico Forestieri [Sun, 20 Nov 2022 18:01:38 +0000 (19:01 +0100)]
Do not allow pasting backslashes in macro names

Backslashes are not allowed in macro names and LyX
enforces this by not allowing entering them by keyboard.
However, it was possible to paste them and this may cause
crashes (see bug #12596).

18 months agoRegenerate previews after zoom (#11919)
Juergen Spitzmueller [Sun, 20 Nov 2022 17:18:59 +0000 (18:18 +0100)]
Regenerate previews after zoom (#11919)

18 months agosymbols: fix a type for \Im
Thibaut Cuvelier [Sun, 20 Nov 2022 15:32:58 +0000 (16:32 +0100)]
symbols: fix a type for \Im

18 months agoAmend 48d9d01a: remove debug output
Thibaut Cuvelier [Sun, 20 Nov 2022 15:19:17 +0000 (16:19 +0100)]
Amend 48d9d01a: remove debug output

18 months agoctests: uninvert two xhtml tests
Scott Kostyshak [Sun, 20 Nov 2022 14:48:13 +0000 (09:48 -0500)]
ctests: uninvert two xhtml tests

These exports previously had xmllint errors. These errors seem to
have been fixed thanks to the "features/indexmacros" merge.

Related to #10355.

18 months agoUpdate the format for some doc pages
Thibaut Cuvelier [Sun, 20 Nov 2022 14:20:53 +0000 (15:20 +0100)]
Update the format for some doc pages

18 months agoInsetIndex: when building the IndexNode tree, ignore IndexEntry when empty
Thibaut Cuvelier [Sun, 20 Nov 2022 01:02:13 +0000 (02:02 +0100)]
InsetIndex: when building the IndexNode tree, ignore IndexEntry when empty

The previous code always considered it had at least one term (an assumption that is wrong at least for doc/de/Math.lyx).

18 months agoInsetIndex: enable escaping for terms in the index
Thibaut Cuvelier [Sat, 19 Nov 2022 23:19:53 +0000 (00:19 +0100)]
InsetIndex: enable escaping for terms in the index

The previous code explicitly disabled it and this behaviour caused problems (like "A&A" being output as-is, which is wrong in HTML: it should be "A&amp;A").

18 months agoInsetIndex: improve formatting of resulting XHTML
Thibaut Cuvelier [Sat, 19 Nov 2022 23:12:06 +0000 (00:12 +0100)]
InsetIndex: improve formatting of resulting XHTML

There was no line feed before the closing </li> for entries, which was inconsistent with the other block tags.

18 months agoImprove wording of RELEASE-NOTES entry
Thibaut Cuvelier [Sat, 19 Nov 2022 22:33:43 +0000 (23:33 +0100)]
Improve wording of RELEASE-NOTES entry

18 months agoAmend ac248e39, get rid of Qt4 code also in cmake build
Kornel Benko [Sat, 19 Nov 2022 13:45:03 +0000 (14:45 +0100)]
Amend ac248e39, get rid of Qt4 code also in cmake build

18 months agoRemove a workaround that seems to be useless since Qt 4.8
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 19:09:59 +0000 (20:09 +0100)]
Remove a workaround that seems to be useless since Qt 4.8

18 months agoRemove all uses of Q_WS_* macros
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 18:53:28 +0000 (19:53 +0100)]
Remove all uses of Q_WS_* macros

They are only defined with Qt4.

18 months agoautoconf: remove support for compiling against Qt4
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 18:28:07 +0000 (19:28 +0100)]
autoconf: remove support for compiling against Qt4

Most of the changes consist in assuming that USE_QT5=yes.

Update INSTALL and README accordingly.

18 months agoupdate release notes
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 14:08:21 +0000 (15:08 +0100)]
update release notes

18 months agoGet rid of setSectionResizeMode helper functions.
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 14:04:38 +0000 (15:04 +0100)]
Get rid of setSectionResizeMode helper functions.

18 months agoRemove workaround that was needed only by Qt4
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 13:58:50 +0000 (14:58 +0100)]
Remove workaround that was needed only by Qt4

18 months agoRemove old workaround that was needed for Qt 4.2
Jean-Marc Lasgouttes [Sat, 19 Nov 2022 13:55:33 +0000 (14:55 +0100)]
Remove old workaround that was needed for Qt 4.2

Jürgen believes that this is not needed anymore.

18 months agoGet rid of Qt4 code in src/
Jean-Marc Lasgouttes [Fri, 18 Nov 2022 16:19:50 +0000 (17:19 +0100)]
Get rid of Qt4 code in src/

Qt4 code has been identidifed by
  git grep -l 'QT_VERSION.*\(0x050000\|0x04\)' src

Uses of QT_VERSION_CHECK have been checked too.

been used to remember what places need further work.

Then remaining Qt4 references have been searched using
  git grep -i qt4
  git grep -i 'qt 4'
and relevant issues have been either fixed or noted in the new
TODO.killqt4 file.

19 months agoDrop C++17 if init-statements to support older compilers.
Pavel Sanda [Wed, 16 Nov 2022 20:23:01 +0000 (21:23 +0100)]
Drop C++17 if init-statements to support older compilers.

19 months agoFix compilation with gcc 4.9
Jean-Marc Lasgouttes [Wed, 16 Nov 2022 16:43:22 +0000 (17:43 +0100)]
Fix compilation with gcc 4.9

It appears that gcc 4.9 does not implement the following part of C++11:
https://cplusplus.github.io/CWG/issues/1148.html

Therefore, we have to use a special case in C++11 mode that does an
explicit std:move.

With recent compilers (gcc >= 9), this leads in C++11 mode to a warning:

MetricsInfo.cpp: In member function ‘lyx::Changer lyx::MetricsBase::changeFontSet(const string&)’:
../../master/src/MetricsInfo.cpp:83:13: warning: redundant move in return statement [-Wredundant-move]
   83 |  return move(rc);
      |         ~~~~^~~~
MetricsInfo.cpp:83:13: note: remove ‘std::move’ call

Partly reverts commit fff28c57.

19 months agoMerge branch 'breakspace'
Jean-Marc Lasgouttes [Wed, 16 Nov 2022 09:22:11 +0000 (10:22 +0100)]
Merge branch 'breakspace'

This branch improves handling of spaces on display (see #10117):
* caret is correctly shown in the middle of double spaces in justified rows;

* sequence spaces are correctly shown at the end of rows before
  automatic row breaks.

Moreover, this branch:
* streamlines the code that handles spaces in row breaking

* improves display in Qt4 : although the improvements outlined above
  are not present in Qt4 for monospaced fonts, some dsplay glitches
  are resolved.

* improves performance for very long paragraphs (#12598).

19 months agoFix tex2lyx corner case (#12537)
Juergen Spitzmueller [Fri, 11 Nov 2022 07:12:14 +0000 (08:12 +0100)]
Fix tex2lyx corner case (#12537)

19 months ago(almost) Fix Qt4 support
Jean-Marc Lasgouttes [Thu, 10 Nov 2022 16:24:56 +0000 (17:24 +0100)]
(almost) Fix Qt4 support

When is it detected that our zero-width characters are not really
zero-width, avoid to use them altogether. Currently, this is known to
happen in Qt4 with monospace fonts.

This allow to remove the special Qt4 code in breaskString_helper.

Related to bug #10117.

19 months agoCMake build: disable warn about not known policy
Scott Kostyshak [Thu, 10 Nov 2022 15:34:15 +0000 (10:34 -0500)]
CMake build: disable warn about not known policy

This only showed up with -DLYX_EXTERNAL_ICONV=OFF.

19 months agoUse TextLayoutHelper in x2pos and pos2x
Jean-Marc Lasgouttes [Thu, 14 Jul 2022 16:22:46 +0000 (18:22 +0200)]
Use TextLayoutHelper in x2pos and pos2x

This leads to substantial code simplification.

No intended behavior change.

Related to ticket #10117.

19 months agoRefactor GuiFontMetrics::getLayout
Jean-Marc Lasgouttes [Thu, 14 Jul 2022 15:24:33 +0000 (17:24 +0200)]
Refactor GuiFontMetrics::getLayout

This allows to create a new version that takes an already built
TextLayoutHelper struct as parameter.

No intended change.

See discussion in bug #10117.

19 months agoHandle multiple spaces at row break
Jean-Marc Lasgouttes [Mon, 11 Jul 2022 21:56:35 +0000 (23:56 +0200)]
Handle multiple spaces at row break

In order to work around the Qt row breaking algorithm, which considers
multiple spaces as one at QTextLine break, we insert word_joiner unicode
characters beteween each pair of spaces.

The TextLayoutHelper class makes it easy to handle that.

Update Row::Element::rtrim() to only remove one space at row end.

Update support::countExpanders() to count all spaces, without special
handling for consecutive ones.

Fixes bug #10117.

19 months agoIntroduce a struct to handle docstring <-> QString index translation
Jean-Marc Lasgouttes [Sun, 10 Jul 2022 20:44:23 +0000 (22:44 +0200)]
Introduce a struct to handle docstring <-> QString index translation

This new code allows to get rid of some hardcoded stuff and will be a
foundation for handling of consecutive spaces.

This code can be used in the future for getTextLayout, x2pos, and
pos2x in order to streamline code. Actually some features as the naked
parameter are here to prepare for this second set of changes.

No change intended. The modified code is much clearer, though.

Related to bug #10117.

19 months agoRevert "Fixup 572b06d6: reduce cache size for breakString"
Jean-Marc Lasgouttes [Mon, 7 Nov 2022 23:10:18 +0000 (00:10 +0100)]
Revert "Fixup 572b06d6: reduce cache size for breakString"

10MB cache is not so large after all, and it can be helpful with
Scott's perverse examples.

This reverts commit 2abe7714078a0f772af2e3e2675d6f2b3c054e08.

Fixes part of bug #12598.

19 months agoFix expensive thinko: operator++ returns a reference, not a copy
Jean-Marc Lasgouttes [Mon, 7 Nov 2022 23:06:18 +0000 (00:06 +0100)]
Fix expensive thinko: operator++ returns a reference, not a copy

This accounts for 45% of the row breaking time on the (huge) paragraph
of the MWE in bug #12598.

Fixes part of bug #12598.