]> git.lyx.org Git - features.git/log
features.git
3 years agoFindAdv: Ignore '\ensuremath{' while searching
Kornel Benko [Wed, 3 Feb 2021 11:18:33 +0000 (12:18 +0100)]
FindAdv: Ignore '\ensuremath{' while searching

but keep contents
e.g. '\ensuremath{abc}' ==> 'abc'

3 years agoAmend [bc806084/lyxgit]
Enrico Forestieri [Wed, 3 Feb 2021 10:45:52 +0000 (11:45 +0100)]
Amend [bc806084/lyxgit]

Rise a bit \dot, \ddots & co., as with some fonts they might
be drawn too close to the symbol they decorate.

3 years agoAmend [b6c089afa4/lyxgit].
Juergen Spitzmueller [Wed, 3 Feb 2021 09:23:17 +0000 (10:23 +0100)]
Amend [b6c089afa4/lyxgit].

3 years agoFix bug #11351.
Richard Kimberly Heck [Tue, 2 Feb 2021 22:34:25 +0000 (17:34 -0500)]
Fix bug #11351.

Patch from Daniel.

3 years agoUse a static map so we don't have to reinitialize every time.
Richard Kimberly Heck [Tue, 2 Feb 2021 22:30:57 +0000 (17:30 -0500)]
Use a static map so we don't have to reinitialize every time.

3 years agoFix #12104
Richard Kimberly Heck [Tue, 2 Feb 2021 22:23:00 +0000 (17:23 -0500)]
Fix #12104

3 years agoImprove alignment of math decorations
Enrico Forestieri [Tue, 2 Feb 2021 18:39:52 +0000 (19:39 +0100)]
Improve alignment of math decorations

This patch takes into account the skewness of a character for properly
align a decoration. Unfortunately, the required amount of shift depends
on single chars, so that the recently introduced FontMetrics::italicSlope()
method cannot be used with all characters. A heuristics that produces
satisfactory results is using the italic slope only with characters whose
italic correction (kerning) is zero.

Part of #11491

3 years agoImprove appearance of dots at higher zoom levels
Enrico Forestieri [Mon, 1 Feb 2021 19:02:37 +0000 (20:02 +0100)]
Improve appearance of dots at higher zoom levels

Make \dot, \ddot and friends more round when increasing zoom

Part of #11491

3 years agoMake math decorations scalable with zoom level
Enrico Forestieri [Mon, 1 Feb 2021 01:53:00 +0000 (02:53 +0100)]
Make math decorations scalable with zoom level

Fixes #11491

3 years agoFix highlighting of cursor context in View Source (#12099)
Juergen Spitzmueller [Sun, 31 Jan 2021 16:54:54 +0000 (17:54 +0100)]
Fix highlighting of cursor context in View Source (#12099)

This also considers dark mode,

3 years agomake distcheck broken after old installer purge.
Pavel Sanda [Sun, 31 Jan 2021 15:32:51 +0000 (16:32 +0100)]
make distcheck broken after old installer purge.

3 years agoFix make check
Enrico Forestieri [Sun, 31 Jan 2021 14:21:23 +0000 (15:21 +0100)]
Fix make check

We have to explicitly link zlib after [197ea636/lyxgit].

3 years agoFindAdv: Optimization
Kornel Benko [Sun, 31 Jan 2021 08:53:06 +0000 (09:53 +0100)]
FindAdv: Optimization

Using unordered_map instead of map.
Reasons:
1.) The relevant maps contain 166(Keys) and 649(Accents) entries.
  This mean that average access with 'map' needs 8 to 10 compares to find the value.
2.) Since we are using at least c++11, the unordered_map is available
2.) increasing the maps (in future) needs not to be considered anymore, because
  the access-time will not increase.

3 years agoChange backspace behavior in align type equations
Enrico Forestieri [Sat, 30 Jan 2021 23:51:15 +0000 (00:51 +0100)]
Change backspace behavior in align type equations

When hitting backspace in the first position of a cell in mathed,
if the cell is part of an array, the whole array is dissolved
and the sole cell content pasted in the containing environment.

But if the cell is part of an eqnarray or align math hull type, the
cursor is simply (and unexpectedly) taken out of the whole equation,
which is left unchanged.

This patch makes backspace equivalent to the cursor left key in those
cases, while leaving the behavior unchanged in all other ones.

Fixes #11678

3 years agoPreserve multirow/-column content on deletion of subrows/columns (#11380)
Daniel Ramoeller [Sat, 30 Jan 2021 16:03:33 +0000 (17:03 +0100)]
Preserve multirow/-column content on deletion of subrows/columns (#11380)

3 years agoAdd ProvideInsetLayout and ModifyInsetLayout (#12098)
Juergen Spitzmueller [Sat, 30 Jan 2021 14:56:31 +0000 (15:56 +0100)]
Add ProvideInsetLayout and ModifyInsetLayout (#12098)

This complements ProvideStyle and ModifyStyle.

3 years agoDo not overwrite InsetLayout font/color
Juergen Spitzmueller [Sat, 30 Jan 2021 14:16:12 +0000 (15:16 +0100)]
Do not overwrite InsetLayout font/color

3 years agoWhitespace
Juergen Spitzmueller [Sat, 30 Jan 2021 14:11:18 +0000 (15:11 +0100)]
Whitespace

3 years agoImprove \TestPackageVersion
Juergen Spitzmueller [Sat, 30 Jan 2021 13:00:20 +0000 (14:00 +0100)]
Improve \TestPackageVersion

No need to load packages manually

3 years agoFix a null pointer dereference spotted by coverity
Juergen Spitzmueller [Sat, 30 Jan 2021 12:46:47 +0000 (13:46 +0100)]
Fix a null pointer dereference spotted by coverity

3 years agoRevert "No need to set background color of a newly created branch."
Juergen Spitzmueller [Sat, 30 Jan 2021 08:16:15 +0000 (09:16 +0100)]
Revert "No need to set background color of a newly created branch."

This breaks color initialization with new branches in dark mode.

This reverts commit 5145694cd067e221a661e0d6c7dce4ed5ca22e37.

3 years agoRecent multirow finally allows multiple paragraphs
Juergen Spitzmueller [Sat, 30 Jan 2021 08:15:14 +0000 (09:15 +0100)]
Recent multirow finally allows multiple paragraphs

3 years agoAllow pasting references to mathed
Enrico Forestieri [Sat, 30 Jan 2021 00:32:40 +0000 (01:32 +0100)]
Allow pasting references to mathed

A reference can be directly inserted into mathed but cannot be pasted
because the pasted material is returned in plain text format. This patch
allows getting a string from the cut stack in a suitable format allowing
the math parser to actually create an InsetRef.

Fixes #11539

3 years agoInitialize properly IconInfo struct
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:57:13 +0000 (18:57 +0100)]
Initialize properly IconInfo struct

Spotted by coverity.

3 years agoCopy/paste error in BranchList::setColors
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:51:19 +0000 (18:51 +0100)]
Copy/paste error in BranchList::setColors

Spotted by coverity.

3 years agoChangesMonitor: beware of exceptions in destructor
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:45:50 +0000 (18:45 +0100)]
ChangesMonitor: beware of exceptions in destructor

There may be an exception is the paragraph does not have an owner. In
this case, there is nothing to do anyway.

Spotted by coverity.

3 years agoFindAndReplaceOptions: initialize properly matchAtStart
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:35:38 +0000 (18:35 +0100)]
FindAndReplaceOptions: initialize properly matchAtStart

Spotted by coverity.

3 years agoNo need to set background color of a newly created branch.
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:29:55 +0000 (18:29 +0100)]
No need to set background color of a newly created branch.

Fixes a null pointer dereference spotted by coverity.

3 years agoLengthValidator: initialize properly positive_
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:17:16 +0000 (18:17 +0100)]
LengthValidator: initialize properly positive_

Spotted by coverity.

3 years agoInitialise correctly branch_list_id_
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 17:01:08 +0000 (18:01 +0100)]
Initialise correctly branch_list_id_

Reported by coverity.

3 years agoUpdate sk.po
Kornel Benko [Fri, 29 Jan 2021 15:16:18 +0000 (16:16 +0100)]
Update sk.po

3 years agoCmake key-tests: These are very touchy in respect to timings
Kornel Benko [Fri, 29 Jan 2021 15:11:16 +0000 (16:11 +0100)]
Cmake key-tests: These are very touchy in respect to timings

Cmake key-tests: These are very touchy in respect to timings

1.) Try to use shortcuts instead of direct command
2.) use bigger pause where needed

3 years agoSK-Bindings: remove a binding prohibiting the use as a prefix
Kornel Benko [Fri, 29 Jan 2021 15:05:07 +0000 (16:05 +0100)]
SK-Bindings: remove a binding prohibiting the use as a prefix

3 years agoCosmetics
Juergen Spitzmueller [Fri, 29 Jan 2021 14:46:46 +0000 (15:46 +0100)]
Cosmetics

3 years agoDo not output \maketitle in table cells if the table is in the title
Juergen Spitzmueller [Fri, 29 Jan 2021 14:45:54 +0000 (15:45 +0100)]
Do not output \maketitle in table cells if the table is in the title

3 years agoFixup f3a0e8ff: Reset needUpdate after buffer update
Jean-Marc Lasgouttes [Fri, 29 Jan 2021 13:30:21 +0000 (14:30 +0100)]
Fixup f3a0e8ff: Reset needUpdate after buffer update

3 years agoAvoid deprecation warnings
Enrico Forestieri [Fri, 29 Jan 2021 12:12:29 +0000 (13:12 +0100)]
Avoid deprecation warnings

In Qt 5.15 many deprecation warnings are issued, presumably for
helping the port to Qt 6. They are really a load but can be
shuten up by using -DQT_NO_DEPRECATED_WARNINGS, except for the ones
about MidButton, AdjustToMinimumContentsLength, and DefaultLocaleLongDate.

This change should not affect compilation with Qt 4, as all changes are
backward compatible (only Qt versions prior 4.5 could be affected).

3 years agoUpdate it.po
Enrico Forestieri [Fri, 29 Jan 2021 11:29:36 +0000 (12:29 +0100)]
Update it.po

3 years agoSet proper multirow size in X table columns
Juergen Spitzmueller [Fri, 29 Jan 2021 09:15:36 +0000 (10:15 +0100)]
Set proper multirow size in X table columns

3 years agoctests: unignore tests thanks to lyx2lyx feature
Scott Kostyshak [Thu, 28 Jan 2021 18:35:57 +0000 (13:35 -0500)]
ctests: unignore tests thanks to lyx2lyx feature

The lyx2lyx roundtrip feature added at 364532a7 fixed the
convergence of some tests so we remove them from the ignored list.

3 years agoctests: log found regression and fix
Scott Kostyshak [Thu, 28 Jan 2021 16:59:41 +0000 (11:59 -0500)]
ctests: log found regression and fix

3 years agoRun updateBuffer when adding/merging changes
Jean-Marc Lasgouttes [Thu, 28 Jan 2021 09:10:18 +0000 (10:10 +0100)]
Run updateBuffer when adding/merging changes

Following 4a4ded22, the enabling of some change-related functions is
handled in updateBuffer. However, this method is not ran at every
document change for performance reasons.

This patch adds code to every place that modifies
Paragraph::Private::changes_ that checks whether the `changedness' of
the paragraph, err... changes.

To this end, a new helper struct is introduced that remembers
paragraph state at contruction time, and compares it to new state in
the destructor.

New forceUpdate/needUpdate methods are added to Buffer class, since
the cursor is in general not available in the places where these
changes are made.

Fixes bug #12074.

3 years agode.po
Juergen Spitzmueller [Thu, 28 Jan 2021 09:34:06 +0000 (10:34 +0100)]
de.po

3 years agoUpdate tex2lyx tests
Juergen Spitzmueller [Thu, 28 Jan 2021 09:28:57 +0000 (10:28 +0100)]
Update tex2lyx tests

3 years agoAdd frontispiece layout to KOMA classes
Juergen Spitzmueller [Thu, 28 Jan 2021 09:24:28 +0000 (10:24 +0100)]
Add frontispiece layout to KOMA classes

3 years agoConsider cell language
Juergen Spitzmueller [Thu, 28 Jan 2021 08:25:20 +0000 (09:25 +0100)]
Consider cell language

3 years agoImprove lyx2lyx roundtrip with cellvarwidth
Juergen Spitzmueller [Thu, 28 Jan 2021 07:44:21 +0000 (08:44 +0100)]
Improve lyx2lyx roundtrip with cellvarwidth

3 years agoctests: add found regression and fix
Scott Kostyshak [Thu, 28 Jan 2021 05:25:30 +0000 (00:25 -0500)]
ctests: add found regression and fix

3 years agoctests-costs-benefits: define false positive
Scott Kostyshak [Thu, 28 Jan 2021 05:14:37 +0000 (00:14 -0500)]
ctests-costs-benefits: define false positive

A false positive could either be "not a bug" or a bug that is not
worth the time or complexity to fix. For the purpose of evaluating
the tests, the distinction is not important.

3 years agoctests: ignore lyx2lyx fails due to no convergence
Scott Kostyshak [Thu, 28 Jan 2021 01:28:38 +0000 (20:28 -0500)]
ctests: ignore lyx2lyx fails due to no convergence

These exports knowingly do not pass the convergence tests because
of ERT export.

3 years agoFix dependencies downloading on Windows.
Thibaut Cuvelier [Wed, 27 Jan 2021 19:13:42 +0000 (20:13 +0100)]
Fix dependencies downloading on Windows.

3 years agoUpdate Russian localization
Yuriy Skalko [Mon, 25 Jan 2021 13:12:53 +0000 (15:12 +0200)]
Update Russian localization

3 years agoUpdate sk.po
Kornel Benko [Wed, 27 Jan 2021 09:49:20 +0000 (10:49 +0100)]
Update sk.po

3 years agoProvide translation of caption label for fr and he.
Jean-Marc Lasgouttes [Wed, 27 Jan 2021 09:31:20 +0000 (10:31 +0100)]
Provide translation of caption label for fr and he.

Part of bug #10531.

3 years agoRemerge strings
Jean-Marc Lasgouttes [Tue, 26 Jan 2021 18:29:37 +0000 (19:29 +0100)]
Remerge strings

3 years agoMake InsetCaption label localizable
Jean-Marc Lasgouttes [Tue, 26 Jan 2021 18:26:36 +0000 (19:26 +0100)]
Make InsetCaption label localizable

Part of bug #10531.

3 years agocount_pars_in_inset: check nested insets
Juergen Spitzmueller [Wed, 27 Jan 2021 07:24:17 +0000 (08:24 +0100)]
count_pars_in_inset: check nested insets

3 years agoctests: log cost of recent false positive
Scott Kostyshak [Tue, 26 Jan 2021 18:28:41 +0000 (13:28 -0500)]
ctests: log cost of recent false positive

3 years agoStart a log file to track benefit/costs of ctests
Scott Kostyshak [Tue, 26 Jan 2021 18:19:34 +0000 (13:19 -0500)]
Start a log file to track benefit/costs of ctests

The ctests are not convenient tests. In this file we can attempt to
log the benefits and costs to using them so we can periodically
evaluate which tests we should keep and which we should get rid of.

3 years agoFix InsetCaption in RTL environment.
Jean-Marc Lasgouttes [Tue, 26 Jan 2021 16:55:09 +0000 (17:55 +0100)]
Fix InsetCaption in RTL environment.

This requires to add a new mutable member, rtl_, to remember this context.

Part of bug #10531.

3 years agode.po
Juergen Spitzmueller [Tue, 26 Jan 2021 15:44:49 +0000 (16:44 +0100)]
de.po

3 years agoSome minor polishment
Juergen Spitzmueller [Tue, 26 Jan 2021 13:50:14 +0000 (14:50 +0100)]
Some minor polishment

3 years agoFix copy-paste error (#12092)
Juergen Spitzmueller [Tue, 26 Jan 2021 13:48:12 +0000 (14:48 +0100)]
Fix copy-paste error (#12092)

3 years agoUpdate it.po
Enrico Forestieri [Tue, 26 Jan 2021 10:11:51 +0000 (11:11 +0100)]
Update it.po

3 years agoInsetCaption: move intialization to declaration
Jean-Marc Lasgouttes [Tue, 26 Jan 2021 09:17:25 +0000 (10:17 +0100)]
InsetCaption: move intialization to declaration

3 years agoIntroduce InputGlobal (#12087)
Juergen Spitzmueller [Tue, 26 Jan 2021 07:42:39 +0000 (08:42 +0100)]
Introduce InputGlobal (#12087)

This is a variant of Input for layout files that only searches build
and system directories and thus allows "InputGlobal name.inc" in a user
file name.inc that attempts to modify its global counterpart.

3 years agoConst
Richard Kimberly Heck [Mon, 25 Jan 2021 19:35:37 +0000 (14:35 -0500)]
Const

3 years agoAllow to move multiple (selected) columns/rows (#9045)
Juergen Spitzmueller [Mon, 25 Jan 2021 18:00:50 +0000 (19:00 +0100)]
Allow to move multiple (selected) columns/rows (#9045)

3 years agoDisable respectOSkbd checkbox
Jean-Marc Lasgouttes [Mon, 25 Jan 2021 17:35:41 +0000 (18:35 +0100)]
Disable respectOSkbd checkbox

This is not ready yet. See discussion in #6450.

3 years agoDo not disable DEPM paragraph deleting when FreeSpacing is true.
Jean-Marc Lasgouttes [Thu, 21 Jan 2021 14:18:43 +0000 (15:18 +0100)]
Do not disable DEPM paragraph deleting when FreeSpacing is true.

This is an old issue that never got fixed.

Fixes bug #10413.

3 years agoUpdate sk.po
Kornel Benko [Mon, 25 Jan 2021 11:17:16 +0000 (12:17 +0100)]
Update sk.po

3 years agoFixup revert_vcolumns2 routine
Juergen Spitzmueller [Mon, 25 Jan 2021 11:04:45 +0000 (12:04 +0100)]
Fixup revert_vcolumns2 routine

3 years agoGuiTabular: only apply changed features (#10450)
Juergen Spitzmueller [Mon, 25 Jan 2021 10:00:06 +0000 (11:00 +0100)]
GuiTabular: only apply changed features (#10450)

3 years agoAupdate sk.po
Kornel Benko [Mon, 25 Jan 2021 09:59:28 +0000 (10:59 +0100)]
Aupdate sk.po

3 years agoFindAdv: Select search for language-format depending on document language.
Kornel Benko [Mon, 25 Jan 2021 09:52:14 +0000 (10:52 +0100)]
FindAdv: Select search for language-format depending on document language.

In case of search with format:
If the pattern contains language spec different to the document language
then do not ignore language setting.

Also renamed 'matchstart' in FindAndReplaceOptions to 'matchAtStart'

3 years agoFix alignment missetting with multirows (#10826)
Juergen Spitzmueller [Mon, 25 Jan 2021 08:09:07 +0000 (09:09 +0100)]
Fix alignment missetting with multirows (#10826)

3 years agoFix on-screen vertical alignment in some table cells (#7757)
Juergen Spitzmueller [Sun, 24 Jan 2021 14:28:37 +0000 (15:28 +0100)]
Fix on-screen vertical alignment in some table cells (#7757)

3 years agoLFUN_FILE_OPEN: Strip quotes from argument (#12091)
Juergen Spitzmueller [Sun, 24 Jan 2021 13:48:55 +0000 (14:48 +0100)]
LFUN_FILE_OPEN: Strip quotes from argument (#12091)

3 years agode.po
Juergen Spitzmueller [Sat, 23 Jan 2021 14:54:24 +0000 (15:54 +0100)]
de.po

3 years agoFixup tex2lyx parse_cell_content method
Juergen Spitzmueller [Sat, 23 Jan 2021 14:50:39 +0000 (15:50 +0100)]
Fixup tex2lyx parse_cell_content method

3 years agoFix metrics of varwidth cells (#12089)
Juergen Spitzmueller [Sat, 23 Jan 2021 14:22:09 +0000 (15:22 +0100)]
Fix metrics of varwidth cells (#12089)

3 years agoSupport non-default styles in multirow
Juergen Spitzmueller [Sat, 23 Jan 2021 13:53:51 +0000 (14:53 +0100)]
Support non-default styles in multirow

3 years agoAllow paragraph and line breaks in multirow (#12083)
Juergen Spitzmueller [Sat, 23 Jan 2021 13:24:54 +0000 (14:24 +0100)]
Allow paragraph and line breaks in multirow (#12083)

3 years agotex2lyx: support extended varwidth table cells
Juergen Spitzmueller [Sat, 23 Jan 2021 08:33:52 +0000 (09:33 +0100)]
tex2lyx: support extended varwidth table cells

3 years agoupdate tex2lyx tests
Juergen Spitzmueller [Sat, 23 Jan 2021 07:19:21 +0000 (08:19 +0100)]
update tex2lyx tests

3 years agoFix status of tabular function
Juergen Spitzmueller [Sat, 23 Jan 2021 07:10:55 +0000 (08:10 +0100)]
Fix status of tabular function

3 years agoFix compilation of ru/UserGuide.lyx
Scott Kostyshak [Sat, 23 Jan 2021 03:26:02 +0000 (22:26 -0500)]
Fix compilation of ru/UserGuide.lyx

Consistent with 0629b9b7.

3 years agoFindAdv: Make search for text in deleted regions configurable.
Kornel Benko [Fri, 22 Jan 2021 20:11:28 +0000 (21:11 +0100)]
FindAdv: Make search for text in deleted regions configurable.

The function call 'search-ignore deleted false'
makes findadv to search also deleted parts,
while 'search-ignore deleted true' will omit these parts.

3 years agoFormat incremented to 605: Extended variable table cell support
Juergen Spitzmueller [Fri, 22 Jan 2021 18:16:43 +0000 (19:16 +0100)]
Format incremented to 605: Extended variable table cell support

- Multicolumn now supports multiple paragraphs in non-fixed-width context.
- Multicolumn now supports valign in non-fixed-width context.
- varwidth columns now properly align horizontally and vertically.

3 years agoFindAdv: Do not search in deleted text.
Kornel Benko [Fri, 22 Jan 2021 16:03:54 +0000 (17:03 +0100)]
FindAdv: Do not search in deleted text.

3 years agoUpdate Development.lyx
Yuriy Skalko [Sun, 10 Jan 2021 11:27:40 +0000 (13:27 +0200)]
Update Development.lyx

3 years agoPrevent more local colors from leaking (#6626)
Juergen Spitzmueller [Fri, 22 Jan 2021 09:34:41 +0000 (10:34 +0100)]
Prevent more local colors from leaking (#6626)

3 years agoShortcut for custom insets
Richard Kimberly Heck [Thu, 21 Jan 2021 21:51:11 +0000 (16:51 -0500)]
Shortcut for custom insets

3 years agoFindAdv: Fix backward search and search for special char '{' and '}'
Kornel Benko [Thu, 21 Jan 2021 12:39:25 +0000 (13:39 +0100)]
FindAdv: Fix backward search and search for special char '{' and '}'

Change effects mostly searches with ignored format search.
Backwards search is much slower, but at least more or less working.

3 years agoDo not paint change mark for individual table cell insets (#12077)
Juergen Spitzmueller [Thu, 21 Jan 2021 08:04:29 +0000 (09:04 +0100)]
Do not paint change mark for individual table cell insets (#12077)

3 years agoUpdate Russian localization
Yuriy Skalko [Sat, 9 Jan 2021 12:13:57 +0000 (14:13 +0200)]
Update Russian localization

3 years agoPrevent branch background color from leaking out of the document
Juergen Spitzmueller [Thu, 21 Jan 2021 07:09:41 +0000 (08:09 +0100)]
Prevent branch background color from leaking out of the document

This is assured by a unique branchlist ID that is now part of the branch
color name

3 years agoAmend c041bb66: Unintended debug output slipped in
Kornel Benko [Wed, 20 Jan 2021 16:09:08 +0000 (17:09 +0100)]
Amend c041bb66: Unintended debug output slipped in

3 years agoAccount for spaces in paths to templates (#12082)
Juergen Spitzmueller [Wed, 20 Jan 2021 16:05:10 +0000 (17:05 +0100)]
Account for spaces in paths to templates (#12082)

3 years agoDo not rely on hardcoded color when determining boxbgcolor
Juergen Spitzmueller [Wed, 20 Jan 2021 13:15:48 +0000 (14:15 +0100)]
Do not rely on hardcoded color when determining boxbgcolor