Stephan Witt [Sat, 5 Jan 2019 23:22:21 +0000 (00:22 +0100)]
Correct converter configuration for inkscape on Mac
On Mac the inkscape binary is started by a wrapper script. This script changes the
working directory internally and fails to process files with relative path names.
The previous attempt to solve it was to pass the file names with absolute names
by prepending them with the $$p variable (representing the directory name of the files).
This broke the on screen conversion (used for SVGZ to PNG e.g. in the users guide)
because here the $$p variable is undefined.
Now the wrapper script of LyX which is used to locate the Inkscape.app bundle converts
the relative path names into absolute names and the $$p variable is removed from the
converter definitions for inkscape again.
Scott Kostyshak [Sat, 5 Jan 2019 22:38:10 +0000 (17:38 -0500)]
ctests: invert ko splash lyx22x and lyx23x tests
The Korean splash.lyx is expected to fail with pdflatex. The lyx22x
and lyx23x tests were not failing before because they were exporting
to XeTeX with system fonts, which succeeds. After c9e62dec (which
corrects the export format to the default), the lyx22x and lyx23x
tests should be inverted.
Scott Kostyshak [Sat, 5 Jan 2019 21:45:44 +0000 (16:45 -0500)]
Bibliography.lyx: remove preamble and master doc
The preamble is not used since this document should only be compiled
from documents that include it. Similarly, setting the master
document is not useful.
In computing the length of the extension, the code does not account
for the prefix "unzipped_", which is added when the zipped filename
does not have one of the extensions "gz", "z", "Z", or "svgz", and
thus the used index is out of bounds. See also this thread:
https://www.mail-archive.com/lyx-devel@lists.lyx.org/msg207360.html
Kornel Benko [Sat, 5 Jan 2019 07:34:00 +0000 (08:34 +0100)]
Cmake lyx2lyx tests: Correct use of value for \use_non_tex_fonts
Amend eec3d1eb,7568571a
We are trying to check if the resulting file after lyx2lyx
is compilable, we have to ensure that copying the original file
to the test directory does not mangle use_non_tex_fonts-entry.
Bibliography.lyx is not expected to be compiled on its own. This
commit reverts 3ac2dd8e and instead adds a LyX note explaining that
an error is expected if the .lyx file is compiled.
For some reason, adding a LTR/RTL Override unicode character before a
MinionPro string increases the ascent of the line.
This creates vertical offset issues when painting if the ascent used
as reference is the one of the font. Use the QTextLine ascent instead
for better results.
Scott Kostyshak [Wed, 2 Jan 2019 19:04:39 +0000 (14:04 -0500)]
ctests: restore thesis.lyx lyx2lyx tests
These tests failed because of (multiple instances of) the following
warning:
Warning: a buffer should not have two parents!
This warning is expected, because, for example, chapter-1 includes
Bibliography.lyx and chapter-2 includes Bibliography.lyx. thesis.lyx
includes both chapter-1 and chapter-2, so both are loaded (but
hidden), and Bibliography.lyx is loaded (but hidden), and LyX then
sees that more than one buffer includes Bibliography.lyx
The consequence of ignoring this warning is that we will not catch
any future regression that triggers this warning when it should not.
Scott Kostyshak [Wed, 2 Jan 2019 19:02:03 +0000 (14:02 -0500)]
Fix compilation of chessgame.lyx with only TL 2018
chess-workshop-symbols.sty is no longer (on an updated TL 2018)
included in the TL package "skak". This commit replaces the loading
of chess-workshop-symbols in the custom preamble with the loading of
the package chessfss.
chessfss is in TL 2016 and TL 2018, and the example file now
compiles with both TL installations.
Before this commit, compilation of chessgame.lyx was possible if
chess-workshop-symbols.sty were installed manually (i.e., outside of
TL), but it is preferred to keep dependencies to only TL if
possible.
Eventually, all overridden virtual methods should be marked properly.
Currently, clang only warns about those in classes that already use
override in at least one place (which was the case dor GuiApplication).
When blinking the caret, it looks like a cool idea to only update the
small rectangle containing the caret. Actually it is an awful idea, since
the paint event will paint some rows, and these rows will not be
properly painted outside of the small rectangle. Unfortunately, the
painter will skip those "painted" rows on next paint events.
This leads to painting errors that depend on the ordering of "real"
and "caret" paint events. This is the reason why they only appeared
with split screens.
Quote of the day: ``The real problem is that programmers have spent far
too much time worrying about efficiency in the wrong places and at the
wrong times; premature optimization is the root of all evil (or at
least most of it) in programming.''
-- Donald Knuth, The Art of Computer Programming.
José Matos [Sat, 29 Dec 2018 19:14:41 +0000 (19:14 +0000)]
Move all python shebangs from /usr/bin/env to python3.
The change is only relevant to development as all the call to python scripts is done
calling C++ os::python that invoques the appropriate python version.
The change is two fold, on one hand remove all the uses of /usr/bin/env for python.
On the other hand rename all the calls to python from python to python3 making it explicit
and being compliant with PEP 394 -- The "python" Command on Unix-Like Systems:
https://www.python.org/dev/peps/pep-0394/
Remove the sheebang from src/graphics/GraphicsConverter.cpp because it is not necessary.
This adds a new (boolean) parameter "active" to the label cache, where
we track whether a label is deleted in ct mode (the same could be done,
if wanted, for labels in notes and inactive branches).
Deleted (inactive) labels are neither considered in the uniqueness check
nor added to the outliner. This also means that undeleted references to
deleted labels are now (correctly) marked as BROKEN.
We need to load the master document before applying the params, since
otherwise the TOC reset (and other things) happen before the master
has been loaded (and set as parent).
Scott Kostyshak [Fri, 28 Dec 2018 15:40:38 +0000 (10:40 -0500)]
Fix assertion when checking if change in selection
The check for the iterator being in the same paragraph as the end of
selection was incorrect, because paragraphs in different cells could
have the same pit. We now additionally condition on having the same
idx.
projects / lyx.git / log