From: Enrico Forestieri <forenr@lyx.org>
Date: Wed, 7 Jun 2017 16:15:59 +0000 (+0200)
Subject: Don't allow captions in non-floating listings
X-Git-Tag: 2.3.0beta1~305
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=fd0756141c960d1eb2ffa0e947f01f91aa6b6334;p=features.git

Don't allow captions in non-floating listings

It was possible to insert a caption in a listing not marked as
floating. This didn't cause errors but the caption simply was
disappearing in the output.
---

diff --git a/src/insets/InsetListings.cpp b/src/insets/InsetListings.cpp
index b5a5701817..033b72ea2c 100644
--- a/src/insets/InsetListings.cpp
+++ b/src/insets/InsetListings.cpp
@@ -418,7 +418,8 @@ bool InsetListings::getStatus(Cursor & cur, FuncRequest const & cmd,
 			return true;
 		case LFUN_CAPTION_INSERT: {
 			// the inset outputs at most one caption
-			if (params().isInline() || getCaptionInset()) {
+			if (params().isInline() || !params().isFloat()
+						|| getCaptionInset()) {
 				status.setEnabled(false);
 				return true;
 			}