From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Mon, 27 Nov 2023 10:46:52 +0000 (+0100)
Subject: Avoid metrics computation on resize when width did not change
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=f7218cec188cad2dbf68de47ad4345fcddf1bdb8;p=features.git

Avoid metrics computation on resize when width did not change

Entering a math inset triggers a work area reize because the math
toobars appear automatically. However, by default these toolbars are
at the bottom of the screen and their presence does not change the
typesetting of paragraphs. Therefore it is useful to avoid a call to
updateMetrics() in the case where the width of the work area did not
change.

Part of bug #12297.
---

diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 34be860691..c03f928c4d 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -2484,14 +2484,16 @@ void BufferView::clearSelection()
 
 void BufferView::resize(int width, int height)
 {
-	// Update from work area
-	width_ = width;
 	height_ = height;
+	// Update metrics only if width has changed
+	if (width != width_) {
+		width_ = width;
 
-	// Clear the paragraph height cache.
-	d->par_height_.clear();
-	// Redo the metrics.
-	updateMetrics();
+		// Clear the paragraph height cache.
+		d->par_height_.clear();
+		// Redo the metrics.
+		updateMetrics();
+	}
 }
 
 
@@ -3131,6 +3133,8 @@ void BufferView::updateMetrics(bool force)
 	if (!ready())
 		return;
 
+	//LYXERR0("updateMetrics " << _v_(force));
+
 	Text & buftext = buffer_.text();
 	pit_type const lastpit = int(buftext.paragraphs().size()) - 1;