From: Juergen Spitzmueller <spitz@lyx.org>
Date: Fri, 19 Apr 2019 07:34:12 +0000 (+0200)
Subject: More formalia
X-Git-Tag: lyx-2.4.0dev-acb2ca7b~2146
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=e97546c9a8510e6ac85c4817ae851ff3ddd86a4d;p=features.git

More formalia

(this are just things QtCreator nags about, and I address them in passing)
---

diff --git a/src/insets/InsetBibitem.cpp b/src/insets/InsetBibitem.cpp
index 64e6a31bf5..221e6291b8 100644
--- a/src/insets/InsetBibitem.cpp
+++ b/src/insets/InsetBibitem.cpp
@@ -216,7 +216,7 @@ int InsetBibitem::plaintext(odocstringstream & os,
 	docstring const str = oss.str();
 	os << str;
 
-	return str.size();
+	return int(str.size());
 }
 
 
@@ -229,7 +229,7 @@ docstring bibitemWidest(Buffer const & buffer, OutputParams const & runparams)
 
 	int w = 0;
 
-	InsetBibitem const * bitem = 0;
+	InsetBibitem const * bitem = nullptr;
 
 	// FIXME: this font is used unitialized for now but should  be set to
 	// a proportional font. Here is what Georg Baum has to say about it:
@@ -279,7 +279,7 @@ docstring bibitemWidest(Buffer const & buffer, OutputParams const & runparams)
 		// So for now we just use the label size in order to be sure
 		// that GUI and no-GUI gives the same bibitem (even if that is
 		// potentially the wrong one.
-		int const wx = label.size();
+		int const wx = int(label.size());
 
 		if (wx > w) {
 			w = wx;