From: Juergen Spitzmueller <spitz@lyx.org>
Date: Sun, 30 Dec 2018 12:24:51 +0000 (+0100)
Subject: Expand comment
X-Git-Tag: lyx-2.4.0dev-acb2ca7b~2773
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=e8c1cb5074e36a344553d57537f8177345a86686;p=features.git

Expand comment
---

diff --git a/src/Buffer.cpp b/src/Buffer.cpp
index 50cc2f243f..54a4dff5a7 100644
--- a/src/Buffer.cpp
+++ b/src/Buffer.cpp
@@ -2497,8 +2497,15 @@ void Buffer::checkIfBibInfoCacheIsValid() const
 		return;
 	}
 
-	// if we already know the cache is invalid, no need to check
-	// the timestamps
+	// If we already know the cache is invalid, stop here.
+	// This is important in the case when the bibliography
+	// environment (rather than Bib[la]TeX) is used.
+	// In that case, the timestamp check below gives no
+	// sensible result. Rather than that, the cache will
+	// be invalidated explicitly via invalidateBibInfoCache()
+	// by the Bibitem inset.
+	// Same applies for bib encoding changes, which trigger
+	// invalidateBibInfoCache() by InsetBibtex.
 	if (!d->bibinfo_cache_valid_)
 		return;