From: Scott Kostyshak <skostysh@lyx.org>
Date: Wed, 11 Mar 2020 19:02:22 +0000 (-0400)
Subject: Fix preview check box for include insets
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=e0c02c39d869c49125c0a69e269c943d558f5d25;p=features.git

Fix preview check box for include insets

GuiInclude::initialiseParams() calls InsetCommand::string2params()
which calls InsetCommandParams::clear(), however this last function
did not reset the special "preview_" parameter. Now this parameter
is reset to false as part of clear().

The ParamData class documents (see InsetCommandParams.h) the
following:

  // No parameter may be named "preview", because that is a required
  // flag for all commands.

Thus, we must handle preview_ separately from the other parameters.

This commit fixes #11779.
---

diff --git a/src/insets/InsetCommandParams.cpp b/src/insets/InsetCommandParams.cpp
index e22db99595..c4c0a5cf46 100644
--- a/src/insets/InsetCommandParams.cpp
+++ b/src/insets/InsetCommandParams.cpp
@@ -627,6 +627,7 @@ docstring & InsetCommandParams::operator[](string const & name)
 void InsetCommandParams::clear()
 {
 	params_.clear();
+	preview(false);
 }