From: José Matos <jamatos@lyx.org>
Date: Mon, 3 Jun 2019 16:15:09 +0000 (+0100)
Subject: Fix bug in python comparison.
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=d63d6b74361e7102538441b08da34d3e71dfac79;p=features.git

Fix bug in python comparison.

It worked in python2 but not the way the authors imagined. Because hex always returns a string.

From python2:
>>> 1 > "2"
False
>>> "2" > 1
True
>>> "1" > 2
True

The rational is that an integer is always smaller than a string.

In python 3 this because it does not make sense to compare objects of different types.
---

diff --git a/lib/scripts/convertDefault.py b/lib/scripts/convertDefault.py
index 418b553758..eee533d5ea 100644
--- a/lib/scripts/convertDefault.py
+++ b/lib/scripts/convertDefault.py
@@ -72,7 +72,7 @@ if sys.argv[1] == 'pdf' and (version >= 0x060206 or gm):
     sopts = '-define pdf:use-cropbox=true ' + sopts
 
 # If supported, add the -flatten option for ppm target formats (see bug 4749)
-if sys.argv[3] == 'ppm' and (im and version >= 0x060305 or gm):
+if sys.argv[3] == 'ppm' and (im and version >= "0x060305" or gm):
     topts = '-flatten'
 
 # print (command, sys.argv[2], sys.argv[4], file= sys.stdout)