From: Pavel Sanda <sanda@lyx.org>
Date: Wed, 13 Jan 2010 19:07:18 +0000 (+0000)
Subject: Move lyxerrFlush() out of singnal/slot business.
X-Git-Tag: 2.0.0~4384
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=d481f75848e77595f3d26ff10d6479eadbc44899;p=features.git

Move lyxerrFlush() out of singnal/slot business.

Under massive load of lyxerr<< messages we lose synchronization in ui
and messages get garbled into each other.

This patch helps a lot, note however that the problem is generally hard to
solve in multithreaded environment because from inside lyxerr there is no
way how to know that t1b should be bound to t1a when thread is switched in
unfortunated time and thread thread2 goes for his bussiness.

thread1 out<<t1a<<t1b<<"\n";
thread2 out<<t2a<<t2b<<"\n";






git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@33013 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/frontends/qt4/GuiProgress.cpp b/src/frontends/qt4/GuiProgress.cpp
index 333b34f873..0735265384 100644
--- a/src/frontends/qt4/GuiProgress.cpp
+++ b/src/frontends/qt4/GuiProgress.cpp
@@ -48,7 +48,6 @@ GuiProgress::GuiProgress(GuiView * view) : view_(view)
 	connect(this, SIGNAL(appendMessage(QString const &)), SLOT(doAppendMessage(QString const &)));
 	connect(this, SIGNAL(appendError(QString const &)), SLOT(doAppendError(QString const &)));
 	connect(this, SIGNAL(clearMessages()), SLOT(doClearMessages()));
-	connect(this, SIGNAL(lyxerrFlush()), SLOT(dolyxerrFlush()));
 	
 	// Alert interface
 	connect(this, SIGNAL(warning(QString const &, QString const &)),
@@ -96,7 +95,7 @@ void GuiProgress::doClearMessages()
 }
 
 
-void GuiProgress::dolyxerrFlush()
+void GuiProgress::lyxerrFlush()
 {
 	appendLyXErrMessage(toqstr(lyxerr_stream_.str()));
 	lyxerr_stream_.str("");
diff --git a/src/frontends/qt4/GuiProgress.h b/src/frontends/qt4/GuiProgress.h
index 4f5f5e7dd8..09c891acd1 100644
--- a/src/frontends/qt4/GuiProgress.h
+++ b/src/frontends/qt4/GuiProgress.h
@@ -40,6 +40,7 @@ public:
 
 	void lyxerrConnect();
 	void lyxerrDisconnect();
+	void lyxerrFlush();
 
 Q_SIGNALS:
 	void processStarted(QString const &);
@@ -47,7 +48,6 @@ Q_SIGNALS:
 	void appendMessage(QString const &);
 	void appendError(QString const &);
 	void clearMessages();
-	void lyxerrFlush();
 	void appendLyXErrMessage(QString const & text);
 
 	// Alert interface
@@ -62,8 +62,6 @@ private Q_SLOTS:
 	void doAppendMessage(QString const &);
 	void doAppendError(QString const &);
 	void doClearMessages();
-	void dolyxerrFlush();
-
 
 	void doWarning(QString const &, QString const &);
 	void doToggleWarning(QString const & title, QString const & msg, QString const & formatted);