From: Scott Kostyshak <skostysh@lyx.org>
Date: Thu, 19 Mar 2020 14:16:19 +0000 (-0400)
Subject: Fix Qt deprecation warns for setTextColor()
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=d0245c2bcdea208b855bcce5bb80dbe08ebc3e37;p=features.git

Fix Qt deprecation warns for setTextColor()

This commit fixes the following warning from Qt 5.14:

  error: ‘void QTreeWidgetItem::setTextColor(int, const QColor&)’ is deprecated: Use QTreeWidgetItem::setForeground() instead [-Werror=deprecated-declarations]

setForeground was introduced in Qt 4.2 [1].

We have a couple of commented out uses of a setTextColor() method in
GuiDocument.cpp, but the QTextEdit::setTextColor() is not deprecated so no
change is needed.

[1] https://doc.qt.io/archives/qt-4.8/qtreewidgetitem.html#setForeground
---

diff --git a/src/frontends/qt/PanelStack.cpp b/src/frontends/qt/PanelStack.cpp
index c61c8e0244..243542d321 100644
--- a/src/frontends/qt/PanelStack.cpp
+++ b/src/frontends/qt/PanelStack.cpp
@@ -212,7 +212,7 @@ static void setTreeItemStatus(QTreeWidgetItem * tree_item, bool enabled)
 	// Change the color from black to gray or viceversa
 	QPalette::ColorGroup new_color =
 		enabled ? QPalette::Active : QPalette::Disabled;
-	tree_item->setTextColor(0, QApplication::palette().color(new_color,
+	tree_item->setForeground(0, QApplication::palette().color(new_color,
 	                                                         QPalette::Text));
 }