From: Enrico Forestieri <forenr@lyx.org>
Date: Sat, 20 Jun 2015 14:37:12 +0000 (+0200)
Subject: Fix another couple of issues spotted by Guillaume
X-Git-Tag: 2.2.0alpha1~502
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=cabc7c4be191f4700f79bd6ca9109697ae074b58;p=features.git

Fix another couple of issues spotted by Guillaume

* Take into account macro redefinitions in the legacy route
* Take into account macros inside nested macro definitions
---

diff --git a/lib/scripts/lyxpreview_tools.py b/lib/scripts/lyxpreview_tools.py
index 6766b5f08d..de2e5c5762 100644
--- a/lib/scripts/lyxpreview_tools.py
+++ b/lib/scripts/lyxpreview_tools.py
@@ -272,11 +272,13 @@ def write_metrics_info(metrics_info, metrics_file):
 # Reads a .tex files and create an identical file but only with
 # pages whose index is in pages_to_keep
 def filter_pages(source_path, destination_path, pages_to_keep):
+    def_re = re.compile(r"(\\newcommandx|\\renewcommandx|\\global\\long\\def)(\\[a-zA-Z]+)(.+)")
     source_file = open(source_path, "r")
     destination_file = open(destination_path, "w")
 
     page_index = 0
     skip_page = False
+    macros = []
     for line in source_file:
         # We found a new page
         if line.startswith("\\begin{preview}"):
@@ -285,6 +287,14 @@ def filter_pages(source_path, destination_path, pages_to_keep):
             skip_page = page_index not in pages_to_keep
 
         if not skip_page:
+            match = def_re.match(line)
+            if match != None:
+                definecmd = match.group(1)
+                macroname = match.group(2)
+                if not macroname in macros:
+                    macros.append(macroname)
+                    if definecmd == "\\renewcommandx":
+                        line = line.replace(definecmd, "\\newcommandx")
             destination_file.write(line)
 
         # End of a page, we reset the skip_page bool
diff --git a/src/mathed/InsetMathHull.cpp b/src/mathed/InsetMathHull.cpp
index e1e339dacb..d8850e835e 100644
--- a/src/mathed/InsetMathHull.cpp
+++ b/src/mathed/InsetMathHull.cpp
@@ -37,6 +37,7 @@
 #include "LyXRC.h"
 #include "MacroTable.h"
 #include "MathMacro.h"
+#include "MathMacroTemplate.h"
 #include "output_xhtml.h"
 #include "Paragraph.h"
 #include "ParIterator.h"
@@ -635,6 +636,7 @@ void InsetMathHull::usedMacros(MathData const & md, DocIterator const & pos,
 
 	for (size_t i = 0; i < md.size(); ++i) {
 		MathMacro const * mi = md[i].nucleus()->asMacro();
+		MathMacroTemplate const * mt = md[i].nucleus()->asMacroTemplate();
 		InsetMathScript const * si = md[i].nucleus()->asScriptInset();
 		InsetMathFracBase const * fi = md[i].nucleus()->asFracBaseInset();
 		InsetMathGrid const * gi = md[i].nucleus()->asGridInset();
@@ -662,6 +664,10 @@ void InsetMathHull::usedMacros(MathData const & md, DocIterator const & pos,
 				asArray(data->definition(), ar);
 			}
 			usedMacros(ar, pos, macros, defs);
+		} else if (mt) {
+			MathData ar(pos.buffer());
+			asArray(mt->definition(), ar);
+			usedMacros(ar, pos, macros, defs);
 		} else if (si) {
 			if (!si->nuc().empty())
 				usedMacros(si->nuc(), pos, macros, defs);