From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Tue, 2 Jul 2024 12:49:34 +0000 (+0200)
Subject: Avoid crash when InsetBibitem::updateCommand shows a dialog
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=c84c59eaecf19b1eb8227f9aadc7f5be187b3856;p=lyx.git

Avoid crash when InsetBibitem::updateCommand shows a dialog

This is one of the places where a dialog is shown (indicating that
some bibtems have been renamed) while the metrics are not up to date.
Then a draw operation can be triggered too early and a crash can ensue.

Use ad-hoc solution for this case and use Buffer::setBusy(). The
Alert::warning helper cannot really do that since it doe snot know the
current buffer.
---

diff --git a/src/insets/InsetBibitem.cpp b/src/insets/InsetBibitem.cpp
index 343770e14d..beb775bc14 100644
--- a/src/insets/InsetBibitem.cpp
+++ b/src/insets/InsetBibitem.cpp
@@ -95,9 +95,11 @@ void InsetBibitem::updateCommand(docstring const & new_key, bool)
 			++i;
 			key = new_key + '-' + convert<docstring>(i);
 		}
+		buffer().setBusy(true);
 		frontend::Alert::warning(_("Keys must be unique!"),
 			bformat(_("The key %1$s already exists,\n"
 			"it will be changed to %2$s."), new_key, key));
+		buffer().setBusy(false);
 	}
 	setParam("key", key);
 	buffer().invalidateBibinfoCache();