From: Richard Kimberly Heck <rikiheck@lyx.org>
Date: Fri, 13 Nov 2020 01:31:13 +0000 (-0500)
Subject: Another comment
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=c114eec79ae078c019d98d43fec29a14ab3e0e85;p=features.git

Another comment
---

diff --git a/src/Paragraph.cpp b/src/Paragraph.cpp
index 8a97209ea9..8241e42d02 100644
--- a/src/Paragraph.cpp
+++ b/src/Paragraph.cpp
@@ -4561,6 +4561,10 @@ void Paragraph::updateMacros(DocIterator const & us, DocIterator const & scope)
 	// iterate over the insets of the current paragraph
 	for (auto const & insit : insetList()) {
 		it.pos() = insit.pos;
+		// Most insets want a DocIterator that points to the beginning
+		// of their associated text. Some do not (macros, includes), but
+		// those can pop that off.
+		// FIXME Surely there is some better way.
 		it.push_back(CursorSlice(*insit.inset));
 		insit.inset->updateMacros(it, scope);
 		it.pop_back();