From: Pavel Sanda <sanda@lyx.org>
Date: Sat, 15 Feb 2020 19:55:14 +0000 (+0100)
Subject: Unify handling in dispatchVC.
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=bab8d6710331d8dd4908992f1fd720f118cc926b;p=features.git

Unify handling in dispatchVC.

All these check could be actually dropped, because unless dispatchVC
is called directly, getstatus would already handle it.
---

diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index eec1b7ae6e..29f97e72a1 100644
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -3518,8 +3518,7 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 		break;
 
 	case LFUN_VC_LOCKING_TOGGLE:
-		LASSERT(buffer, return);
-		if (!ensureBufferClean(buffer) || buffer->hasReadonlyFlag())
+		if (!buffer || !ensureBufferClean(buffer) || buffer->hasReadonlyFlag())
 			break;
 		if (buffer->lyxvc().inUse()) {
 			string res = buffer->lyxvc().lockingToggle();
@@ -3534,7 +3533,8 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 		break;
 
 	case LFUN_VC_REVERT:
-		LASSERT(buffer, return);
+		if (!buffer)
+			break;
 		if (buffer->lyxvc().revert()) {
 			reloadBuffer(*buffer);
 			dr.clearMessageUpdate();
@@ -3542,6 +3542,8 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 		break;
 
 	case LFUN_VC_UNDO_LAST:
+		if (!buffer)
+			break;
 		LASSERT(buffer, return);
 		buffer->lyxvc().undoLast();
 		reloadBuffer(*buffer);
@@ -3549,7 +3551,8 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 		break;
 
 	case LFUN_VC_REPO_UPDATE:
-		LASSERT(buffer, return);
+		if (!buffer)
+			break;
 		if (ensureBufferClean(buffer)) {
 			dr.setMessage(buffer->lyxvc().repoUpdate());
 			checkExternallyModifiedBuffers();
@@ -3603,10 +3606,11 @@ void GuiView::dispatchVC(FuncRequest const & cmd, DispatchResult & dr)
 			lyx::dispatch(FuncRequest(LFUN_DIALOG_SHOW, "comparehistory"));
 			break;
 		}
+		if (!buffer)
+			break;
 
 		string rev1 = cmd.getArg(0);
 		string f1, f2;
-		LATTEST(buffer)
 
 		// f1
 		if (!buffer->lyxvc().prepareFileRevision(rev1, f1))