From: Abdelrazak Younes <younes@lyx.org>
Date: Wed, 8 Oct 2008 14:52:07 +0000 (+0000)
Subject: moveItem(): simplify a bit more and clarify comment.
X-Git-Tag: 1.6.10~3113
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=9601279dbb683876c313af5c38cc4556c291ae3f;p=features.git

moveItem(): simplify a bit more and clarify comment.



git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@26813 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/paragraph_funcs.cpp b/src/paragraph_funcs.cpp
index 0d53d3a9cf..f771391560 100644
--- a/src/paragraph_funcs.cpp
+++ b/src/paragraph_funcs.cpp
@@ -37,12 +37,11 @@ static bool moveItem(Paragraph & fromPar, pos_type fromPos,
 	// Therefore, it should only be used for breaking and merging paragraphs
 
 	Font const tmpFont = fromPar.getFontSettings(params, fromPos);
-	Change const tmpChange = fromPar.lookupChange(fromPos);
+	Change const & tmpChange = fromPar.lookupChange(fromPos);
 
-	Inset * tmpInset = fromPar.getInset(fromPos);
-	if (tmpInset) {
-		// the inset is not in the paragraph any more
-		tmpInset = fromPar.releaseInset(fromPos);
+	if (Inset * tmpInset = fromPar.getInset(fromPos)) {
+		fromPar.releaseInset(fromPos);
+		// The inset is not in fromPar any more.
 		return toPar.insertInset(toPos, tmpInset, tmpFont, tmpChange);
 	}