From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Sat, 26 Oct 2019 22:09:05 +0000 (+0200)
Subject: Remove some useless expressions
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=931e55f414da594ad24eb59a920a18943f65a51a;p=features.git

Remove some useless expressions

Spotted by cppcheck
---

diff --git a/src/BiblioInfo.cpp b/src/BiblioInfo.cpp
index e7ca878a2b..8d5bfe5f72 100644
--- a/src/BiblioInfo.cpp
+++ b/src/BiblioInfo.cpp
@@ -1330,7 +1330,6 @@ docstring const BiblioInfo::getInfo(docstring const & key,
 		return docstring(_("Bibliography entry not found!"));
 	BibTeXInfo const & data = it->second;
 	BibTeXInfoList xrefptrs;
-	vector<docstring> const xrefs = getXRefs(data);
 	for (docstring const & xref : getXRefs(data)) {
 		BiblioInfo::const_iterator const xrefit = find(xref);
 		if (xrefit != end())
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index b960da6399..0aad452fd0 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -3185,7 +3185,6 @@ void BufferView::draw(frontend::Painter & pain, bool paint_caret)
 		// however, the different coordinates of insets and paragraphs
 		// needs to be updated.
 		LYXERR(Debug::PAINTING, "Strategy: NoScreenUpdate");
-		pi.full_repaint = false;
 		if (pain.isNull()) {
 			pi.full_repaint = true;
 			tm.draw(pi, 0, y);
diff --git a/src/Text3.cpp b/src/Text3.cpp
index aba73974de..664ffb459b 100644
--- a/src/Text3.cpp
+++ b/src/Text3.cpp
@@ -581,7 +581,6 @@ Language const * getLanguage(Cursor const & cur, string const & lang)
 docstring resolveLayout(docstring layout, DocIterator const & dit)
 {
 	Paragraph const & par = dit.paragraph();
-	docstring const old_layout = par.layout().name();
 	DocumentClass const & tclass = dit.buffer()->params().documentClass();
 
 	if (layout.empty())
diff --git a/src/frontends/qt/GuiView.cpp b/src/frontends/qt/GuiView.cpp
index 581967fc4d..bbc9beb378 100644
--- a/src/frontends/qt/GuiView.cpp
+++ b/src/frontends/qt/GuiView.cpp
@@ -1996,7 +1996,6 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
 			break;
 		}
 		return doc_buffer->getStatus(cmd, flag);
-		break;
 	}
 
 	case LFUN_BUFFER_EXPORT_AS: