From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Tue, 17 Sep 2019 21:22:35 +0000 (+0200)
Subject: Pass some variables as reference
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=92b7449e85a3b95564da4a73feebdfe3b8700fee;p=features.git

Pass some variables as reference

Spotted by cppcheck.
---

diff --git a/src/frontends/qt/GuiBibtex.cpp b/src/frontends/qt/GuiBibtex.cpp
index 8414daa1cd..897224cfee 100644
--- a/src/frontends/qt/GuiBibtex.cpp
+++ b/src/frontends/qt/GuiBibtex.cpp
@@ -520,7 +520,7 @@ vector<docstring> GuiBibtex::getFileEncodings()
 }
 
 
-void GuiBibtex::setFileEncodings(vector<docstring> const m)
+void GuiBibtex::setFileEncodings(vector<docstring> const & m)
 {
 	for (docstring const & s: m) {
 		docstring key;
diff --git a/src/frontends/qt/GuiBibtex.h b/src/frontends/qt/GuiBibtex.h
index 997902e4ab..214ff854c8 100644
--- a/src/frontends/qt/GuiBibtex.h
+++ b/src/frontends/qt/GuiBibtex.h
@@ -88,7 +88,7 @@ private:
 	///
 	std::vector<docstring> getFileEncodings();
 	///
-	void setFileEncodings(std::vector<docstring> const m);
+	void setFileEncodings(std::vector<docstring> const & m);
 
 	///
 	bool initialiseParams(std::string const & data);
diff --git a/src/frontends/qt/GuiCitation.cpp b/src/frontends/qt/GuiCitation.cpp
index e5610589c8..88a22fe2e0 100644
--- a/src/frontends/qt/GuiCitation.cpp
+++ b/src/frontends/qt/GuiCitation.cpp
@@ -692,7 +692,7 @@ QStringList GuiCitation::selectedKeys()
 }
 
 
-void GuiCitation::setPreTexts(vector<docstring> const m)
+void GuiCitation::setPreTexts(vector<docstring> const & m)
 {
 	// account for multiple use of the same keys
 	QList<QModelIndex> handled;
@@ -731,7 +731,7 @@ vector<docstring> GuiCitation::getPreTexts()
 }
 
 
-void GuiCitation::setPostTexts(vector<docstring> const m)
+void GuiCitation::setPostTexts(vector<docstring> const & m)
 {
 	// account for multiple use of the same keys
 	QList<QModelIndex> handled;
diff --git a/src/frontends/qt/GuiCitation.h b/src/frontends/qt/GuiCitation.h
index 428ea50a97..d3a23b587c 100644
--- a/src/frontends/qt/GuiCitation.h
+++ b/src/frontends/qt/GuiCitation.h
@@ -121,11 +121,11 @@ private:
 	/// Get selected keys
 	QStringList selectedKeys();
 	/// Set pre texts of qualified lists
-	void setPreTexts(std::vector<docstring> const m);
+	void setPreTexts(std::vector<docstring> const & m);
 	/// Get pre texts of qualified lists
 	std::vector<docstring> getPreTexts();
 	/// Set post texts of qualified lists
-	void setPostTexts(std::vector<docstring> const m);
+	void setPostTexts(std::vector<docstring> const & m);
 	/// Get post texts of qualified lists
 	std::vector<docstring> getPostTexts();