From: Juergen Spitzmueller <spitz@lyx.org>
Date: Fri, 20 Oct 2023 07:53:38 +0000 (+0200)
Subject: Fix tautology spotted by coverity
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=906f2b8507b45ba865fa99acef2f386b12115dab;p=features.git

Fix tautology spotted by coverity

The if and else paths have been identical since the removal of dvipost
(a450797b2ab160f5)
---

diff --git a/src/tex2lyx/text.cpp b/src/tex2lyx/text.cpp
index fb06cfb4c1..f5244fbaa5 100644
--- a/src/tex2lyx/text.cpp
+++ b/src/tex2lyx/text.cpp
@@ -4343,21 +4343,10 @@ void parse_text(Parser & p, ostream & os, unsigned flags, bool outer,
 				os << "\n\\change_deleted ";
 			os << author.bufferId() << ' ' << ptime << '\n';
 			parse_text_snippet(p, os, FLAG_ITEM, outer, context);
-			bool xcolorulem = LaTeXPackages::isAvailable("ulem") &&
-			                  LaTeXPackages::isAvailable("xcolor");
-			// No need to test for luatex, since luatex comes in
-			// two flavours (dvi and pdf), like latex, and those
-			// are detected by pdflatex.
-			if (pdflatex || xetex) {
-				if (xcolorulem) {
-					preamble.registerAutomaticallyLoadedPackage("ulem");
-					preamble.registerAutomaticallyLoadedPackage("xcolor");
-				}
-			} else {
-				if (xcolorulem) {
-					preamble.registerAutomaticallyLoadedPackage("ulem");
-					preamble.registerAutomaticallyLoadedPackage("xcolor");
-				}
+			if (LaTeXPackages::isAvailable("ulem")
+			    && LaTeXPackages::isAvailable("xcolor")) {
+				preamble.registerAutomaticallyLoadedPackage("ulem");
+				preamble.registerAutomaticallyLoadedPackage("xcolor");
 			}
 			continue;
 		}