From: Günter Milde <milde@lyx.org>
Date: Mon, 6 May 2019 06:52:24 +0000 (+0200)
Subject: "unicode=true" leads to errors for Japanese with "platex" even when using utf8-encode... 
X-Git-Tag: lyx-2.4.0dev-acb2ca7b~2076
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=8e88d100f152946944a26087231836dd2e34c902;p=features.git

"unicode=true" leads to errors for Japanese with "platex" even when using utf8-encoded latex source.

The bxjsbook class raises an error if seeing this option
(before TL19 only a warning). Other document classes just ignore
it and PDF-bookmarks are wrongly encoded in any case.
---

diff --git a/src/PDFOptions.cpp b/src/PDFOptions.cpp
index d64cc2975e..0b5b139e95 100644
--- a/src/PDFOptions.cpp
+++ b/src/PDFOptions.cpp
@@ -105,8 +105,7 @@ void PDFOptions::writeLaTeX(OutputParams & runparams, otexstream & os,
 	// with the hyperref option "unicode".
 	// (With Xe/LuaTeX and pTeX, unicode=true is the default
 	// and the option leads to errors with some Japanese document classes)
-	if (!runparams.isFullUnicode() 
-		&& (!runparams.use_japanese || runparams.encoding->iconvName() == "UTF-8"))
+	if (!runparams.isFullUnicode() && !runparams.use_japanese)
 		opt += "unicode=true,";
 
 	// only use the hyperref settings if hyperref is enabled by the user