From: Jean-Marc Lasgouttes <lasgouttes@lyx.org>
Date: Thu, 12 Sep 2024 16:33:45 +0000 (+0200)
Subject: Avoid a couple of copies.
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=8e181e992da3054fc1a0221615f9dd4920332ace;p=lyx.git

Avoid a couple of copies.

Spotted by Coverity scan.
---

diff --git a/src/frontends/qt/Menus.cpp b/src/frontends/qt/Menus.cpp
index abd625509c..480c03013d 100644
--- a/src/frontends/qt/Menus.cpp
+++ b/src/frontends/qt/Menus.cpp
@@ -1725,10 +1725,6 @@ void MenuDefinition::expandCiteStyles(BufferView const * bv)
 		&& (keys.size() > 1
 		    || !citinset->getParam("pretextlist").empty()
 		    || !citinset->getParam("posttextlist").empty());
-	vector<pair<docstring, docstring>> pres =
-		citinset->getQualifiedLists(citinset->getParam("pretextlist"));
-	vector<pair<docstring, docstring>> posts =
-		citinset->getQualifiedLists(citinset->getParam("posttextlist"));
 
 	CiteItem ci;
 	ci.textBefore = citinset->getParam("before");
@@ -1738,8 +1734,10 @@ void MenuDefinition::expandCiteStyles(BufferView const * bv)
 	ci.context = CiteItem::Dialog;
 	ci.max_size = 40;
 	ci.isQualified = qualified;
-	ci.pretexts = pres;
-	ci.posttexts = posts;
+	ci.pretexts =
+		citinset->getQualifiedLists(citinset->getParam("pretextlist"));
+	ci.posttexts =
+		citinset->getQualifiedLists(citinset->getParam("posttextlist"));
 	BiblioInfo::CiteStringMap citeStrings =
 		buf->masterBibInfo().getCiteStrings(keys, citeStyleList, bv->buffer(), ci);