From: Edwin Leuven <e.leuven@gmail.com>
Date: Mon, 24 Mar 2008 14:03:00 +0000 (+0000)
Subject: remove cruft (simplify code)
X-Git-Tag: 1.6.10~5465
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=8aae2dcd3bb461462461b5b0fe29193018e9aada;p=features.git

remove cruft (simplify code)

git-svn-id: svn://svn.lyx.org/lyx/lyx-devel/trunk@23922 a592a061-630c-0410-9148-cb99ea01b6c8
---

diff --git a/src/insets/InsetTabular.cpp b/src/insets/InsetTabular.cpp
index 03f825fffc..986aaf3714 100644
--- a/src/insets/InsetTabular.cpp
+++ b/src/insets/InsetTabular.cpp
@@ -845,116 +845,78 @@ int Tabular::getAdditionalWidth(idx_type cell) const
 }
 
 
-// returns the maximum over all rows
 int Tabular::columnWidth(idx_type cell) const
 {
-	col_type const column1 = cellColumn(cell);
-	col_type const column2 = cellRightColumn(cell);
-	int result = 0;
-	for (col_type i = column1; i <= column2; ++i)
-		result += column_info[i].width;
-	return result;
+	int w = 0;
+	col_type const span = columnSpan(cell);
+	col_type const col = cellColumn(cell);
+	for(col_type c = col; c < col + span ; ++c)
+		w += column_info[c].width;
+	return w;
 }
 
 
-int Tabular::width() const
+bool Tabular::updateColumnWidths()
 {
-	int width = 0;
-	for (col_type i = 0; i < columnCount(); ++i)
-		width += column_info[i].width;
-	return width;
-}
+	col_type const ncols = columnCount();
+	row_type const nrows = rowCount();
+	bool update = false;
+	// for each col get max of single col cells
+	for(col_type c = 0; c < ncols; ++c) {
+		int new_width = 0;
+		for(row_type r = 0; r < nrows; ++r) {
+			idx_type const i = cellIndex(r, c);
+			if (columnSpan(i) == 1)
+				new_width = max(new_width, cellinfo_of_cell(i).width);
+		}
 
+		if (column_info[c].width != new_width) {
+			column_info[c].width = new_width;
+			update = true;
+		}
+	}
+	// update col widths to fit merged cells
+	for(col_type c = 0; c < ncols; ++c)
+		for(row_type r = 0; r < nrows; ++r) {
+			idx_type const i = cellIndex(r, c);
+			int const span = columnSpan(i);
+			if (span == 1 || c > cellColumn(i))
+				continue;
 
-// returns true if a complete update is necessary, otherwise false
-bool Tabular::setWidthOfMulticolCell(idx_type cell, int new_width)
-{
-	if (!isMultiColumn(cell))
-		return false;
+			int old_width = 0;
+			for(col_type j = c; j < c + span ; ++j)
+				old_width += column_info[j].width;
 
-	row_type const row = cellRow(cell);
-	col_type const column1 = cellColumn(cell);
-	col_type const column2 = cellRightColumn(cell);
-	int const old_val = cell_info[row][column2].width;
+			if (cellinfo_of_cell(i).width > old_width) {
+				column_info[c + span - 1].width += cellinfo_of_cell(i).width - old_width;
+				update = true;
+			}
+		}
 
-	// first set columns to 0 so we can calculate the right width
-	for (col_type i = column1; i <= column2; ++i) {
-		cell_info[row][i].width = 0;
-	}
-	// set the width to MAX_WIDTH until width > 0
-	int width = new_width + 2 * WIDTH_OF_LINE;
-	col_type i = column1;
-	for (; i < column2 && width > column_info[i].width; ++i) {
-		cell_info[row][i].width = column_info[i].width;
-		width -= column_info[i].width;
-	}
-	if (width > 0) {
-		cell_info[row][i].width = width;
-	}
-	if (old_val != cell_info[row][column2].width) {
-		// in this case we have to recalculate all multicolumn cells which
-		// have this column as one of theirs but not as last one
-		calculate_width_of_column_NMC(i);
-		recalculateMulticolumnsOfColumn(i);
-		calculate_width_of_column(i);
-	}
-	return true;
+	return update;
 }
 
 
-void Tabular::recalculateMulticolumnsOfColumn(col_type column)
+int Tabular::width() const
 {
-	// the last column does not have to be recalculated because all
-	// multicolumns will have here there last multicolumn cell which
-	// always will have the whole rest of the width of the cell.
-	if (columnCount() < 2 || column > (columnCount() - 2))
-		return;
-	for (row_type row = 0; row < rowCount(); ++row) {
-		int mc = cell_info[row][column].multicolumn;
-		int nmc = cell_info[row][column+1].multicolumn;
-		// we only have to update multicolumns which do not have this
-		// column as their last column!
-		if (mc == CELL_BEGIN_OF_MULTICOLUMN ||
-			  (mc == CELL_PART_OF_MULTICOLUMN &&
-			   nmc == CELL_PART_OF_MULTICOLUMN))
-		{
-			idx_type const cellno = cell_info[row][column].cellno;
-			setWidthOfMulticolCell(cellno,
-					       cellWidth(cellno) - 2 * WIDTH_OF_LINE);
-		}
-	}
+	col_type const ncols = columnCount();
+	int width = 0;
+	for (col_type i = 0; i < ncols; ++i)
+		width += column_info[i].width;
+	return width;
 }
 
 
 void Tabular::setCellWidth(idx_type cell, int new_width)
 {
-	row_type const row = cellRow(cell);
 	col_type const col = cellColumn(cell);
-	bool tmp = false;
-	int width = 0;
 	int add_width = 0;
-
 	if (col < columnCount() - 1 && columnRightLine(col) &&
 		columnLeftLine(col + 1)) {
 		add_width = WIDTH_OF_LINE;
 	}
-
-	if (cellWidth(cell) == new_width + 2 * WIDTH_OF_LINE + add_width)
-		return;
-
-	if (isMultiColumnReal(cell)) {
-		tmp = setWidthOfMulticolCell(cell, new_width);
-	} else {
-		width = new_width + 2 * WIDTH_OF_LINE + add_width;
-		cell_info[row][col].width = width;
-		tmp = calculate_width_of_column_NMC(col);
-		if (tmp)
-			recalculateMulticolumnsOfColumn(col);
-	}
-	if (tmp) {
-		for (col_type i = 0; i < columnCount(); ++i)
-			calculate_width_of_column(i);
-	}
+	cellinfo_of_cell(cell).width = new_width + 2 * WIDTH_OF_LINE + add_width;
+	return;
 }
 
 
@@ -1185,13 +1147,7 @@ docstring const Tabular::getAlignSpecial(idx_type cell, int what) const
 
 int Tabular::cellWidth(idx_type cell) const
 {
-	row_type const row = cellRow(cell);
-	col_type const column1 = cellColumn(cell);
-	col_type const column2 = cellRightColumn(cell);
-	int result = 0;
-	for (col_type i = column1; i <= column2; ++i)
-		result += cell_info[row][i].width;
-	return result;
+	return cellinfo_of_cell(cell).width;
 }
 
 
@@ -1246,39 +1202,6 @@ Tabular::idx_type Tabular::getLastCellInRow(row_type row) const
 }
 
 
-void Tabular::calculate_width_of_column(col_type column)
-{
-	int maximum = 0;
-	for (row_type i = 0; i < rowCount(); ++i)
-		maximum = max(cell_info[i][column].width, maximum);
-	column_info[column].width = maximum;
-}
-
-
-//
-// Calculate the columns regarding ONLY the normal cells and if this
-// column is inside a multicolumn cell then use it only if its the last
-// column of this multicolumn cell as this gives an added width to the
-// column, all the rest should be adapted!
-//
-bool Tabular::calculate_width_of_column_NMC(col_type column)
-{
-	int const old_column_width = column_info[column].width;
-	int max = 0;
-	for (row_type i = 0; i < rowCount(); ++i) {
-		idx_type cell = cellIndex(i, column);
-		bool ismulti = isMultiColumnReal(cell);
-		if ((!ismulti || column == cellRightColumn(cell)) &&
-			cell_info[i][column].width > max)
-		{
-			max = cell_info[i][column].width;
-		}
-	}
-	column_info[column].width = max;
-	return column_info[column].width != old_column_width;
-}
-
-
 Tabular::row_type Tabular::cellRow(idx_type cell) const
 {
 	if (cell >= cellCount())
@@ -1543,12 +1466,10 @@ void Tabular::setMultiColumn(idx_type cell, idx_type number)
 Tabular::idx_type Tabular::columnSpan(idx_type cell) const
 {
 	row_type const row = cellRow(cell);
-	col_type column = cellColumn(cell);
+	col_type const ncols = columnCount();
 	idx_type result = 1;
-	++column;
-	while (column < columnCount() &&
-		   cell_info[row][column].multicolumn == CELL_PART_OF_MULTICOLUMN)
-	{
+	col_type column = cellColumn(cell) + 1;
+	while (column < ncols && isPartOfMultiColumn(row, column)) {
 		++result;
 		++column;
 	}
@@ -2959,7 +2880,7 @@ void InsetTabular::metrics(MetricsInfo & mi, Dimension & dim) const
 			tabular.row_info[i].bottom_space.inPixels(mi.base.textwidth);
 		tabular.setRowDescent(i, maxDesc + ADD_TO_HEIGHT + bottom_space);
 	}
-
+	tabular.updateColumnWidths();
 	dim.asc = tabular.rowAscent(0);
 	dim.des = tabular.height() - dim.asc;
 	dim.wid = tabular.width() + 2 * ADD_TO_TABULAR_WIDTH;
diff --git a/src/insets/InsetTabular.h b/src/insets/InsetTabular.h
index 61b66eae9e..9caac398dc 100644
--- a/src/insets/InsetTabular.h
+++ b/src/insets/InsetTabular.h
@@ -600,14 +600,8 @@ public:
 		  col_type columns_arg);
 	///
 	void updateIndexes();
-	/// Returns true if a complete update is necessary, otherwise false
-	bool setWidthOfMulticolCell(idx_type cell, int new_width);
-	///
-	void recalculateMulticolumnsOfColumn(col_type column);
-	/// Returns true if change
-	void calculate_width_of_column(col_type column);
-	///
-	bool calculate_width_of_column_NMC(col_type column); // no multi cells
+	/// return true of update is needed
+	bool updateColumnWidths();
 	///
 	idx_type columnSpan(idx_type cell) const;
 	///