From: Juergen Spitzmueller <spitz@lyx.org>
Date: Wed, 19 Sep 2012 08:14:56 +0000 (+0200)
Subject: Do not update refs on new label creation (#8147)
X-Git-Tag: 2.1.0beta1~1538
X-Git-Url: https://git.lyx.org/gitweb/?a=commitdiff_plain;h=86cccf10771cb00c71fac2becf39dd7e9a301d45;p=lyx.git

Do not update refs on new label creation (#8147)

This assures that refs to existing labels are not being touched if a new label with a duplicate name is created, and the name then changed by the duplicate checker.

Branch candidate.
---

diff --git a/src/insets/InsetLabel.cpp b/src/insets/InsetLabel.cpp
index 443c78e1cb..e52540e89d 100644
--- a/src/insets/InsetLabel.cpp
+++ b/src/insets/InsetLabel.cpp
@@ -55,9 +55,11 @@ InsetLabel::InsetLabel(Buffer * buf, InsetCommandParams const & p)
 
 void InsetLabel::initView()
 {
-	// FIXME: This seems to be used only for inset creation so
-	// we probably just need to call updateLabel() here.
-	updateLabelAndRefs(getParam("name"));
+	// This seems to be used only for inset creation.
+	// Therefore we do not update refs here, since this would
+	// erroneously change refs from existing duplicate labels
+	// (#8141).
+	updateLabel(getParam("name"));
 }